From: maxim.cournoyer@gmail.com
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 40264-done@debbugs.gnu.org
Subject: bug#40264: Mirror and Formatting
Date: Thu, 16 Apr 2020 00:49:08 -0400 [thread overview]
Message-ID: <87lfmwkpbv.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <5707875209a8eadf81873cc902f88aa5@disroot.org> (Raghav Gururajan's message of "Wed, 08 Apr 2020 07:29:48 +0000")
Hello Raghav,
"Raghav Gururajan" <raghavgururajan@disroot.org> writes:
> From 5b3dc89e93749fb4ff1e2d246db20e61a54e6232 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Wed, 8 Apr 2020 03:28:07 -0400
> Subject: [PATCH 3/3] gnu: linphone: Fix formatting.
>
> * gnu/packages/linphone.scm: Fix formatting.
> ---
> gnu/packages/linphone.scm | 84 ++++++++++++++++++++-------------------
> 1 file changed, 44 insertions(+), 40 deletions(-)
>
> diff --git a/gnu/packages/linphone.scm b/gnu/packages/linphone.scm
> index 39109ff877..0e3281de4b 100644
> --- a/gnu/packages/linphone.scm
> +++ b/gnu/packages/linphone.scm
> @@ -70,9 +70,9 @@
> (list
> "-DENABLE_STATIC=NO"))) ; Not required
> (synopsis "Belledonne Communications Unit Testing Framework")
> - (description "BCUnit is a fork of the defunct project CUnit,
> -with several fixes and patches applied. It is an unit testing
> -framework for writing, administering, and running unit tests in C.")
> + (description "BCUnit is a fork of the defunct project CUnit, with several
> +fixes and patches applied. It is an unit testing framework for writing,
> +administering, and running unit tests in C.")
> (home-page "https://gitlab.linphone.org/BC/public/bcunit")
> (license license:lgpl2.0+)))
>
> @@ -124,9 +124,10 @@ Communications softwares like belle-sip, mediastreamer2 and linphone.")
> (inputs
> `(("bctoolbox" ,bctoolbox)))
> (synopsis "Belledonne Communications Language Recognition Library")
> - (description "Belr is Belledonne Communications' language recognition library,
> -written in C++11. It parses text inputs formatted according to a language
> -defined by an ABNF grammar, such as the protocols standardized at IETF.")
> + (description "Belr is Belledonne Communications' language recognition
> +library, written in C++11. It parses text inputs formatted according to a
> +language defined by an ABNF grammar, such as the protocols standardized at
> +IETF.")
> (home-page "https://gitlab.linphone.org/BC/public/belr")
> (license license:gpl3+)))
>
> @@ -152,7 +153,8 @@ defined by an ABNF grammar, such as the protocols standardized at IETF.")
> `(("bctoolbox" ,bctoolbox)
> ("belr" ,belr)))
> (synopsis "Belledonne Communications VCard Library")
> - (description "Belcard is a C++ library to manipulate VCard standard format.")
> + (description "Belcard is a C++ library to manipulate VCard standard
> +format.")
> (home-page "https://gitlab.linphone.org/BC/public/belcard")
> (license license:gpl3+)))
>
> @@ -175,16 +177,16 @@ defined by an ABNF grammar, such as the protocols standardized at IETF.")
> (list
> "-DENABLE_STATIC=NO"))) ; Not required
> (synopsis "Belledonne Communications Media Container")
> - (description "BcMatroska is a free and open standard multi-media
> -container format. It can hold an unlimited number of video, audio,
> -picture, or subtitle tracks in one file. ")
> + (description "BcMatroska is a free and open standard multi-media container
> +format. It can hold an unlimited number of video, audio, picture, or subtitle
> +tracks in one file. ")
> (home-page "https://gitlab.linphone.org/BC/public/bcmatroska2")
> (license
> (list
> - ;; That license applies for Core C and LibEBML2.
> + ;; For Core C and LibEBML2.
> ;; https://www.matroska.org/node/47
> license:bsd-4
> - ;; That license applies for LibMatroska2.
> + ;; For LibMatroska2.
> ;; https://www.matroska.org/node/47
> license:lgpl2.1+))))
>
> @@ -261,15 +263,15 @@ implements the RFC 3550 standard.")
> `(#:tests? #f ; No test target
> #:configure-flags
> (list
> - "-DENABLE_STATIC=NO")))
> + "-DENABLE_STATIC=NO"))) ; Not required
> (inputs
> `(("bctoolbox" ,bctoolbox)
> ("sqlite3" ,sqlite)
> ("xml2" ,libxml2)))
> (synopsis "Belledonne Communications ZRTP Library")
> - (description "BZRTP is an implementation of ZRTP keys exchange
> -protocol, written in C. It is fully portable and can be executed on many
> -platforms including both ARM and x86.")
> + (description "BZRTP is an implementation of ZRTP keys exchange protocol,
> +written in C. It is fully portable and can be executed on many platforms
> +including both ARM and x86.")
> (home-page "https://gitlab.linphone.org/BC/public/bzrtp")
> (license license:gpl2+)))
>
> @@ -290,15 +292,15 @@ platforms including both ARM and x86.")
> `(#:tests? #f ; Requires network access
> #:configure-flags
> (list
> - "-DENABLE_STATIC=NO")
> + "-DENABLE_STATIC=NO") ; Not required
> #:phases
> (modify-phases %standard-phases
> (add-after 'unpack 'patch
> (lambda _
> (substitute* "src/CMakeLists.txt"
> - ;; ANTLR would use multithreaded DFA generation
> - ;; otherwise--which would not be reproducible.
> - (("-Xmultithreaded ") ""))
> + ;; ANTLR would use multithreaded DFA generation otherwise,
> + ;; which would not be reproducible.
> + (("-Xmultithreaded ") ""))
> #t)))))
> (inputs
> `(("antlr3" ,antlr3-3.3)
> @@ -325,7 +327,8 @@ API. It also comprises a simple HTTP/HTTPS client implementation.")
> "/" name "-" version ".tar.gz"))
> (sha256
> (base32 "0whpqr69wz0pnzvragkpfblxhd0rds8k06c3mw5a0ag216a1yd9k"))
> - (patches (search-patches "mediastreamer2-srtp2.patch"))))
> + (patches
> + (search-patches "mediastreamer2-srtp2.patch"))))
> (outputs '("out" "doc" "tester"))
> (build-system cmake-build-system)
> (arguments
> @@ -393,13 +396,12 @@ API. It also comprises a simple HTTP/HTTPS client implementation.")
> ("vpx" ,libvpx)
> ("x11" ,libx11)
> ("xv" ,libxv)
> - ("zrtp", bzrtp)))
> + ("zrtp" ,bzrtp)))
> (synopsis "Belledonne Communications Streaming Engine")
> - (description "Mediastreamer2 is a powerful and lightweight
> -streaming engine for telephony applications. This media processing
> -and streaming toolkit is responsible for receiving and sending all
> -multimedia streams in Linphone, including media capture, encoding and
> -decoding, and rendering.")
> + (description "Mediastreamer2 is a powerful and lightweight streaming engine
> +for telephony applications. This media processing and streaming toolkit is
> +responsible for receiving and sending all multimedia streams in Linphone,
> +including media capture, encoding and decoding, and rendering.")
> (home-page "https://gitlab.linphone.org/BC/public/mediastreamer2")
> (license license:gpl2+)))
>
> @@ -461,11 +463,11 @@ decoding, and rendering.")
> (propagated-inputs
> `(("murrine" ,murrine))) ; Required for GTK UI
> (synopsis "Belledonne Communications Softphone Library")
> - (description "Liblinphone is a high-level SIP library integrating
> -all calling and instant messaging features into an unified
> -easy-to-use API. It is the cross-platform VoIP library on which the
> -Linphone application is based on, and that anyone can use to add audio
> -and video calls or instant messaging capabilities to an application.")
> + (description "Liblinphone is a high-level SIP library integrating all
> +calling and instant messaging features into an unified easy-to-use API. It is
> +the cross-platform VoIP library on which the Linphone application is based on,
> +and that anyone can use to add audio and video calls or instant messaging
> +capabilities to an application.")
> (home-page "https://gitlab.linphone.org/BC/public/liblinphone")
> (license license:gpl2+)))
>
> @@ -487,11 +489,13 @@ and video calls or instant messaging capabilities to an application.")
> (origin
> (method url-fetch)
> (uri
> - (string-append "https://gitlab.linphone.org/BC/public/msopenh264/commit/"
> - "493d147d28c9a0f788ba4e50b47a1ce7b18bf326.diff"))
> + (string-append "https://gitlab.linphone.org/BC/public/msopenh264/"
> + "commit/493d147d28c9a0f788ba4e50b47a1ce7b18bf326"
> + ".diff"))
> (file-name "msopenh264-openh264.patch")
> (sha256
> - (base32 "0mmd7nz5n9ian4rcwn200nldmy5j0dpdrna7r32rqnaw82bx3kdb")))))))
> + (base32
> + "0mmd7nz5n9ian4rcwn200nldmy5j0dpdrna7r32rqnaw82bx3kdb")))))))
> (build-system cmake-build-system)
> (arguments
> `(#:tests? #f ; No test target
> @@ -530,8 +534,8 @@ mediastreamer2 based on the openh264 library.")
> `(("mediastreamer2" ,mediastreamer2)
> ("ortp" ,ortp)))
> (synopsis "Media Streamer SILK Codec")
> - (description "MSSILK is a plugin of MediaStreamer, adding support for
> -AMR codec. It is based on the Skype's SILK implementation.")
> + (description "MSSILK is a plugin of MediaStreamer, adding support for AMR
> +codec. It is based on the Skype's SILK implementation.")
> (home-page "https://gitlab.linphone.org/BC/public/mssilk")
> (license license:gpl2+)))
>
> @@ -552,7 +556,7 @@ AMR codec. It is based on the Skype's SILK implementation.")
> `(#:tests? #f ; No test target
> #:configure-flags
> (list
> - "-DENABLE_STATIC=NO")))
> + "-DENABLE_STATIC=NO"))) ; Not required
> (inputs
> `(("bctoolbox" ,bctoolbox)
> ("mediastreamer2" ,mediastreamer2)
> @@ -588,7 +592,7 @@ WebRTC codec. It includes features from WebRTC, such as, iSAC and AECM.")
> ("ortp" ,ortp)
> ("voamrwbenc" ,vo-amrwbenc)))
> (synopsis "Media Streamer AMR Codec")
> - (description "MSAMR is a plugin of MediaStreamer, adding support for
> -AMR codec. It is based on the opencore-amr implementation.")
> + (description "MSAMR is a plugin of MediaStreamer, adding support for AMR
> +codec. It is based on the opencore-amr implementation.")
> (home-page "https://gitlab.linphone.org/BC/public/msamr")
> (license license:gpl3+)))
Please not that we usually submit changes *per-package*, that is, one
commit per package. It's a convention we use. I'm making an exception
here because the changes are cosmetic only, but keep this in mind for
your next changes.
I've pushed a slightly modified version of the above changes in commit
1988ef21f82430d4b380dd4887160a902d8796fd (on the core-updates branch).
Thank you for your contributions and your patience in the lengthy review
process.
Maxim
next prev parent reply other threads:[~2020-04-16 4:50 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 23:10 [bug#40264] Linphone Raghav Gururajan
2020-03-27 23:13 ` [bug#40264] Linphone: 1-create-linphone-module Raghav Gururajan
2020-03-27 23:14 ` [bug#40264] Linphone: 2-update-linphone-module Raghav Gururajan
2020-03-27 23:15 ` [bug#40264] Linphone: 3-add-bcunit Raghav Gururajan
2020-04-01 2:46 ` Maxim Cournoyer
2020-03-27 23:21 ` [bug#40264] Linphone: 4-add-bctoolbox Raghav Gururajan
2020-03-28 18:40 ` [bug#40264] Linphone: 5-add-belr Raghav Gururajan
2020-03-28 19:40 ` [bug#40264] Linphone: 6-add-belcard Raghav Gururajan
2020-03-28 21:22 ` [bug#40264] Linphone: 7-add-bcmatroska2 Raghav Gururajan
2020-03-28 21:35 ` [bug#40264] Linphone: 8-add-bcg729 Raghav Gururajan
2020-03-28 22:14 ` [bug#40264] Linphone: 9-add-ortp Raghav Gururajan
2020-03-28 22:36 ` [bug#40264] Linphone: 10-add-bzrtp Raghav Gururajan
2020-03-29 8:58 ` [bug#40264] Linphone: 11-add-mediastreamer Raghav Gururajan
2020-03-30 2:45 ` [bug#40264] Linphone: 12-add-belle-sip Raghav Gururajan
2020-03-30 20:45 ` Danny Milosavljevic
2020-03-31 16:32 ` Raghav Gururajan
2020-04-01 2:38 ` Maxim Cournoyer
2020-03-30 9:47 ` [bug#40264] Linphone: 13-add-linphone Raghav Gururajan
2020-03-30 16:50 ` [bug#40264] Linphone: 14-add-linphoneqt Raghav Gururajan
2020-03-31 13:44 ` [bug#40264] Linphone: 15-add-msamr Raghav Gururajan
2020-03-31 14:12 ` [bug#40264] Linphone: 16-add-openh264 Raghav Gururajan
2020-03-31 14:31 ` [bug#40264] Linphone: 17-add-mssilk Raghav Gururajan
2020-03-31 14:50 ` [bug#40264] Linphone: 18-add-mswebrtc Raghav Gururajan
2020-04-01 20:21 ` [bug#40264] Linphone: 3-add-bcunit-v2 Raghav Gururajan
2020-04-03 10:51 ` Danny Milosavljevic
2020-04-01 22:13 ` [bug#40264] Linphone: 4-add-bctoolbox-v2 Raghav Gururajan
2020-04-03 10:52 ` Danny Milosavljevic
2020-04-01 22:20 ` [bug#40264] Linphone: 5-add-belr-v2 Raghav Gururajan
2020-04-03 10:52 ` Danny Milosavljevic
2020-04-01 22:32 ` [bug#40264] Linphone: 6-add-belcard-v2 Raghav Gururajan
2020-04-03 10:51 ` Danny Milosavljevic
2020-04-01 22:40 ` [bug#40264] Linphone: 7-add-bcmatroska2-v2 Raghav Gururajan
2020-04-03 10:52 ` Danny Milosavljevic
2020-04-01 22:46 ` [bug#40264] Linphone: 8-add-bcg729-v2 Raghav Gururajan
2020-04-03 11:01 ` Danny Milosavljevic
2020-04-01 22:56 ` [bug#40264] Linphone: 9-add-ortp-v2 Raghav Gururajan
2020-04-03 11:02 ` Danny Milosavljevic
2020-04-01 23:04 ` [bug#40264] Linphone: 10-add-bzrtp-v2 Raghav Gururajan
2020-04-03 11:09 ` Danny Milosavljevic
2020-04-02 0:20 ` [bug#40264] Linphone: 11-add-mediastreamer-v2 Raghav Gururajan
2020-04-03 11:38 ` Danny Milosavljevic
2020-04-03 14:30 ` Raghav Gururajan
2020-04-05 4:08 ` maxim.cournoyer
2020-04-05 4:16 ` maxim.cournoyer
2020-04-05 7:29 ` Raghav Gururajan
2020-04-02 0:44 ` [bug#40264] Linphone: 12-add-belle-sip-v2 Raghav Gururajan
2020-04-02 11:24 ` Danny Milosavljevic
2020-04-02 16:33 ` Raghav Gururajan
2020-04-02 17:19 ` Raghav Gururajan
2020-04-03 11:34 ` Danny Milosavljevic
2020-04-04 17:36 ` Maxim Cournoyer
2020-04-04 18:18 ` Raghav Gururajan
2020-04-05 4:18 ` maxim.cournoyer
2020-04-05 19:06 ` Danny Milosavljevic
2020-04-02 1:20 ` [bug#40264] Linphone: 13-add-linphone-v2 Raghav Gururajan
2020-04-05 19:49 ` Danny Milosavljevic
2020-04-05 19:57 ` Danny Milosavljevic
2020-04-05 22:54 ` Raghav Gururajan
2020-04-05 22:55 ` Raghav Gururajan
2020-04-02 1:47 ` [bug#40264] Linphone: 14-add-linphoneqt-v2 Raghav Gururajan
2020-04-02 2:06 ` [bug#40264] Linohone: 15-add-msamr-v2 Raghav Gururajan
2020-04-06 0:03 ` Danny Milosavljevic
2020-04-02 2:55 ` [bug#40264] Linphone: 16-add-msopenh264-v2 Raghav Gururajan
2020-04-05 23:05 ` Danny Milosavljevic
2020-04-02 3:00 ` [bug#40264] Linphone: 17-add-mssilk-v2 Raghav Gururajan
2020-04-05 23:06 ` Danny Milosavljevic
2020-04-02 3:06 ` [bug#40264] Linphone: 18-add-mswebrtc-v2 Raghav Gururajan
2020-04-05 23:06 ` Danny Milosavljevic
2020-04-02 8:56 ` [bug#40264] Linphone: 14-add-linphoneqt-v3 Raghav Gururajan
2020-04-02 16:27 ` Raghav Gururajan
2020-04-02 20:56 ` Raghav Gururajan
2020-04-03 23:50 ` Raghav Gururajan
2020-04-02 20:53 ` [bug#40264] Linphone: 14-add-linphoneqt-v4 Raghav Gururajan
2020-04-02 23:19 ` [bug#40264] Linphone: 13-add-linphone-v3 Raghav Gururajan
2020-04-05 20:05 ` Danny Milosavljevic
2020-04-03 0:24 ` [bug#40264] Linphone: 14-add-linphoneqt-v5 Raghav Gururajan
2020-04-03 23:47 ` [bug#40264] Linphone: 14-add-linphoneqt-v6 Raghav Gururajan
2020-04-05 20:19 ` Danny Milosavljevic
2020-04-06 3:01 ` Raghav Gururajan
2020-04-06 5:56 ` Raghav Gururajan
2020-04-05 7:28 ` [bug#40264] Linphone: 11-add-mediastreamer-v3 Raghav Gururajan
2020-04-05 15:02 ` maxim.cournoyer
2020-04-05 18:29 ` Danny Milosavljevic
2020-04-05 19:41 ` Danny Milosavljevic
2020-04-05 22:52 ` Raghav Gururajan
2020-04-06 0:14 ` Danny Milosavljevic
2020-04-06 0:28 ` Raghav Gururajan
2020-04-06 2:40 ` maxim.cournoyer
2020-04-06 4:04 ` [bug#40264] Linphone: 14-add-linphoneqt-v7 Raghav Gururajan
2020-04-10 21:47 ` Danny Milosavljevic
2020-04-10 23:50 ` Danny Milosavljevic
2020-04-15 2:50 ` Maxim Cournoyer
2020-04-15 4:36 ` Maxim Cournoyer
2020-04-15 6:13 ` Maxim Cournoyer
2020-04-12 3:55 ` Raghav Gururajan
2020-04-08 7:01 ` [bug#40264] Replace source URI with mirror Raghav Gururajan
2020-04-08 7:29 ` [bug#40264] Mirror and Formatting Raghav Gururajan
2020-04-16 4:49 ` maxim.cournoyer [this message]
2020-04-15 2:07 ` [bug#40264] Replace source URI with mirror Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfmwkpbv.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me \
--to=maxim.cournoyer@gmail.com \
--cc=40264-done@debbugs.gnu.org \
--cc=raghavgururajan@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.