From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:56902)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTSeP-0008CG-Eb
 for guix-patches@gnu.org; Tue, 28 Apr 2020 12:00:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTSaY-00049N-ST
 for guix-patches@gnu.org; Tue, 28 Apr 2020 12:00:00 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:57823)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jTSaY-00049A-Es
 for guix-patches@gnu.org; Tue, 28 Apr 2020 11:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jTSaY-0004kG-Cr
 for guix-patches@gnu.org; Tue, 28 Apr 2020 11:56:02 -0400
Subject: [bug#40928] Subject: [PATCH 2/2] gnu: Add emacs-kakoune.
Resent-Message-ID: <handler.40928.B40928.158808932818194@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <20200428131817.2141e9e5@airmail.cc>
 <20200428132656.6e975071@airmail.cc>
Date: Tue, 28 Apr 2020 17:55:16 +0200
In-Reply-To: <20200428132656.6e975071@airmail.cc> (pinoaffe@airmail.cc's
 message of "Tue, 28 Apr 2020 13:26:56 +0200")
Message-ID: <87lfmfhafv.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: pinoaffe <pinoaffe@airmail.cc>
Cc: 40928@debbugs.gnu.org

Hello,

pinoaffe <pinoaffe@airmail.cc> writes:

> +(define-public emacs-kakoune
> +  (package
> +    (name "emacs-kakoune")
> +    (version "20191017.1502")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append
> +               "https://melpa.org/packages/kakoune-"
> +               version
> +               ".tar"))

See my previous comments about MELPA packaging and versioning.

> +        (sha256
> +          (base32
> +            "1srrrv4fxf99iypch6wyqmiyij4dmq0yrnqnim0y4q0dfvpj63r8"))))

See also my comments about alignment here.

> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +      `(("emacs-ryo-modal"        ,emacs-ryo-modal)
> +        ("emacs-multiple-cursors" ,emacs-multiple-cursors)
> +        ("emacs-expand-region"    ,emacs-expand-region)))
> +    (home-page
> +      "https://github.com/jmorag/kakoune.el")
> +    (synopsis
> +      "A simulation, but not emulation, of kakoune")

Maybe:

  Simple simulation of Kakoune inside of Emacs

> +    (description
> +      "This package provides many, but not all of the editing primitives in the kakoune editor.

kakoune -> Kakoune

> +Unlike evil-mode for vim, this is very shallow emulation, and seeks to do as little

Maybe:

  Unlike, Evil mode for Vim, this is a very shallow emulation, which ...

or even:

  This is a very shallow emulation, which ...

> +work as possible, leveraging Emacs native editing commmands and the work of other
> +packages wherever possible.")

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou