From: Christopher Baines <mail@cbaines.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 41022@debbugs.gnu.org
Subject: [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8.
Date: Sat, 02 May 2020 14:17:28 +0100 [thread overview]
Message-ID: <87lfmamq6v.fsf@cbaines.net> (raw)
In-Reply-To: <87ees24lyr.fsf@devup.no>
[-- Attachment #1: Type: text/plain, Size: 2077 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Christopher Baines <mail@cbaines.net> writes:
>
>> Add a patch based on an upstream commit [1].
>>
>> 1: 10707f437f2fc3632067c6a0efa4432f7ebaf362
>>
>> * gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch: New file.
>> * gnu/local.mk (dist_patch_DATA): Add it.
>> * gnu/packages/gstreamer.scm (python-gst)[source]: Use the patch.
>
> [...]
>
>> diff --git a/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch
>> new file mode 100644
>> index 0000000000..49f41e0c03
>> --- /dev/null
>> +++ b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch
>> @@ -0,0 +1,41 @@
>> +From 10707f437f2fc3632067c6a0efa4432f7ebaf362 Mon Sep 17 00:00:00 2001
>> +From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
>> +Date: Fri, 13 Dec 2019 10:46:20 +0200
>> +Subject: [PATCH] Fix build with Python 3.8 by also checking for
>> + python-3.X-embed.pc
>> +
>> +Since Python 3.8 the normal checks don't include the Python libraries
>> +anymore and linking of the gst-python module would fail.
>> +
>> +See also https://github.com/mesonbuild/meson/issues/5629
>> +
>> +Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28
>> +---
>> + meson.build | 11 +++++++++--
>> + 1 file changed, 9 insertions(+), 2 deletions(-)
>
> Instead of the git patch format, can you add a short comment at the top
> along with links to the upstream commit and issue like we usually do?
I usually avoid messing with patches, they're often uncooperative. Would
something I this do?
Fix build with Python 3.8 by also checking for python-3.X-embed.pc. Since
Python 3.8 the normal checks don't include the Python libraries anymore and
linking of the gst-python module would fail.
See also https://github.com/mesonbuild/meson/issues/5629
Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28
Patch based on upstream commit:
https://gitlab.freedesktop.org/gstreamer/gst-python/-/commit/10707f437f2fc3632067c6a0efa4432f7ebaf362
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2020-05-02 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 11:03 [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8 Christopher Baines
2020-05-02 11:26 ` Marius Bakke
2020-05-02 13:17 ` Christopher Baines [this message]
2020-05-02 13:41 ` Marius Bakke
2020-05-02 14:50 ` bug#41022: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfmamq6v.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=41022@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.