From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yJ+vBi4n4V4IdQAA0tVLHw (envelope-from ) for ; Wed, 10 Jun 2020 18:32:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oPCKAi4n4V61GgAA1q6Kng (envelope-from ) for ; Wed, 10 Jun 2020 18:32:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A22329404CB for ; Wed, 10 Jun 2020 18:32:13 +0000 (UTC) Received: from localhost ([::1]:38796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj5WG-0003rO-Ja for larch@yhetil.org; Wed, 10 Jun 2020 14:32:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj5W6-0003nl-Hc for guix-patches@gnu.org; Wed, 10 Jun 2020 14:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jj5W6-0008TF-6O for guix-patches@gnu.org; Wed, 10 Jun 2020 14:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jj5W6-0008Hn-3O for guix-patches@gnu.org; Wed, 10 Jun 2020 14:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41790] [PATCH] Update emacs-direnv Resent-From: Katherine Cox-Buday Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Jun 2020 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41790 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 41790@debbugs.gnu.org Received: via spool by 41790-submit@debbugs.gnu.org id=B41790.159181388031801 (code B ref 41790); Wed, 10 Jun 2020 18:32:02 +0000 Received: (at 41790) by debbugs.gnu.org; 10 Jun 2020 18:31:20 +0000 Received: from localhost ([127.0.0.1]:35346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj5VQ-0008Gq-AM for submit@debbugs.gnu.org; Wed, 10 Jun 2020 14:31:20 -0400 Received: from mail-il1-f194.google.com ([209.85.166.194]:34745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj5VP-0008Ge-3J for 41790@debbugs.gnu.org; Wed, 10 Jun 2020 14:31:19 -0400 Received: by mail-il1-f194.google.com with SMTP id x18so2972377ilp.1 for <41790@debbugs.gnu.org>; Wed, 10 Jun 2020 11:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/wSwh4PzrSR3tsxAP4Q2cmrzVetqVX7JfWN79H+WLPw=; b=Kvcho6yXH/HDtg4+PIAxwxJURwDKDbYb9HAWpz1Y1K3+ssG5oa9tV4uQUR61cBHJ06 DnjFDo2JmZ3ca8Y7WswqLvI4YMpk0j1Km8dEjPx7X5LgTJ2oXXMXXDBAW+Rx5b9f0fNN crCHsJsovZQHDuU6bBee0AnrfdZaf4rfpxVc/ijiK4N2W1mvzafdOedoTDF+8hN0rNgP HMDT2eER0HmwBWLpY3yAgmTYtRhnLFWgbB6ivxkydNxeoerw0GWBvcx0jf7UCZxFPJ1i R1nLAeMPUz6XAxu+49IWXvxPJDNiCr8AbxCPsmXSyoGfwMuYQu5EBIqXL2UFyWZfh7l0 kobQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/wSwh4PzrSR3tsxAP4Q2cmrzVetqVX7JfWN79H+WLPw=; b=EQWIdj7nzIv50EUp9EgsYx78uJ3YA8MTopiZ2tWliuCffwXoozn26H8KO57TNl/Mnq ObpiQGElTjjijgMWlkBlXXBcn6GKN8WpPRBCRG79vURU3a1VZm7Tl+SF1l5HZ3sES4nZ Dbx8HyqXfXT2HHZW7RP7pxQ3tXVU3tj8KQ2GXFkecLoceqXeA2HOvZg6yqEK1Vjyoh6O O59sg5I60OIs20jEo39HNb6pdDmuwAQUO0NJEjpuVje6rqS/mJV5Um09HttSwedXK7k+ gjCJyjzDSYqf+niOlqdWb3zintf/pIktV3SaCiG4wapuU3iO4iSTg+XfsN86vFguejJx rFOw== X-Gm-Message-State: AOAM531X4FKQNQ6o1jXvn1SiO1A0kqueKSrIDe8KjBS81MlSZWAYY7Sr aghF0yehSkGDyDUiKyho6b52zYIx X-Google-Smtp-Source: ABdhPJxK5Y7ksFfIMu7y2RLKUuX3TFhYtA6xzXujsogzJcr5nEOeT4yrU+pzQ0PK1TJZV5or/JTRpQ== X-Received: by 2002:a92:dacc:: with SMTP id o12mr4545561ilq.83.1591813873135; Wed, 10 Jun 2020 11:31:13 -0700 (PDT) Received: from gazelle-pro (172-221-246-205.res.spectrum.com. [172.221.246.205]) by smtp.gmail.com with ESMTPSA id b29sm329845ioc.32.2020.06.10.11.31.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 11:31:11 -0700 (PDT) From: Katherine Cox-Buday References: <871rmmoq7u.fsf@nicolasgoaziou.fr> <87pna6zy3l.fsf@gmail.com> <87zh9alrtz.fsf@nicolasgoaziou.fr> Date: Wed, 10 Jun 2020 13:31:10 -0500 In-Reply-To: <87zh9alrtz.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Wed, 10 Jun 2020 20:05:12 +0200") Message-ID: <87lfkuzsb5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=Kvcho6yX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: 3Dxf8uN/O4s9 Nicolas Goaziou writes: > Katherine Cox-Buday writes: > >> I disagree. If propagated inputs are not for this -- making the package >> even functional -- what are they for? > > IIUC, they are to be used as a last resort, e.g., when the package > cannot possibly build without them. I checked the Guix manual for the intended use of propagated inputs since I didn't completely understand how what is in the runtime environment would affect the build environment. I found something which maybe is open to interpretation: "To ensure that libraries written in those languages can find library code they depend on at run time, run-time dependencies must be listed in propagated-inputs rather than inputs." Maybe a binary required to operate is no different than "library code they depend on at run time"? > Reason is propagated inputs pollute user's profile. E.g., someone may > want to use a different direnv, and this propagated input would > conflict with their package. That's another good point I hadn't considered: what if for some reason a user wants a different version of the tool (presumably provided by Guix as well)? > I'll let maintainers decide about this, and hopefully clarify what can > and cannot be propagated, at least in Emacs packages. This will be > useful feedback for future reviews. That's a good idea. I have an opinion, but it is not fully informed. I appreciate the review, conversation, and appeal to authority! > Meanwhile, you can still provide a patch only bumping emacs-direnv. It > is also fine in you prefer to wait. I'll let this one sit. The version bump was a side-effect of me believing the package should also install the tool. -- Katherine