From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OA1qMv5USV94UQAA0tVLHw (envelope-from ) for ; Fri, 28 Aug 2020 19:03:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id COJLLv5USV/yTgAAB5/wlQ (envelope-from ) for ; Fri, 28 Aug 2020 19:03:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2C10D940AD5 for ; Fri, 28 Aug 2020 19:03:26 +0000 (UTC) Received: from localhost ([::1]:33004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBjem-0006vv-RU for larch@yhetil.org; Fri, 28 Aug 2020 15:03:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBjaB-0000E7-9s for guix-devel@gnu.org; Fri, 28 Aug 2020 14:58:39 -0400 Received: from world.peace.net ([64.112.178.59]:50088) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBja9-0000j3-02; Fri, 28 Aug 2020 14:58:38 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBjZv-0006Vk-Vh; Fri, 28 Aug 2020 14:58:24 -0400 From: Mark H Weaver To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH v4] gnu: emacs: Update to 27.1. In-Reply-To: <87sgc6onvi.fsf@gnu.org> References: <20200819040941.32696-1-jackhill@jackhill.us> <87sgc6onvi.fsf@gnu.org> Date: Fri, 28 Aug 2020 14:57:16 -0400 Message-ID: <87lfhybntk.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/28 14:58:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, cjpeople2013@gmail.com, Morgan.J.Smith@outlook.com, 42738@debbugs.gnu.org, dnbarbato@posteo.de Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: IVbaSR1mt318 Hello Guix, Ludovic Court=C3=A8s wrote: > Morgan.J.Smith@outlook.com skribis: > >> From: Morgan Smith >> >> * gnu/packages/emacs.scm (emacs): Update to 27.1. >> [arguments]: Add --with-cairo and --with-modules to #:configure-flags. A= dd >> restore-emacs-pdump phase. >> [inputs]: Add cairo, libxaw, jansson, gmp, and harfbuzz. Remove imagemag= ick >> and libxft. >> [native-inputs]: Add texlive. >> (emacs-wide-int): Mark as deprecated package. >> (emacs-no-x): >> [arguments]: Add --with-jpeg=3Dno --with-gif=3Dno --with-tiff=3Dno >> to #:configure-flags. > > I see that Mark committed a similar patch just yesterday: > > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D36a09d185343375= a5cba370431870f9c4435d623 > > I suppose Mark hadn=E2=80=99t seen the ongoing discussion. Indeed, I hadn't. Gah, I'm terribly sorry about this. I had done some quick web searches for preexisting work on this, but clearly they were insufficient, and I've never subscribed to the patches list. In the future, I'll know not to rely on web search engines for this. > Mark, Morgan: could you see if there=E2=80=99s anything we=E2=80=99re mis= sing from the > patch Morgan submitted? Looking now, here are the main differences I see between our patches: * I found that I had to remove the 'restore-emacs-pdump' phase from most of the other emacs variants, namely the ones that use 'gnu-build-system', because otherwise the inherited 'restore-emacs-pdump' phase would fail. Morgan's patch seems not to consider most of the other emacs variants, and I'm not sure if they were tested. I briefly tested all of them except for 'guile-emacs'. * Morgan removed the snippet code that deletes "eshell/esh-groups.el", whereas I replaced it with a call to 'find-files' to remove it only if present, as the previous comment suggested. I'm not sure if this is still needed, though. * Morgan's patch adds "libxaw" to inputs and "texinfo" to native-inputs. What's the rationale for these? * I added 'pango' to the inputs, because the Emacs NEWS mentioned that Pango was used for font rendering when "--with-cairo" is used. However, it may be that "pango" finds its way into the build inputs without being explicitly mentioned. * Morgan removed 'libxft' from the inputs of 'emacs', whereas I didn't. This was an oversight on my part. However, if we remove it, it's possible that we might need to add it back to 'emacs-no-x-toolkit'. The references that I see to Pango in the Emacs code are within "#ifdef HAVE_GTK3". * In 'emacs-no-x', my patch removes the new graphical library inputs (cairo, pango, and harfbuzz) and the "--with-cairo" flag, whereas Morgan's patch leaves "cairo" and "harfbuzz" as inputs, and overwrites the inherited configure-flags to be precisely ("--with-jpeg=3Dno" "--with-gif=3Dno" "--with-tiff=3Dno"), apparently discarding the inherited "--with-modules" and "--disable-build-details" flags. * Morgan made 'emacs-wide-int' into a deprecated package, whereas I thought that it might still be useful. My rationale was this: from a brief skim, it looks like '--with-wide-int' might make *immediate* integers wider, which for some applications might perform much better than the heap-allocated arbitrary-size integers supported by Emacs 27. However, I didn't look carefully at this. * I updated "emacs-exec-path.patch" and removed "emacs27-exec-path.patch", whereas Morgan's patch keeps both files and possibly leaves "emacs-exec-path.patch" orphaned. * I updated the patches to apply cleanly to Emacs 27, although this was not strictly needed. * I updated 'notmuch' in the previous commit to a version that builds successfully with Emacs 27. Pierre Neidhardt wrote: > I confirm that with Mark's commit > emacs-clojure-mode and emacs-elisp-refs are also broken. Sorry about that. If the Emacs 27 update breaks important packages, it might be that reverting it is the proper action. If the maintainers decide to do this, I would not object. Best regards, Mark