From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0Y9YNFanu1+/FQAA0tVLHw (envelope-from ) for ; Mon, 23 Nov 2020 12:13:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KOqkL1anu1/mVwAAbx9fmQ (envelope-from ) for ; Mon, 23 Nov 2020 12:13:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 591B0940363 for ; Mon, 23 Nov 2020 12:13:10 +0000 (UTC) Received: from localhost ([::1]:38298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khAiT-00047B-6B for larch@yhetil.org; Mon, 23 Nov 2020 07:13:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khAiM-00046z-RG for guix-patches@gnu.org; Mon, 23 Nov 2020 07:13:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khAiM-0005T2-KW for guix-patches@gnu.org; Mon, 23 Nov 2020 07:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1khAiM-0002uV-E9 for guix-patches@gnu.org; Mon, 23 Nov 2020 07:13:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44721] [PATCH] gnu: Add terraform. Resent-From: EuAndreh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Nov 2020 12:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44721 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: , 44721@debbugs.gnu.org Received: via spool by 44721-submit@debbugs.gnu.org id=B44721.160613357011169 (code B ref 44721); Mon, 23 Nov 2020 12:13:02 +0000 Received: (at 44721) by debbugs.gnu.org; 23 Nov 2020 12:12:50 +0000 Received: from localhost ([127.0.0.1]:49322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khAi9-0002u5-Vl for submit@debbugs.gnu.org; Mon, 23 Nov 2020 07:12:50 -0500 Received: from box.euandre.org ([46.101.160.115]:50253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khAi8-0002tl-8a for 44721@debbugs.gnu.org; Mon, 23 Nov 2020 07:12:49 -0500 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 51E49FC3D2; Mon, 23 Nov 2020 09:12:40 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1606133561; bh=m4GR3pysGvH9cl4B4jNsK0ecbZ3LUohm7k53OgYdvbE=; h=From:To:Cc:Cc:Subject:In-Reply-To:References:Date:From; b=V1NHU3DuCGQIAQa03SDQpty93V+Hh4D3zG0g9wXVPwvHV0DPLMmxf0vRvjfXgdf+Y MTGvGNG4P3fnstxBn7b3MYSDWqrwSv4zO3U4rlC6F0rw7qFfolPXJ7T7PBcHD/yWM+ g5CxL0csOU8wZDHsVfXHuHccMpSuYjmeS27G1FRLoONwg3Ni6ljnLHyA4t01+hOAwM 7ImdywADBLMd/6vWhH/6VbQ7sxNvOWk+IRBaYV4/KTiHDyXfeb6UEFxVBZMUQT8C8y pPNxH2k8xmMXSuq0hGy2UC/u0akqmj/brdsyg3I3Hy5g1VANCO6nkBVP4oFbLJiSWg nQJHY7rKAbLjw== In-Reply-To: <87o8jojn52.fsf@euandre.org> References: <20201118133110.2380-1-eu@euandre.org> <874klkl6xd.fsf@cbaines.net> <87tuthjb42.fsf@euandre.org> <87r1okkivs.fsf@euandre.org> <87o8jojn52.fsf@euandre.org> Date: Mon, 23 Nov 2020 09:12:34 -0300 Message-ID: <87lfesjmq5.fsf@euandre.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: EuAndreh , EuAndreh via Guix-patches From: EuAndreh via Guix-patches via X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=euandre.org header.s=mail header.b=V1NHU3Du; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: Gl/ze+6+WNgy EuAndreh writes: > Now I get it: the Terraform repo used to vendor all of its dependencies, > and has just stopped doing it recently [0]. > > But the release tarball still contains all of the vendored dependencies. > I'm still not sure if that is deliberate, or just left over from the > previous model of vendoring everything from the source code repository > itself. > > I'll check if the vendoring on the release tarball is deliberate now, > and start packaging the dependencies as Christopher sugested. > > [0]: https://github.com/hashicorp/terraform/pull/26358 The commit [0] that removed the vendoring was done in September 24th, and the release of v0.13.5 [1] was done in October 21st. However the release of v0.13.5 was a backport, and didn't include the commit that removed the vendoring. Only v0.14.0-rc1 (the current latest release) onwards that has removed the vendoring. So the "go-build-system" just worked because all of the dependencies were already there. Switching to v0.14.0-rc1 should probably break the build, and require the dependencies to be packaged individually. [0]: https://github.com/hashicorp/terraform/commit/a7c5a72c3d079fd65b29dd99c1cd0210a4dd1d57 [1]: https://github.com/hashicorp/terraform/releases/tag/v0.13.5