[bug#47968] [PATCH 0/2] Add git-filter-repo

["Ludovic Courtès" <ludo@gnu.org>]

Hi François,

François J <francois-oss@avalenn.eu> skribis:

> I use release tarball (instead of git as I would have liked) because it
> contains pre-compiled man-pages which are too hard to build in this
> context as it uses git Makefile to do it.
>
> * gnu/packages/version-control.scm (git-filter-repo): New variable.
>
> Signed-off-by: François J <francois-oss@avalenn.eu>

Could you add a copyright line for you at the top?

> +        (base32
> +         "00nn7k9jqrybb762486fmigsnbcn9lbvimgpfvvarz4ikdp9y9pb"))
> +       ))

‘guix lint’ complains about these dangling parens.  :-)

> +    (arguments
> +     `(#:install-plan
> +       '(
> +         ("git-filter-repo" "libexec/git-core/")

Please move this to the previous line.

> +         ("Documentation/man1/" "share/man/man1")
> +         ("/" "" #:include ())
> +         )))

Likewise: lonely parens.  :-)

> +    (synopsis
> +     "Quickly rewrite git repository history")
> +    (description
> +     "Quickly rewrite git repository history")

Please capitalize “Git” and expound the description, using full
sentences, as per:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

Could you send an updated patch?

(The patch 1/2 LGTM.)

Thanks,
Ludo’.