From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0GFPGsqvp2CwMAAAgWs5BA (envelope-from ) for ; Fri, 21 May 2021 15:04:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gFsJFsqvp2BQdwAA1q6Kng (envelope-from ) for ; Fri, 21 May 2021 13:04:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1493713AF4 for ; Fri, 21 May 2021 15:04:10 +0200 (CEST) Received: from localhost ([::1]:39462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lk4oz-00011g-1v for larch@yhetil.org; Fri, 21 May 2021 09:04:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk4l1-0003eV-Q0 for guix-patches@gnu.org; Fri, 21 May 2021 09:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52723) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lk4l1-0000W0-GH for guix-patches@gnu.org; Fri, 21 May 2021 09:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lk4l1-0000zE-Cw for guix-patches@gnu.org; Fri, 21 May 2021 09:00:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47979] [PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 May 2021 13:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47979 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47979@debbugs.gnu.org Received: via spool by 47979-submit@debbugs.gnu.org id=B47979.16216019433660 (code B ref 47979); Fri, 21 May 2021 13:00:03 +0000 Received: (at 47979) by debbugs.gnu.org; 21 May 2021 12:59:03 +0000 Received: from localhost ([127.0.0.1]:36028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk4k2-0000wx-Pr for submit@debbugs.gnu.org; Fri, 21 May 2021 08:59:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lk4jx-0000wQ-Po for 47979@debbugs.gnu.org; Fri, 21 May 2021 08:59:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40394) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lk4js-0000Hf-6d; Fri, 21 May 2021 08:58:52 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=49936 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk4jp-00080W-E1; Fri, 21 May 2021 08:58:52 -0400 From: Mathieu Othacehe References: Date: Fri, 21 May 2021 14:58:48 +0200 In-Reply-To: (Leo Famulari's message of "Fri, 23 Apr 2021 20:56:43 -0400") Message-ID: <87lf88qm47.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621602250; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=qUc+i7Eov6LHVdM21kdCrZNG5laSSXYtURK5xv+AhCc=; b=l3OsS5wBriDOl2MxZzS6dBMe+ZGJPSNuIbrR2FTwG3GONK7+lNgCh7GftT0SSTbO2pbKaz BB15H8oCbO/ncN6XvwwcxIDxhMeIOhWkAEDd+Qc226otgCzlob525hk62SKqdMDyCSknyg yLDko9mYm/mpOBOKwhksSCOaT7yaT/DS0RnZj1jM/SH+sHYaZVLlYrF8R++Nr9mhHlHxNv OMD2zCSAF0+Y+5Be8A0iIjKoQ0beHvxwJ4R/ZIUQh7MZ2jD+LJLZ016IUldmcozwoKGXb0 IAc1DgVHw2wDO41aBUUjIjChPg3f6x/E4vM6KXlRFTKiSlCt7ZRz5WhwMbp34w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621602250; a=rsa-sha256; cv=none; b=DQ/hnjTSy/IYInriEyFA00y38GUg3jWTH3j/iJs+m8VNmKWY+QJigvlgYl9Jrv0Sm+tsfQ yvyBFnuJsU1RqIK2vmaEYPvU+YTSZp4ERF/pzOmPMGc6JDFnAAfa7mZgBa1aNbs8b9ZGDS X7PtnoU7ABLScx2dqdyLE3Ppb36/TdZCJh4G0mz260zm65HxrzNmSsFp5tsOFvYKcRsaBY ZCjmVFrGJnwIBsU98hDziwD3njuvAzwWgJZ14/hPCU0ZqR9AGZuJSra+DJtX0v3RRRHBJO 9rVuainm1C+echE62KhwVvn9EeANIHUGQ2J62n/pMIgmm1ZcBC9wMlAPZQOT3g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.94 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1493713AF4 X-Spam-Score: -2.94 X-Migadu-Scanner: scn1.migadu.com X-TUID: 6t2ry5xBFd3q Hey Leo, > +(define (run-system-administration-cbt-page) > + "Run a page to select various system adminstration services." > + (let ((items (filter (lambda (service) > + (eq? 'administration > + (system-service-type service))) > + %system-services))) > + (run-checkbox-tree-page > + #:title (G_ "Miscellaneous services") > + #:info-text (G_ "Select miscellaneous services to run on your system.") > + #:items items > + #:selection (map system-service-recommended? items) > + #:item->text (compose G_ system-service-name) > + #:checkbox-tree-height 5 > + #:exit-button-callback-procedure > + (lambda () > + (raise > + (condition > + (&installer-step-abort))))))) Indentation is off here, > + ;; Miscellaneous system administration services. > + (system-service > + (name (G_ "Network time service, to set the clock automatically")) > + (type 'administration) > + (recommended? #t) > + (snippet '((service ntp-service-type)))) > + here, > + (system-service > + (name (G_ "GPM mouse daemon, to use the mouse in the console")) > + (type 'administration) > + (snippet '((service gpm-service-type)))) and here. Those patches are breaking the installer tests because they introduce a new dialog. You need to add something like: --8<---------------cut here---------------start------------->8--- ((checkbox-list (title "Miscellaneous services") (text _) (items ,services)) (filter choose-misc-service? services)) --8<---------------cut here---------------end--------------->8--- in the (gnu installer tests) module, to fix this error: --8<---------------cut here---------------start------------->8--- conversation expecting pattern ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...))) /gnu/store/h38i2hvaqy9bd0sbn9isdfzl7m56mngr-shepherd-marionette.scm:1:1718: ERROR: 1. &pattern-not-matched: pattern: ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...))) sexp: (checkbox-list (title "Miscellaneous services") (text "Select miscellaneous services to run on your system.") (items ("Network time service, to set the clock automatically" "GPM mouse daemon, to use the mouse in the console"))) May 21 14:53:11 localhost instaBacktrace: ller[180]: running form # ("Miscellaneous services") with 1 clients 2 (primitive-load "/gnu/store/9vzfy688gawwn2p06nn75kiqqz3?") In ice-9/eval.scm: 191:35 1 (_ #f) 619:8 0 (_ #(# #)) --8<---------------cut here---------------end--------------->8--- Otherwise, it looks fine :) Thanks, Mathieu