From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yMhiKoRA92AYlAAAgWs5BA (envelope-from ) for ; Tue, 20 Jul 2021 23:30:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iD0PJoRA92DIbwAA1q6Kng (envelope-from ) for ; Tue, 20 Jul 2021 21:30:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B7BFE12712 for ; Tue, 20 Jul 2021 23:30:43 +0200 (CEST) Received: from localhost ([::1]:46744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5xK6-0004dj-Ip for larch@yhetil.org; Tue, 20 Jul 2021 17:30:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5xJT-0004dU-P6 for guix-patches@gnu.org; Tue, 20 Jul 2021 17:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5xJS-0003ag-Ns for guix-patches@gnu.org; Tue, 20 Jul 2021 17:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5xJS-0003UJ-Lw for guix-patches@gnu.org; Tue, 20 Jul 2021 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49531] Removing input labels for Rust #:cargo-inputs & co.? Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Jul 2021 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49531 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 49531@debbugs.gnu.org, Efraim Flashner Received: via spool by 49531-submit@debbugs.gnu.org id=B49531.162681656213338 (code B ref 49531); Tue, 20 Jul 2021 21:30:02 +0000 Received: (at 49531) by debbugs.gnu.org; 20 Jul 2021 21:29:22 +0000 Received: from localhost ([127.0.0.1]:35555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5xIo-0003T4-J3 for submit@debbugs.gnu.org; Tue, 20 Jul 2021 17:29:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5xIn-0003Sr-JT for 49531@debbugs.gnu.org; Tue, 20 Jul 2021 17:29:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59220) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5xIh-0002zq-7R; Tue, 20 Jul 2021 17:29:15 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45244 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5xIh-0007KS-06; Tue, 20 Jul 2021 17:29:15 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <598b53d80d66a229502d235507047a7717a15e8d.1626067919.git.iskarian@mgsn.dev> Date: Tue, 20 Jul 2021 23:29:13 +0200 In-Reply-To: <598b53d80d66a229502d235507047a7717a15e8d.1626067919.git.iskarian@mgsn.dev> (Sarah Morgensen's message of "Sun, 11 Jul 2021 22:48:09 -0700") Message-ID: <87lf60isie.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626816643; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=Ns50/ygXVk1piutx7j/EYJmKzebyCwSBTikaucfn7+A=; b=Vn8fHRPQmq+BAKBfzz6GOU1A6LgmmfCK5aSlumrNtyKf5mTCaQk+XNKdbQjhPCf8A8TVcS aBtUxI+reQofh8oQQSsbGTLB/ZD4Zud2PFjOi31Jk31cBXN9GtOH7NYvcy0riQGYsGGjr+ Nz+a55pdAC9f0CWLA3T0At4h962FfVlF+MZzEkyhPU9WBIlM6dY28o6ErnSJETuSRC/Y+B H+j+BKaeoKgDCvGq4M9kIBbJ8DDdDdRhDGkX8hQWkCw2hvThyZ+PAsWWDgzfUqO/11hkc6 OEHanImg8A/kDqKt5N+mVdbPG+ZjfzdE2ojIrcoQFF4XO5Lsbo1Y4Qe7Tt6voQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626816643; a=rsa-sha256; cv=none; b=SydziIcgyQsCl63nz62/BCe7pzo8IDB+z+B+fV5C2vvjPUCJmADP+X9XD3ti+i22dBtCA6 JAf7/qepXubi/uFexTrTpAw4tGZMQVjdRMVyoDe7aJZHQxC9PYH/W/DpPvu1f26/WyhLQJ 9VFuMTK9foR3i2ZCZTvOi8ZtP4WkDZipYr1ztbRGne2ummPPPuiGQUNfO8iWTajqzPHmAP S0NzcpY0euINZl0YP2XV0ZUZxOaACGfbFDUVhWLVCdxFa9OmVg8dC0DAxau7oQsA9YX8qr WsRFIBvXJO7I9W4HtSXub23HZd0a9SmvxleZ0i7g1WzVkS9dNjET+MF/4HL6vw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B7BFE12712 X-Spam-Score: -1.92 X-Migadu-Scanner: scn1.migadu.com X-TUID: lh8PyCQuYAkL Sarah Morgensen skribis: > Sanitize cargo's inputs here since the package field sanitizers don't > know about them. > > * guix/packages.scm (sanitize-inputs): Export procedure. > * guix/build-system/cargo.scm (package-cargo-inputs) > (package-cargo-development-inputs) > (lower): Sanitize inputs before using them. So, do we want to do that? :-) I=E2=80=99d say yes, but what do Rust folks think? (Efraim?) Are labels of #:cargo-inputs & co. used at all? If not, we can probably go one step further and have sanitation remove input labels instead of adding them. And then, how do we handle the transition? I=E2=80=99m not enthusiastic ab= out customizing =E2=80=98guix style=E2=80=99 for Rust packages; should we embar= k on manual changes of the 2.4K Rust packages? > +++ b/guix/packages.scm > @@ -7,6 +7,7 @@ > ;;; Copyright =C2=A9 2019 Marius Bakke > ;;; Copyright =C2=A9 2020, 2021 Maxim Cournoyer > ;;; Copyright =C2=A9 2021 Chris Marusich > +;;; Copyright =C2=A9 2021 Sarah Morgensen > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -117,6 +118,7 @@ > prepend ;syntactic keyword > replace ;syntactic keyword > modify-inputs > + sanitize-inputs I=E2=80=99d rather not export it to make sure users don=E2=80=99t mistakenl= y view it as part of the public interface; it=E2=80=99s really just an internal helper. Thanks, Ludo=E2=80=99.