all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: Stephen Paul Weber <singpolyma@singpolyma.net>, 50595@debbugs.gnu.org
Subject: bug#50595: Faliure in guix import go
Date: Sat, 18 Sep 2021 23:12:41 +0200	[thread overview]
Message-ID: <87lf3tsi46.fsf_-_@gnu.org> (raw)
In-Reply-To: <86sfy2hoep.fsf@mgsn.dev> (Sarah Morgensen's message of "Fri, 17 Sep 2021 14:39:58 -0700")

Hi,

Sarah Morgensen <iskarian@mgsn.dev> skribis:

>>From b9ef64a641c20d331cf1886d71b85b81be910b30 Mon Sep 17 00:00:00 2001
> Message-Id: <b9ef64a641c20d331cf1886d71b85b81be910b30.1631914185.git.iskarian@mgsn.dev>
> From: Sarah Morgensen <iskarian@mgsn.dev>
> Date: Thu, 16 Sep 2021 18:24:40 -0700
> Subject: [PATCH] import: go: Improve handling of modules in VCS
>  subdirectories.
>
> Use the supplied module path (instead of the repository root) as the import
> path for everything except source and homepage URLs.  For modules not in the
> root of a VCS repository, set #:unpack-path to the repository root by default.
>
> * guix/import/go.scm (go-module->guix-package): Use 'module-path'
> instead of 'root-module-path' for #:import-path.  Emit #:unpack-path
> when #:import-path is not equal to 'root-module-path'.

[...]

>>From ca17299a3011171d6889202003d1e888b22303ec Mon Sep 17 00:00:00 2001
> Message-Id: <ca17299a3011171d6889202003d1e888b22303ec.1631842353.git.iskarian@mgsn.dev>
> From: Sarah Morgensen <iskarian@mgsn.dev>
> Date: Thu, 16 Sep 2021 18:27:09 -0700
> Subject: [PATCH] import: go: Match "go-import" meta tags anywhere.
>
> Some personal sites forget to put <meta name="go-import" ...> in a
> <head> element, so look anywhere for them.
>
> * guix/import/go.scm (fetch-module-meta-data): Match "go-import" meta
> tags anywhere in the page.

I went ahead and pushed these two patches on your behalf (after adding a
reference to this bug):

  281ede2e7d * import: go: Match "go-import" meta tags anywhere.
  b3907e304d * import: go: Improve handling of modules in VCS subdirectories.

Should we close this bug now, Sarah?

Thanks!

Ludo’.




  reply	other threads:[~2021-09-18 21:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  0:32 bug#50595: Faliure in guix import go Stephen Paul Weber
2021-09-15  2:27 ` bug#50595: Failure " Stephen Paul Weber
2021-09-17 21:39   ` Sarah Morgensen
2021-09-18 21:12     ` Ludovic Courtès [this message]
2021-09-18 21:37       ` bug#50595: Faliure " Sarah Morgensen
2021-09-17  3:07 ` Sarah Morgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf3tsi46.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=50595@debbugs.gnu.org \
    --cc=iskarian@mgsn.dev \
    --cc=singpolyma@singpolyma.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.