From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eMUsBHi2o2GjlAAAgWs5BA (envelope-from ) for ; Sun, 28 Nov 2021 18:03:52 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yKBWO3e2o2G6JgAAB5/wlQ (envelope-from ) for ; Sun, 28 Nov 2021 17:03:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C59092F9A6 for ; Sun, 28 Nov 2021 18:03:51 +0100 (CET) Received: from localhost ([::1]:50790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrNag-0001Cg-Rs for larch@yhetil.org; Sun, 28 Nov 2021 12:03:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrNZy-0000Vc-MZ for guix-patches@gnu.org; Sun, 28 Nov 2021 12:03:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:52971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrNZu-0002oN-Mh for guix-patches@gnu.org; Sun, 28 Nov 2021 12:03:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrNZu-0004Xo-He for guix-patches@gnu.org; Sun, 28 Nov 2021 12:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51985] lint: Adjust patch file length check. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Nov 2021 17:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51985 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Vagrant Cascadian Cc: 51985@debbugs.gnu.org, philip@philipmcgrath.com Received: via spool by 51985-submit@debbugs.gnu.org id=B51985.163811894117413 (code B ref 51985); Sun, 28 Nov 2021 17:03:02 +0000 Received: (at 51985) by debbugs.gnu.org; 28 Nov 2021 17:02:21 +0000 Received: from localhost ([127.0.0.1]:36284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrNZF-0004Wn-2q for submit@debbugs.gnu.org; Sun, 28 Nov 2021 12:02:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrNZD-0004WY-N7 for 51985@debbugs.gnu.org; Sun, 28 Nov 2021 12:02:19 -0500 Received: from [2001:470:142:3::e] (port=38420 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrNZ7-0002fY-VV; Sun, 28 Nov 2021 12:02:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=7FSJm1UK42QlW/KJXtiQB/7HFe967+QNFNFIAfG7alo=; b=Rv1cZD4Z00Clg+8bqFc7 vxcaqV+BhutKRDPW6JRopR1XQrCt06Mnsu+e4a1XTOI51VDh6afGV3tVXTFTbQ4aRZExOIWX6e0WR GxMSpFpOKD7p4RuaNq7OCgdNQmcvPiJ2UvajrVWxmuUGST7ZN9xdsQKeIDl2fYK2lgmC7aDX+7yTX xuFf2XKsls2zZIjV+3Z2BxNrme5yfqo5qwvqYbd9nV6Q/Ly4TfLdwar554LO+ccCZ+8m8h0qE/qlb R4wphcQv4ziqA3ATANI6eD6BJq3gjTqMk+70Vxlpk1U7g6VnNffXtUw3IeoGoBAlJwulq6PDPBsRM 08xa8XsmxTlQoQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:63194 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrNZ7-00076w-PM; Sun, 28 Nov 2021 12:02:13 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <875ysnsvnt.fsf@yucca> <877dd0ph9g.fsf@gnu.org> <8735nl5jri.fsf@ponder> <8735nke61x.fsf@gnu.org> <87ee72fwv0.fsf@ponder> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Frimaire an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 28 Nov 2021 18:02:10 +0100 In-Reply-To: <87ee72fwv0.fsf@ponder> (Vagrant Cascadian's message of "Fri, 26 Nov 2021 13:08:51 -0800") Message-ID: <87lf18b4dp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638119031; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7FSJm1UK42QlW/KJXtiQB/7HFe967+QNFNFIAfG7alo=; b=E4v9cxJBieUiqiytRDBGDz/Y3FV+z/ZHAAQSG4hFKaFl7DcIxVUecTze32XcszVuUZBFoR /ZgWivXUrOyE7k+tIVOdidfFrxHUvClhHQLCnFTqu43EXpr1V5Kwusgs6FiDeBt9LfeZq4 umIlxca9ukL+DytRWfCwL+dI11zOj79vA1GD5ShL6Utu4k0N/K22JSZlDxCvxFWw/obtGp FJ94c/11DJdflsAb4o24VQh6fZJ8JOQQ/jNeC4XQ8Rou+RsM8XEZXWG3+CqSlDd26vFX1O oSTVagUt8CN68KiIuz0CpqcQHqTluc5kkb0kBIDyWFHvnNV9OjRWXzHkHnmvSg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638119031; a=rsa-sha256; cv=none; b=NfGWXOW1xYj63RWdoCy1Gvq8XG4j0y+vLjTcwuN78gS6DnRBivM0cPuqI5FDyy6Cy1sN0y PDakICg+HnZGFtYyvBGe6L6ZBtdof2JOHmGGtHE0Yr5vALBJaptT0V+1bGIOh1Iv204GrP jMS3IdPgkNfzdsyZf3tlhNr0XglWUzCJG4ly+YehwUBevIRkmCt/CvtQr50zVaaTDOkeiJ N3KHONyOhD6VZO0LPxztErJI+zD+swPpjwDiQkmGTpserxC9T0XUyXyJM0O/6aQVHMcnbF icBjyf1wfD0FXtOpKWA8v+dsGF400WqdIqWOywcFhC+3xeBGKryv+c8b9pKoCg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Rv1cZD4Z; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.61 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Rv1cZD4Z; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C59092F9A6 X-Spam-Score: -3.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: gMPyuw9sJY+J Hi! Vagrant Cascadian skribis: > On 2021-11-25, Ludovic Court=C3=A8s wrote: [...] >> I think independently of the switch to ustar, it=E2=80=99s a good idea f= or =E2=80=98guix >> lint=E2=80=99 to warn about long patch file names, but to warn a bit less >> frequently than today. >> >> In that spirit, your patch is still relevant and worth applying IMO. > > Sure, although while I'm mucking around... I went ahead and did some > real-world testing of file lengths usable by ustar. > > Using ustar adds a significant buffer, though less than one might think > in the case of guix-VERSION/gnu/packages/patches/*.patch (~151 > characters vs. ~99). > > I'm guessing this is plenty buffer though, most existing patches were > only a theoretical problem... almost to the point that maybe even > removing the check entirely might be fine. Like I wrote, I think it=E2=80=99s good to have this check even if there we= re no hard limits, mostly as a style guideline. > From c0738574a3571977855d655c157ab0ea0f9be6ef Mon Sep 17 00:00:00 2001 > From: Vagrant Cascadian > Date: Fri, 26 Nov 2021 12:13:45 -0800 > Subject: [PATCH] lint: Adjust patch file length check. > > With the switch to "ustar" format in commit > bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea, the maximum file length has > increased. > > * guix/lint.scm (check-patch-file-names): Adjust margin used to check for > patch file lengths. Increase allowable patch file length appropriate to= new > tar format. Extend warning to explain that long files may break 'make d= ist'. > * tests/lint.scm: Update tests accordingly. [...] > + (G_ "~a: file name is too long which may brea= k 'make dist'") I think you need a comma before =E2=80=9Cwhich=E2=80=9D, but other than tha= t LGTM! :-) Thanks, Ludo=E2=80=99.