all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Vagrant Cascadian <vagrant@debian.org>
Cc: 51985@debbugs.gnu.org, philip@philipmcgrath.com
Subject: [bug#51985] lint: Adjust patch file length check.
Date: Sun, 28 Nov 2021 18:02:10 +0100	[thread overview]
Message-ID: <87lf18b4dp.fsf@gnu.org> (raw)
In-Reply-To: <87ee72fwv0.fsf@ponder> (Vagrant Cascadian's message of "Fri, 26 Nov 2021 13:08:51 -0800")

Hi!

Vagrant Cascadian <vagrant@debian.org> skribis:

> On 2021-11-25, Ludovic Courtès wrote:

[...]

>> I think independently of the switch to ustar, it’s a good idea for ‘guix
>> lint’ to warn about long patch file names, but to warn a bit less
>> frequently than today.
>>
>> In that spirit, your patch is still relevant and worth applying IMO.
>
> Sure, although while I'm mucking around... I went ahead and did some
> real-world testing of file lengths usable by ustar.
>
> Using ustar adds a significant buffer, though less than one might think
> in the case of guix-VERSION/gnu/packages/patches/*.patch (~151
> characters vs. ~99).
>
> I'm guessing this is plenty buffer though, most existing patches were
> only a theoretical problem... almost to the point that maybe even
> removing the check entirely might be fine.

Like I wrote, I think it’s good to have this check even if there were no
hard limits, mostly as a style guideline.

> From c0738574a3571977855d655c157ab0ea0f9be6ef Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant@debian.org>
> Date: Fri, 26 Nov 2021 12:13:45 -0800
> Subject: [PATCH] lint: Adjust patch file length check.
>
> With the switch to "ustar" format in commit
> bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea, the maximum file length has
> increased.
>
> * guix/lint.scm (check-patch-file-names): Adjust margin used to check for
>   patch file lengths. Increase allowable patch file length appropriate to new
>   tar format. Extend warning to explain that long files may break 'make dist'.
> * tests/lint.scm: Update tests accordingly.

[...]

> +                           (G_ "~a: file name is too long which may break 'make dist'")

I think you need a comma before “which”, but other than that LGTM!  :-)

Thanks,
Ludo’.




  reply	other threads:[~2021-11-28 17:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 21:05 [bug#51985] lint: Adjust patch file length check Vagrant Cascadian
2021-11-22 11:22 ` Ludovic Courtès
2021-11-24 21:25   ` Vagrant Cascadian
2021-11-25 13:08     ` Ludovic Courtès
2021-11-26 21:08       ` Vagrant Cascadian
2021-11-28 17:02         ` Ludovic Courtès [this message]
2021-12-18  8:26           ` bug#51985: " Vagrant Cascadian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf18b4dp.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=51985@debbugs.gnu.org \
    --cc=philip@philipmcgrath.com \
    --cc=vagrant@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.