From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iApFFPMHvWG8BAEAgWs5BA (envelope-from ) for ; Fri, 17 Dec 2021 22:58:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KDHxD/MHvWFAGQAAbx9fmQ (envelope-from ) for ; Fri, 17 Dec 2021 21:58:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 15B3A12CC4 for ; Fri, 17 Dec 2021 22:58:11 +0100 (CET) Received: from localhost ([::1]:54262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myLEw-0004bt-5c for larch@yhetil.org; Fri, 17 Dec 2021 16:58:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myLEo-0004ZC-Mq for bug-guix@gnu.org; Fri, 17 Dec 2021 16:58:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57467) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myLEo-0006dl-Ee for bug-guix@gnu.org; Fri, 17 Dec 2021 16:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myLEo-0001sD-AK for bug-guix@gnu.org; Fri, 17 Dec 2021 16:58:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#24496: offloading should fall back to local build after n tries Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 17 Dec 2021 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24496 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 24496-submit@debbugs.gnu.org id=B24496.16397782737177 (code B ref 24496); Fri, 17 Dec 2021 21:58:02 +0000 Received: (at 24496) by debbugs.gnu.org; 17 Dec 2021 21:57:53 +0000 Received: from localhost ([127.0.0.1]:40780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myLEf-0001rh-Dl for submit@debbugs.gnu.org; Fri, 17 Dec 2021 16:57:53 -0500 Received: from mail-qt1-f180.google.com ([209.85.160.180]:35817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myLEV-0001rI-5r for 24496@debbugs.gnu.org; Fri, 17 Dec 2021 16:57:52 -0500 Received: by mail-qt1-f180.google.com with SMTP id j17so4111434qtx.2 for <24496@debbugs.gnu.org>; Fri, 17 Dec 2021 13:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=LJiS26n7xCyDa5YM9nlQg43/t1qpTk5omRWW8++c61M=; b=hfVNBDcJnxrjz2qTuz157Ldad7bf+aJUzvMAqK93PKhVAVxXRMgxi7niAXDpzpF72b uIrvcxh/0vY+KYm/9J2dH6dBPKZxPiR4YzK10PTWDEjxqSMsZy8KMoTUgd/mhYbeOw6Y in2NSfMqxtloLoHjiRK5zigirC9LDewIawuX1wy/3x96AcaQo4eQr9P4nywAG+YY+0il 82j+JvTThrDJfzJdV0yZJXcSfyjBESkYTPIHmJTvzFbIx/4hcumJ2Uehfvy1HQoJJLV0 Oy0ln+2LP2ilUFLQIiOfA0CpJXQgv/8aT/ptiCqWpaYt+fI22T2ipZIImB3SWTwZ0DN4 HG9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=LJiS26n7xCyDa5YM9nlQg43/t1qpTk5omRWW8++c61M=; b=mIdHVPSx9G3Htzx1peOlBcbTiAjAJ7VEIwJBgFr9r3ufNYWsHHojEARNgj8DKEaCSk ByJAM/0RmgaaZR2yCC85803BDnHsGL9k9847C0OZQjFFnWcsYyo5azkGrDCnm2OSdacD LSqPNC3Q7asYQZcZssNadMNxm1NAJ3Vy9pLyj13WeKQLknr9l/f5+1cmzVNZHtf61qef QcQGLBJvFkKfPqItNcCXOV1YLFaylQygz2qnI9xh8fAtK0hTTOHkgnILsltwXvn2HMga xVPyiHq0Ja7+KvRFQJDGR3S4jl4S7Wlmw5Bd/TP+VKdVvS+6GdIyOOUU/IlGhiHwzP+H WFOA== X-Gm-Message-State: AOAM533/sQfqc7CsFzUFxkOoKgYnvCV1JY7GxzVC4swDZh+YfBH/qzHz etVHYxWNQfavTv5gRWspLqnLkGRbCJI= X-Google-Smtp-Source: ABdhPJyysJhVA36fWj5MKa6g5h9MRMKcTsFiKrP03ifEvRwyEOgdGHq0j/zWMf4rZPpBFdi/5Ub4Tg== X-Received: by 2002:a05:622a:1c7:: with SMTP id t7mr4218153qtw.441.1639778257349; Fri, 17 Dec 2021 13:57:37 -0800 (PST) Received: from hurd ([207.35.95.41]) by smtp.gmail.com with ESMTPSA id az14sm5658074qkb.97.2021.12.17.13.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Dec 2021 13:57:34 -0800 (PST) From: Maxim Cournoyer References: <8760ppr3q3.fsf@we.make.ritual.n0.is> <87r387nhjg.fsf@gnu.org> <868rwkiuf5.fsf@gmail.com> <878rwjqm91.fsf@gnu.org> Date: Fri, 17 Dec 2021 16:57:33 -0500 In-Reply-To: <878rwjqm91.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 17 Dec 2021 16:33:46 +0100") Message-ID: <87lf0i6gj6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 24496@debbugs.gnu.org, ng0 Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639778291; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LJiS26n7xCyDa5YM9nlQg43/t1qpTk5omRWW8++c61M=; b=jAkDn08ulHNcxMmfTcwEcbUCrzFLibsNxiCdP2CyfFt4KC90kqDuY0uvOjUQe0A6nS1ud/ c15RZfosCDeKNvC+3MOHaZd6Y4CTd3IROyoeCGIa9/JVXvtlriZn8LRfz9pcqI3umGZfQs iXwIafvW42p04SkCAEhapoyG55e6IAuW+YEi67vdK2QPC7dME52cxjoY42TWoa4lD6Ibn0 ulshXTX9vKGraoeNK4ZgdmAS/YJvS5UukXGq6gizHU/hxAWSQH96yQ49O7q60pRsJ5NIjk RPF9im+XofpAE/NRES1Ozy79X9tzqrR8AFJZvnXCmlcGDxguXUFHJSo3lmZe5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639778291; a=rsa-sha256; cv=none; b=K2BLT1hboH1RlGtN7nRD3Y6o7OTy/6288Z52a+IZQIeGgSqDtWvbx9zctVtwhUHEWN6NP0 5/0AAaspuf3FiZrFLJYEjhJ6XeBJHzTOaNfU7VExpag9haZqbgDWg+eNHE/zP4Oj8vNpTz MQTV4N6oVDA1PGMsNYJapWwbtce0XCBiJqDrCAZW58Mi1XcfIVRLeoVCpT6kc7ak3mtesR cz0XRIZw99AS8vY5qWVL+DGxLJXoXc3UjkwbCedFdKIyn8MAVpqhef745hYFPCo+gmlTiR h3qF/190w3D/ZWeT7UQnf3/CG9K8GXkyhFPEm+FRp1KrQ5jY/3CoZLn6BhOVLg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hfVNBDcJ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hfVNBDcJ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 15B3A12CC4 X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: luuHmA0VpU0r Hello Ludovic, Ludovic Court=C3=A8s writes: > Hi! > > zimoun skribis: > >> I am just hitting this old bug#24496 [1]. >> >> On Mon, 26 Sep 2016 at 18:20, ludo@gnu.org (Ludovic Court=C3=A8s) wrote: >>> ng0 skribis: >>> >>>> When I forgot that my build machine is offline and I did not pass >>>> --no-build-hook, the offloading keeps trying forever until I had to >>>> cancel the build, boot the build-machine and started the build again. >> >> [...] >> >>> Like you say, on Hydra-style setup this could be a problem: the >>> front-end machine may have --max-jobs=3D0, meaning that it cannot perfo= rm >>> builds on its own. >>> >>> So I guess we would need a command-line option to select a different >>> behavior. I=E2=80=99m not sure how to do that because =E2=80=98guix of= fload=E2=80=99 is >>> =E2=80=9Chidden=E2=80=9D behind =E2=80=98guix-daemon=E2=80=99, so there= =E2=80=99s no obvious place for such an >>> option. >> >> When the build machine used to offload is offline and the master daemon >> is --max-jobs=3D0, I expect X tries (leading to timeout) and then just >> fails with a hint, where X is defined by user. WDYT? >> >> >>> In the meantime, you could also hack up your machines.scm: it would >>> return a list where unreachable machines have been filtered out. >> >> Maybe, this could be done by =E2=80=9Cguix offload=E2=80=9D. > > Prior to commit efbf5fdd01817ea75de369e3dd2761a85f8f7dd5, this was the > case: an unreachable machine would have =E2=80=98machine-load=E2=80=99 re= turn +inf.0, > and so it would be discarded from the list of candidates. > > However, I think this behavior was unintentionally lost in > efbf5fdd01817ea75de369e3dd2761a85f8f7dd5. Maxim, WDYT? I just reviewed this commit, and don't see anywhere where the behavior would have changed. The discarding happens here: --8<---------------cut here---------------start------------->8--- - (if (and node (< load 2.) (>=3D space %minimum-disk-space)) + (if (and node + (or (not threshold) (< load threshold)) + (>=3D space %minimum-disk-space)) --8<---------------cut here---------------end--------------->8--- previously load could be set to +inf.0. Now it is a float between 0.0 and 1.0, with threshold defaulting to 0.6. As far as I remember, this has always been a problem for me (busy offload machines being forever retried with no fallback to the local machine). Thanks, Maxim