From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KATYCvDy+GHK1gAAgWs5BA (envelope-from ) for ; Tue, 01 Feb 2022 09:44:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gOVMB/Dy+GGIcwEAauVa8A (envelope-from ) for ; Tue, 01 Feb 2022 09:44:32 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC6D52AA14 for ; Tue, 1 Feb 2022 09:44:27 +0100 (CET) Received: from localhost ([::1]:34646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEom3-0007CL-00 for larch@yhetil.org; Tue, 01 Feb 2022 03:44:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEolf-0007B8-Um for guix-patches@gnu.org; Tue, 01 Feb 2022 03:44:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48757) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEole-0006oL-DO for guix-patches@gnu.org; Tue, 01 Feb 2022 03:44:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEole-0004iT-CA for guix-patches@gnu.org; Tue, 01 Feb 2022 03:44:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53466] [PATCH v2] home: Add redshift service. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 01 Feb 2022 08:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53466 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 53466@debbugs.gnu.org Received: via spool by 53466-submit@debbugs.gnu.org id=B53466.164370502918102 (code B ref 53466); Tue, 01 Feb 2022 08:44:02 +0000 Received: (at 53466) by debbugs.gnu.org; 1 Feb 2022 08:43:49 +0000 Received: from localhost ([127.0.0.1]:41660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEolR-0004ht-2s for submit@debbugs.gnu.org; Tue, 01 Feb 2022 03:43:49 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:51110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEolO-0004hf-Sh for 53466@debbugs.gnu.org; Tue, 01 Feb 2022 03:43:47 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id CD56E365; Tue, 1 Feb 2022 09:43:40 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Be9AVOKhUz4m; Tue, 1 Feb 2022 09:43:39 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 465F323C; Tue, 1 Feb 2022 09:43:39 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87sft8tah0.fsf@trop.in> <20220130151139.3857-1-ludo@gnu.org> <87r18nybq5.fsf@trop.in> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 =?UTF-8?Q?Pluvi=C3=B4se?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 01 Feb 2022 09:43:38 +0100 In-Reply-To: <87r18nybq5.fsf@trop.in> (Andrew Tropin's message of "Mon, 31 Jan 2022 21:57:38 +0300") Message-ID: <87leyv6kp1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: CD56E365 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643705067; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=DSgK/4REPllGjyuR/6d3vkqlB3P+d6vctd6t/hruBpM=; b=bHNOlu1mXM4lCe3+CqHldMIrV0q7g90c/5A8CmAC8IJ0sTbAL/wIZtN6hqnZkWjJ72ijGw vgxjaE4Y9ertwD/KIpTQROmRvCNNwVDKb5af1jy5egk0ynxnCAS2RoopUj/eUbVhIH1tEu mREirGiXANtjUf/TKmnn5lQzBT629FdQ4qmRY0J/2q+P1WFzloftIO30fvCBZksh0BOk3y pGoCProl0G4MYHSV3Pw8U5I+yK3kC0vhDO1e3g7zcNqoVobxzo5A4WXGBTaNuYP1NUGyn3 gaYLq3xQ/PV0zJKIfLTCcpTNDw+yoxSjHYun/Tfhz2OrLYQ7Bjo7IuhBGI5Fqg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643705067; a=rsa-sha256; cv=none; b=ODXhmNZPCIpHDhBiCjdOVu5ovhBfsts78iBD6UCPff5GQhm9ZVC8A/I+h18s+71MIPSOs+ 7FA4D/eYdXb1JWENb+T/gKzLtlWR0LQnEv/zJR+I9+f94qF7rFTxmD2m43N5iozXu/bLul chNC2n1+Tw4c1KX/r0iaMQLhEy5UCMB5dGqCW2YUbymAapUdHvWCt9Aj1EsyDYMzcuNwbB YNi2xrf3wfjBFtpfclHvDuIOLoGdYxylofGvO3GoS0yIaAaZD+rUfExBCQiLhAvKZnlK3W zJ9FPKZch2ExBjs1CuvFihHsb/vdiv5NpYyuSrqUi/FVRtAMwFsSJojpkVAS7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CC6D52AA14 X-Spam-Score: -4.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: W9Cl+h9JJV7B Hi, Andrew Tropin skribis: > On 2022-01-30 16:11, Ludovic Court=C3=A8s wrote: > >> * gnu/home/services/desktop.scm: New file. >> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. >> * doc/guix.texi (Desktop Home Services): New node. [...] > Probably, I already mentioned, but combining renamed option names from > the configuration record and option names in the escape hatch is > inconsistent, confusing and error-prone. I think I replied already. > It's very unclear where this extra-content goes and user can't know it > until he check out the implementation or build the config (currently > it's also almost impossible to find it on file system after build). (He or she.) I documented it in a way that I thought was clear: @item @code{extra-content} (default: @code{""}) (type: raw-configuration-= string) Extra content appended as-is to the Redshift configuration file. [=E2=80= =A6] Notice =E2=80=9Cappended=E2=80=9D. How would you phrase it? > Using such type of escape hatch is no joy at all. Escape hatches are meant to be used as a last resort; they=E2=80=99re a hac= k. Normally, people would have everything they need with the provided bindings. So yes, using them is no fun, but that=E2=80=99s not a surprise = IMO. > Seems this one is missplaced and should be go before [manual] section, > otherwise it won't be possible to set values of redshift section. And > doing so will lead to very ugly: > > (extra-content "\ > dawn-time=3D5:30 > dusk-time=3D18:30 > [geoclue2] > some-other-option=3Dvalue > # Do I know that I'm in the middle of config file?") > > It will be especially ugly or even erroneous, when the target config has > a format, which uses identation. > > I didn't try it for redshift, but in many ini parser it's forbidden to > repeat sections with the same name. Ah, bummer. Another way to see it is that I should augment the bindings, maybe that=E2=80=99s what you=E2=80=99re getting at? :-) I can do that. >> + #$(home-redshift-configuration-extra-content config))) > > A little offtopic: > > I know a number of system services, where the extra-content goes in > unexpected locations and overall behavior of escape hatch is unexpected > and incosistent with other escape hatches. Some of the services has a > number of escape hatches in almost every nested record with different > names and behaviors. > > I'm relatively fresh Guix user and this part really confused me at first > even having experience with NixOS module system before and it's very > likely that many people just don't report it, because it really hard to > get the roots of it. How does NixOS handle escape hatches today? Back when I was using it is that it wasn=E2=80=99t any more consistent than what we have today, which i= s at least a consolation. Thanks, Ludo=E2=80=99.