From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gEaZCWfQA2LZcgAAgWs5BA (envelope-from ) for ; Wed, 09 Feb 2022 15:32:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QJJJAmfQA2LqOQAAG6o9tA (envelope-from ) for ; Wed, 09 Feb 2022 15:32:07 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0A5B6142A3 for ; Wed, 9 Feb 2022 15:32:06 +0100 (CET) Received: from localhost ([::1]:42810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHo0o-0000Vm-Ih for larch@yhetil.org; Wed, 09 Feb 2022 09:32:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHndg-0004Lk-Ep for guix-patches@gnu.org; Wed, 09 Feb 2022 09:08:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHnda-0002Dy-7M for guix-patches@gnu.org; Wed, 09 Feb 2022 09:08:08 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHndZ-0008Jh-Nz for guix-patches@gnu.org; Wed, 09 Feb 2022 09:08:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51676] [PATCH v2] gnu: Add python-miniupnpc Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Feb 2022 14:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51676 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Stephen Paul Weber , 51676@debbugs.gnu.org Cc: Stephen Paul Weber Received: via spool by 51676-submit@debbugs.gnu.org id=B51676.164441567831957 (code B ref 51676); Wed, 09 Feb 2022 14:08:01 +0000 Received: (at 51676) by debbugs.gnu.org; 9 Feb 2022 14:07:58 +0000 Received: from localhost ([127.0.0.1]:50272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHndW-0008JN-B1 for submit@debbugs.gnu.org; Wed, 09 Feb 2022 09:07:58 -0500 Received: from h178-251-242-94.cust.a3fiber.se ([178.251.242.94]:45858 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHndU-0008J4-E0 for 51676@debbugs.gnu.org; Wed, 09 Feb 2022 09:07:57 -0500 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yoctocell.xyz; s=mail; t=1644415668; bh=J6pcVbIV7RFJ10CqdvewcZSj8ewa1xJ3Cg0dwUmePd0=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=FluEnTpYJ4DsEG69cpM5vsPzz4zBeHgvq3fVF06XDHN8gmUonTLXuXiB4U0QhrzVi D7OjN0ANu/mU6si2VDWRvugeuAkVRcVtZalNhuGxJky73EFd2fNRwrPo6woHNj0qcg g/1gLnPjlRJ5HBVwQtKssUxv7R/o9jUw7xjDPW+M= In-Reply-To: <20220114010954.28886-1-singpolyma@singpolyma.net> References: <20211108034117.69082-1-singpolyma@singpolyma.net> <20220114010954.28886-1-singpolyma@singpolyma.net> Date: Wed, 09 Feb 2022 15:07:47 +0100 Message-ID: <87leykw2to.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644417126; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=J6pcVbIV7RFJ10CqdvewcZSj8ewa1xJ3Cg0dwUmePd0=; b=TqDHMMoIGMYlhbF6ISYVaFZkd2iHkrV7u8t0RhSlunu1kVL9wswxmifXKTIeZ+pnX1YWrk FRX4TY1nh78LWwzsQeqDPpbYY7C3g7NR5f9B5CZ0FLK8OJdSge5fJZ3j9p3Coxy/WjGovo 9SiKKS1CN7hoKHSgrPHpWRC71IU1IEXpYKmNalJHq8FlV9UBoiA6K7/Duwa/vAJShmcknj p39okFdQ5vbuTOaXQq8sk733ce1fiZgK8HDA7tybHZmJguVkYAfPZ24ebkcQhXyeu/Iyb2 ZpVzty29LVePvJYT6Oo3S80awX1b9nlbsEfo6zCSeJ92irhQR+JjkPOfhcyMuw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644417126; a=rsa-sha256; cv=none; b=W+yfnHCgmhNM/cIFcrlNfs76+tDl+Y5tAY6CVNrfATP1YbGDCxU66lxDF4vxQFNMHCQGE2 aJgKIhPNPkZUyVF/d5EstUtog9EttZoHn2AHvfCCecyxtbh6DFQKNRBtLNETXM8bfxvzwF sLyLuyVHtTZ7WW2/OhdMriO2S7uIOR0mNSMrJp5bVlm9V2Nk6Hc3NjdpGNI5DoCYkm/gvc sHqp0UyUgOkDm9sB3KEmF35Jnj1GhC3lsHLLB5ICVNu7kYhWk4bayg75sRf5vF/axCVmP4 BrPaBkp8OqvAuk77/0tjtbksP1ZeWk+hIq8cVZjiO9QoF6mlM0owZhNWXIvJ5Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=FluEnTpY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.63 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=FluEnTpY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0A5B6142A3 X-Spam-Score: -4.63 X-Migadu-Scanner: scn0.migadu.com X-TUID: O8lohib78vdj --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stephen schrieb am Donnerstag der 13. Januar 2022 um 20:09 -05: > * gnu/packages/python-xyz.scm (python-miniupnpc): New variable. > --- > gnu/packages/python-xyz.scm | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index 0091165d37..0ad5dfd85c 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -3150,6 +3150,40 @@ server.") > "@code{pafy} is a python library to retrieve YouTube content and me= tadata.") > (license license:lgpl3+))) >=20=20 > +(define-public python-miniupnpc > + (package > + (name "python-miniupnpc") > + (version "2.2.3") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/miniupnp/miniupnp") > + (commit "miniupnpc_2_2_3"))) The version should not be hard-coded. You could use =E2=80=98string-replace-substring=E2=80=99 from (ice-9 string-fun). (string-replace-substring version "." "_") > + (file-name > + (git-file-name name version)) > + (sha256 > + (base32 "0h7smsp1fnwsmgg3n70813ln9j5y20g61x25s4kn91vzkbbq9188"))= )) I am getting a hash mismatch =2D-8<---------------cut here---------------start------------->8--- expected hash: 0h7smsp1fnwsmgg3n70813ln9j5y20g61x25s4kn91vzkbbq9188 actual hash: 03q1rlzvfzm15g1bfw2zqzavlsyaypnaf2k3cz6ha7k5rirkdy0l =2D-8<---------------cut here---------------end--------------->8--- > + (build-system python-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'subdir > + (lambda _ > + (chdir "miniupnpc") > + (setenv "CC" ,(cc-for-target)) > + (substitute* "Makefile" > + (("SH =3D /bin/sh") (string-append "SH =3D " (which "bash= ")))) Nitpick: Could we just match on /bin/sh? > + #t))))) Phases don=E2=80=99t have to return #t. > + (inputs (list python)) ; We are building a Python extension. > + (native-inputs (list which)) > + (synopsis "UPnP client for Python") > + (description "Miniupnpc is a client library for Python programs to s= et up > +port forwards using UPnP.") Acronyms should be expanded at least once, see =E2=80=9C17.4.4 Synopses and Descriptions=E2=80=9D in the manual. @acronym{UPnP, Universal Plug and Play} --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmIDyrMVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5KGIP+wXuD49xoeuQF+Xlcasj8HSVj5t1 f44WVoOHof1PddzKgq2eYDCaCXKtWOhhZb4tnjoStk+CLVPh6hmyjJYyt9wFGiVB Bpi19oVMRlH8XX68XgYNnL9Kov5LL33RoRIO8wCJeuY9MTUzZMbAewGaCBTGuyNO wUNCBIjFF7d9ShkNfzFMpoeLaDczTJ8XafNvg5q9HJCnTwn0r6MAYnL87KqCIjet 3uB5ewP4e252jIaUGvUzbgYXsQ5VwtNcWqM7aVVS+BLbTBRWXYeRnXWha95YUhvh RPrDe11wIYRQoUrvaze69TadW7UIre4MLhFYRaY65qjbzPn5VYd98lT80Eo9Po1A u/mPary9Jw2D40UYQeT8dpp6s1IubQjYj1YO4B0orfIKdSGMeAMI596Z7gg+jIuX iSOYgq6zyO7BvGwtcvsYcIXR4Q3Cpuo1BtzeKA4yPnNogXObbSNDWe+NFMU3QExu L+F8vWRv+L6InyA7hc0xpN9E+f4bIC5G0JDLoqe6FD2zkpPJLAscCvFbcZtoMgTM BE67pbJL8qvzcm/T3Bk78nqEA5iVy7o7s/6E1Mz+CqiEVGxFT7ePNtxSceWYmimE +aCnnVbtOXlUKA6LxIbT8PCYhI4AYPBHHCvZIGrPGqZCNW/vR37V6+9F8tGvez70 2DxPxgKt6OT64Rbq =jz/g -----END PGP SIGNATURE----- --=-=-=--