From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mBAjJfuQ02PUMgEAbAwnHQ (envelope-from ) for ; Fri, 27 Jan 2023 09:53:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6IsvJfuQ02NlhAAA9RJhRA (envelope-from ) for ; Fri, 27 Jan 2023 09:53:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6D92D3B43A for ; Fri, 27 Jan 2023 09:53:15 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLKTn-0002oo-UR; Fri, 27 Jan 2023 03:53:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLKTm-0002og-IW for guix-patches@gnu.org; Fri, 27 Jan 2023 03:53:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLKTm-0002RS-8P for guix-patches@gnu.org; Fri, 27 Jan 2023 03:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLKTl-0007Yn-Rj for guix-patches@gnu.org; Fri, 27 Jan 2023 03:53:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 Jan 2023 08:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61082 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: conses Cc: 61082@debbugs.gnu.org Received: via spool by 61082-submit@debbugs.gnu.org id=B61082.167480955629027 (code B ref 61082); Fri, 27 Jan 2023 08:53:01 +0000 Received: (at 61082) by debbugs.gnu.org; 27 Jan 2023 08:52:36 +0000 Received: from localhost ([127.0.0.1]:36718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLKTL-0007Y7-Sg for submit@debbugs.gnu.org; Fri, 27 Jan 2023 03:52:36 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:36681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLKTK-0007Xt-1Z for 61082@debbugs.gnu.org; Fri, 27 Jan 2023 03:52:34 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 4025AFF808; Fri, 27 Jan 2023 08:52:26 +0000 (UTC) From: Nicolas Goaziou References: <86h6wd6ro2.fsf@conses.eu> Date: Fri, 27 Jan 2023 09:52:20 +0100 In-Reply-To: <86h6wd6ro2.fsf@conses.eu> (conses's message of "Thu, 26 Jan 2023 20:07:25 +0100") Message-ID: <87lelol5q3.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674809595; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=E4IW9NPG1nhAQQ9L2f7ACZFAO87eLLJ8Fg/yx7NOp3E=; b=JB88n604JCLGXA9LabIWm7eBS3gGDugmKm81gfSZ5M/uozUCoOlEqqKe2M+1y1ePnscGls 3PlkFBeQYQ8i2ZTQpvh5X5U4Ojl1FxwC+YE6Ehfp6Czincxg44Uhw2AicSRzF4HwAsDt88 oE6gyEkQKTM3T0MtCMfFL32KhmOKQkllGJkYByO2rF14Hlw6m5iUugdNo70Jk52xtI3rGG rZaJaEKQJ9es0XXL8LbJj7WIh4hqhZdXHQoOCnwfrGzsWlyM6Z+KN54dNAPBDAjCeJDQn1 gQg3ghSnRBKg9IA402xv4bpH1ijaFQku0eNXRKFjml5W3HRqV1C/pliL+Iltzg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674809595; a=rsa-sha256; cv=none; b=ElYhT7bMLGIpSGuUIS9X4BbMcaDvuLLKGIqmOo+0pbYqgOoPjltkWb8YdFtOcLbTdykES3 Bl7CArFyRE46XEpvjQ9qM8ptUAYau24FyH86PopCUH9WT6AUXzBekkPxQpaO0xN4cleJ0i zRCOQhFRco29qtiwKExXxDiqIiA9r4/8522kpxoSezyCTfhitkSicIQItNuMtArzYGNXeP Y113W1py9Z64ybb92W0lU6Eu6DwSuTqs1N/Ty4QlaKMP8u9x77FgmBiyqnubXNxomnoacK pEaBuK5h2ro6awlKsr1Es9K79JHup7P1mEJV8jgkU119nq36ijvEHdu0vJO7yQ== X-Spam-Score: -1.67 X-Migadu-Spam-Score: -1.67 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6D92D3B43A X-Migadu-Scanner: scn1.migadu.com X-TUID: hKvzmNxM5HIC Hello, conses writes: > * gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to > 34a61143. Thank you. The commit message is incomplete: you modified pointer to upstream, you need to write it here. > --- > gnu/packages/emacs-xyz.scm | 35 ++++++++++++----------------------- > 1 file changed, 12 insertions(+), 23 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index dc378581f5..7b5888a1d1 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -21447,34 +21447,23 @@ (define-public emacs-md4rd > (license license:gpl3+))) > > (define-public emacs-pulseaudio-control > - (let ((commit "a931533140547510decdc368f39b2d2b97ca725f") > - (revision "4")) > + (let ((commit "34a6114357dbbc6b6720aa013e0f8a48f3739403") > + (revision "5")) > (package > (name "emacs-pulseaudio-control") > (version (git-version "0.0.1" revision commit)) Base version seems to be "0.1", according to puleseaudio-control.el. In this case, you can restart revision to "1" (or "0"). > - (source > - (origin > - (method git-fetch) > - (uri (git-reference > - (url "https://github.com/flexibeast/pulseaudio-control") > - (commit commit))) > - (file-name (git-file-name name version)) > - (sha256 > - (base32 > - "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76")))) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.sr.ht/~flexibeast/pulseaudio-control") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5")))) > (build-system emacs-build-system) > - (arguments > - '(#:phases (modify-phases %standard-phases > - (add-after 'unpack 'patch-file-name > - (lambda* (#:key inputs #:allow-other-keys) > - (let ((pulseaudio (assoc-ref inputs "pulseaudio"))) > - (chmod "pulseaudio-control.el" #o600) > - (emacs-substitute-variables "pulseaudio-control.el" > - ("pulseaudio-control-pactl-path" > - (string-append pulseaudio "/bin/pactl"))) > - #t)))))) Why did you remove this phase? AFAICT, pulseaudio-control-pactl-path still exists. > (inputs (list pulseaudio)) > - (home-page "https://github.com/flexibeast/pulseaudio-control") > + (home-page "https://git.sr.ht/~flexibeast/pulseaudio-control") This also need to be specified in the commit message. Could you send an updated patch? Regards, -- Nicolas Goaziou