On 2023-03-10 21:39, Cayetano Santos wrote: >>ven. 10 mars 2023 at 22:44, Andrew Tropin wrote: > >> [[PGP Signed Part:Undecided]] >> On 2023-03-10 19:24, Cayetano Santos wrote: >> >>>>ven. 10 mars 2023 at 19:14, Simon Tournier wrote: >>> >>>> Hi, >>>> >>>> On Fri, 10 Mar 2023 at 17:59, John Kehayias >>>> wrote: >>>> >>>>> During this discussion some changes were made to this inheritance structure in >>>>> >>>>> >>>>> >>>>> and >>>>> >>>>> >>>> >>>> Thanks for pointing that. From my understanding, it does not change >>>> what Cayetanos is raising: emacs-next-tree-sitter is built using >>>> '--with-pgtk'. In fact, the package emacs-next-tree-sitter is built >>>> using the master branch (Emacs 30 unbranched yet) with tree-sitter >>>> *and* pgtk support. >>>> >>>> Cheers, >>>> simon >>> >>> As for the NEWS-29 file: >>> >>> "Running this configuration on X is known to have problems, such as >>> undesirable frame positioning and various issues with keyboard input of >>> sequences such as 'C-;' and 'C-S-u'." >>> >>> C. >> >> I haven't used X for a while, but if it's still the case for 30 version, >> I guess we can inherit pgtk from tree-sitter. >> >> This will update emacs-next-pgtk from emacs-29 to somewhere near 30 on >> master, but I it should be fine. I use the same commit as >> emacs-next-tree-sitter in my local tree-sitter+pgtk emacs package and >> everything seems to work for me. >> >> WDYT? > > Personally, the closer to master, the better (and the simpler). What you > propose, inheritance of pgtk from tree-sitter, fits me well. Ok, I changed the inheritance order, so now non-wayland users can have tree-sitter without pgtk and wayland pgtk users will have tree-sitter as well :) -- Best regards, Andrew Tropin