From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YKQKI+a1U2SWhQAASxT56A (envelope-from ) for ; Thu, 04 May 2023 15:40:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cFbfIua1U2QhfwAA9RJhRA (envelope-from ) for ; Thu, 04 May 2023 15:40:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 68F40EC06 for ; Thu, 4 May 2023 15:40:54 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puZCM-0002Pc-B2; Thu, 04 May 2023 09:40:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puZAl-0002Bd-CA for bug-guix@gnu.org; Thu, 04 May 2023 09:39:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puZAk-0001IU-K7 for bug-guix@gnu.org; Thu, 04 May 2023 09:39:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puZAk-00042N-G3 for bug-guix@gnu.org; Thu, 04 May 2023 09:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63261: Recent changes to git config cause errors for non-committers Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 04 May 2023 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63261 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Brian Cully Cc: 63261@debbugs.gnu.org Received: via spool by 63261-submit@debbugs.gnu.org id=B63261.168320750515465 (code B ref 63261); Thu, 04 May 2023 13:39:02 +0000 Received: (at 63261) by debbugs.gnu.org; 4 May 2023 13:38:25 +0000 Received: from localhost ([127.0.0.1]:48853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puZA9-00041L-Cj for submit@debbugs.gnu.org; Thu, 04 May 2023 09:38:25 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:46237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puZA8-000419-4u for 63261@debbugs.gnu.org; Thu, 04 May 2023 09:38:24 -0400 Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-3ee339e8c2fso1918161cf.0 for <63261@debbugs.gnu.org>; Thu, 04 May 2023 06:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683207498; x=1685799498; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=2D531nh0GBY2E7HJ1JagdGCjh76PyN+M711IkKQjxfQ=; b=DRcetK1Zy2jgdUlMLOqjPTxF+2uInlJgDmHC/B3lAHpHIRKNexp4JyOwXUvmfVnhxW gjsLGMn9CzfjGRFh7Rm56CCe7J9CraLcd1BjZLrpff4Zbx4YnN9EtQaPHwDii1CeIUWq nou8tKNH77pI47NpmOTCoGZXYjqY3EpyDK8M+ItzNSVEfMyfqKdiXwj0Q9tycTy7PSmS vNFzidx4Hy5PPjz8pVcNLgFTSFJns9SfGwlOghXU6rhR7UwjbQl9BPua0I//cBaL40O7 NAbe9QQZ6P4VlomhKvHuUUvTB0uGb/Sy68cc1LHvm2KiLnuM4WYtAVuJyvDRdIWx/NKe lxmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683207498; x=1685799498; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2D531nh0GBY2E7HJ1JagdGCjh76PyN+M711IkKQjxfQ=; b=hJ8S+i3DmjL/e4IxNZEFBcAt2MD25s3c0ULzfOL9KWMd5kS2LLQomekhxEuKxM2End 4VknSbQR5XiLtmuYTyByRpETJAZ2AyPN3VRyXWvnwBVRXELrouNzkTwRHbfdwlFVln+f uAsLw0cQUGQDUsHBNhnljwMYePNRPlWoiDHYGhTUjQN5a+2G7fI7qT/G2i+oKyditXKO EpUibHRifJpaKSWcB/W4Qe8Pt/Ft6ijQu3oVZ2F29VjAtPnn5DnrwV5v+sVBRuS9gLxp +m4VhzGGZIFz5ntg4aefQYeY/oZkfT5l2Jyn67T4XflVGQDHmg0tAfbvQVSjNDTN2tDC TsQQ== X-Gm-Message-State: AC+VfDx5d60HrprLowo00amqK9PSvUiMM50hum9nQAtecJ2PqQoI7rsw sjmBtZjK/FHo4YyU4JEg79lgklYNfro= X-Google-Smtp-Source: ACHHUZ4uBshpnlfVPf3brUfibQVtGdrds4P62YV2cl9twzB7cV9HhKRZxbfcDX8cay4ZqzHFrx/5jQ== X-Received: by 2002:a05:622a:118c:b0:3e4:df94:34fa with SMTP id m12-20020a05622a118c00b003e4df9434famr5578480qtk.37.1683207498320; Thu, 04 May 2023 06:38:18 -0700 (PDT) Received: from hurd (dsl-151-193.b2b2c.ca. [66.158.151.193]) by smtp.gmail.com with ESMTPSA id z28-20020ac87cbc000000b003e388264753sm12346545qtv.65.2023.05.04.06.38.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 06:38:17 -0700 (PDT) From: Maxim Cournoyer References: <874jospdr2.fsf@psyduck.jhoto.kublai.com> Date: Thu, 04 May 2023 09:38:16 -0400 In-Reply-To: <874jospdr2.fsf@psyduck.jhoto.kublai.com> (Brian Cully's message of "Thu, 04 May 2023 06:47:32 -0400") Message-ID: <87lei45i9j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683207654; a=rsa-sha256; cv=none; b=qEl1YXIw0p/i4F7TsWvsueCtHYcltFhP58jhNJaPllPGtOxxKc0kWCQUjoHBEXsqIoNsTx o8aYpvK8cLrbsTvMvwMoIthT8L054iyJo0ahJ6HQD+0zn/xhPoe8M2CRZBufgV9zj6RoFR 8gu5bap1CDatFo5uFrA0fRufZ3YzWl+dbe7HKRvMpZ0D9wMn4QI56PRE0dS6WzE8NIcwdP 4anGxOE69KOFDI3s9E/V4wJVuPwT2ODEKGDAvWs923LpF54GnzaS92rPFIuT/1OSyHUg4o l8XntQ7sfTvP/DSnKkfQakZfGeV0M4sdPnR8Or6cwrTYP51UjPR05w6paY21Lg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=DRcetK1Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683207654; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2D531nh0GBY2E7HJ1JagdGCjh76PyN+M711IkKQjxfQ=; b=cMAKwx/Hd3DexzH2+kHnISeHphgonfl1L61AB+8grQosxwZS+BtWV4iWDRUCeny7f3xrFU QoQMOy1g5wo4+lG3GIWkJg9cR8gasq+8kz10jiN6dgcW9UP4qMmhzrrQtjxbuVccubXj87 H8wi9LNGkMv476per3JhQXXE9YKYoCZ6CtxQ5tCoQN2722w+BybrYhyoxOgZAQmvERlAhO u0HUjgpEZKp+cPuFOsmWsJfN63qKgh1/aUQMxiRejRUGx/UtL1a6iQilJM8sbLQQoe1TF0 h+wewZCcd0CjNViIxiB+3WAD9JwxC0jftcz4jRp7fWSEG1uCo7JpNrNXJaui/A== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=DRcetK1Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.29 X-Spam-Score: 7.29 X-Migadu-Queue-Id: 68F40EC06 X-TUID: a5+Lbwg8NWhT Hi! Thanks for the feedback. Brian Cully writes: > I've run into two issues with the recent changes to git config > integration: > > 1) All commits must now be signed, even if you're not a > committer. This breaks just tons of things, including rebasing. I'm > not sure how to fix this without just disabling that configuration > line altogether. Could you elaborate on 'tons of things' ? :-) And why does it break rebasing? I rebase my branches often while signing the commits, so I'll need more details to understand the issue. The idea was to distribute the basic configuration that makes collaborating on Guix easier, by auto-configuring things that previously were left to do manually. By having non-committers also follow the committers' flow, it also prepares them to become committers, if they wish :-). > 2) Some =E2=80=98make=E2=80=99 rules now require git to be installed so t= hat =E2=80=98git > config=E2=80=99 can add =E2=80=98etc/git/gitconfig=E2=80=99 to the local = configuration. So, > for instance, =E2=80=98guix shell --pure -D guix -- make=E2=80=99 will no= w fail. Calls > to git should be prefixed with a test to see if there is a git > executable in the path. This one is a clear problem, for example causing issues to build a release tarball of Guix where git shouldn't be a requirement. It should be easy to fix with a test as you suggest. --=20 Thanks, Maxim