From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kGciHfYLVmRCfwEASxT56A (envelope-from ) for ; Sat, 06 May 2023 10:12:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4PlFHPYLVmTVbgAAG6o9tA (envelope-from ) for ; Sat, 06 May 2023 10:12:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4485C3CC1E for ; Sat, 6 May 2023 10:12:38 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvD1Z-0006fp-Ft; Sat, 06 May 2023 04:12:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvD1Q-0006fM-3T for guix-patches@gnu.org; Sat, 06 May 2023 04:12:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvD1P-00075G-2k for guix-patches@gnu.org; Sat, 06 May 2023 04:12:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvD1O-0005Ba-Uj for guix-patches@gnu.org; Sat, 06 May 2023 04:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63263] [PATCH] gexp: Stop generating unreadable builder scripts. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 May 2023 08:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 63263@debbugs.gnu.org Received: via spool by 63263-submit@debbugs.gnu.org id=B63263.168336070419877 (code B ref 63263); Sat, 06 May 2023 08:12:02 +0000 Received: (at 63263) by debbugs.gnu.org; 6 May 2023 08:11:44 +0000 Received: from localhost ([127.0.0.1]:59331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvD15-0005AW-Uv for submit@debbugs.gnu.org; Sat, 06 May 2023 04:11:44 -0400 Received: from mira.cbaines.net ([212.71.252.8]:42496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvD13-0005AK-Pf for 63263@debbugs.gnu.org; Sat, 06 May 2023 04:11:42 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 9B2BE27BBE2; Sat, 6 May 2023 09:11:40 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 0d299b4d; Sat, 6 May 2023 08:11:40 +0000 (UTC) References: <20230504112448.22462-1-mail@cbaines.net> <87zg6kqn50.fsf@gnu.org> <875y98nryn.fsf@cbaines.net> <87y1m33o5e.fsf@jpoiret.xyz> User-agent: mu4e 1.8.13; emacs 28.2 From: Christopher Baines Date: Sat, 06 May 2023 09:05:43 +0100 In-reply-to: <87y1m33o5e.fsf@jpoiret.xyz> Message-ID: <87lei12820.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683360758; a=rsa-sha256; cv=none; b=F1o64FzeUZ7AzjOKReDlOzU54WPZaHzKaK6W8O9rHfjNHVpv9aEUoRVCV474/KHw3EbCpB YeIHWSpbTZiqYGpn6Z2c/UZqQHNbA4Jjz8K7iMKshutWPAgIfcwPpTV2piQLwawr+HdO3Y n/auJWVRSYYrAtHd0cZcc+H8m6ExUYkleahK4OHcxPRE1LCteUszY3g45iFb2Uq6/FKev7 oT2LCj130VZqkh47y09fvipt0ikMwA+Cs5DxrNM7zmbS9jXDTgS9mB3Bb92b8QqiIiAUCq lI8doTi7rDQI7eaUK0JgtrSoSWlQ0JMhar8Y+7CHtj2PmLEO5XRdzCTEufaVtg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683360758; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=KTB8Uzv6zeLweSTYXB3a0wBQFBPhA60GdoTtTXhxIrg=; b=KSkZkJjmGivGBw9464Khvf3A76E10EzdFwtQsVIYR8/6Q6Ix5IBDWveqT7a10HNNYGvoMt Xkd2ljFVIa8UB49iJjBGohU9gI2pA0DzDRxWfrHxKI0Gv36AaCOREQtETjT8u7ZyPJ0NYp Itm3wRBTrQttUlyG7hqRScjzKX+Rqea8QfTv8aWGQFw3tswQaz1vUPSfaH1bqiDozj+6aD 6f+tjkM2Ibfe1uY+qAM1rot1aM7XORHVJJO238qZBCuaZdWNnWCRCjop1MgMmw3j1LKkFu d7eDLRiPv9aX/lKPXr4cigLrIYf7gmRMxYAfzW2bJ8gfEOkMRADcLWS9T60iqA== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.30 X-Spam-Score: -5.30 X-Migadu-Queue-Id: 4485C3CC1E X-TUID: xni9SMlLBhcb --=-=-= Content-Type: text/plain Josselin Poiret writes: > Christopher Baines writes: > >> I guess my perspective on this is more from the operation of the guix >> data service, which is carefully computing and storing all of these >> broken derivations (and there's a lot, like 10,000+ per revision at the >> moment, since they change every time you compute them). This then >> propagates down to the build coordinator as well, since there's builds >> being submitted for all these broken derivations. I have considered >> trying to detect these breakages in the data service, but I'm not sure >> how to do it while removing the possibility of false positives. > > I guess you already read the derivations from the data service to find > out what has changed, right? Would you also be able to try to read the > builder script from there, before trying to build? And if the > derivation is bad, signal it somehow and flag it for some sort of gc? > Although then, all other derivations depending on it would also need to > be gc'd, which might be annoying. > > I don't know if the data service's architecture would allow this to be > done before trying to build derivations though, sorry in advance if that > would be too much work. It would do, but I'm not sure this would be as reliable as doing the check from Guix, especially since the version of Guile used for the checking might be different. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmRWC7dfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xd8yA/+NZ1HjOVWoUaNckfArWu8OH9OFAKLGKgQ fOnCw4E6zV+NK9H/70IWYNh5NjlPj/lRLQdZ9WaCbHu7LW5UKgWK5J0j0Si2QNYf PRxya+WmIwePKEnxbB2eLYXzFeaDVp35tyWsmEaOYP7OyPtw6ZeW9U5bWTt4j/oT z5Ucj1wYHokVPsDpOlm9W53UYFYS/6VVH9LX6QEipuTwwZD4zqFkEK9DOgquzeWE XTOwfMXxd4bCfQlGBNjGKqnm8TCE0CYz4SznIrFtII5a5K/WPXXIYtmIFun6J+cz BrgNKTetIJVpYDETxkVx3NQYywxoO5zAUEnxVoyLCxEmtrpX4cuDihEcYg18Z6q1 QiiSsjhKBrkr5ZF9ZKM6sGzbGbO7SBJEymil4suuq4KTke970JD/Fs3D2pQRt9zx gn9itM1p/FHZy1r271S4H3WYnWuutIVfWFgyc8JsdkN+oArp9y7Ng3EQWF/bjWc6 H5X+CXejVfoHRqMVTvuZKQuva+tJq6B61qpceYbg5qZsszcgF4AF8faAjVpi+fzn BS79SmYIAuaSRqldnbk3qF48k80KgmFXkCyAEGXGxZrLGq2esLYOlzLPQhAFQB+l otm++rzZye384GSgwilZcfTW38aceoIUk6wMqpoQcb/w554WkJFUuoZRmLnhvaC/ YUYWHPFWxuw= =zZHD -----END PGP SIGNATURE----- --=-=-=--