From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id yEnmG9QE/WR4XgEAG6o9tA:P1 (envelope-from ) for ; Sun, 10 Sep 2023 01:50:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yEnmG9QE/WR4XgEAG6o9tA (envelope-from ) for ; Sun, 10 Sep 2023 01:50:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2EF115FD73 for ; Sun, 10 Sep 2023 01:50:44 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jY6+JVqQ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694303444; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uwjb7PQ7B6BbSPtHjV5FBZZmLdoxpRknFxqXfui0pSQ=; b=o/3VJUcj/O7+s2noOqYiMexZXusDQyAXY33m+G8rTOzk4ymAGOnFgqfCx4xWr4T29JXzOr yozVfK23ELwxhUVMX9W7MwRzXR4F0GeF5zSrDrWpTXoiB5gYVm9RnV3FMZarhaZnJr1sry Q0UTzanhPrs0jkV7MtMdS0HPMHQ7wXXL67VRXBmjG/5FNvWgMDBiPSoBw4KxWsiJsFKpsw a/4qkOrLkpAUJJPxJyirWhwIRp4hf4cFvYI/8f1V/OmJu799rdpwdWVFbBnYBHwQ8JmtNN +G3tKcxbHxg0ZuCW4Jd6tDqZSt9xS2r9ZGIDbd+nzl+1cnUgUI9Mua/6qD7q7A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694303444; a=rsa-sha256; cv=none; b=tPyJdwzVf8dEqCUxz5lvC7lppkVgfSFGQYY2uqWbz0SqlsEAwQSrO5hOm+vUjV7/Ntnvso +Eso/DstmqMttZnPf3A4nbOdAYBtNjcelwovGU1+RoPuaWdt8XEfKbK8RCXAJuvtT2d1kp 5T9zdREhQqqht2ttt/Y6zJ1LmmkwQZI7wscQwP6+7hXP+hGiiD8GlYU9VLyzySUTPn19Q4 oEUKjNn6xxGoeby9pZn3AePsQ12kn1wVhzld02NRo15Fx4coh41KGJ0l5odXe3W+3yiWCd h+qnWJ/eY85CbVYWPgRiRJPIP6qC8mupC5KvNojaYc1HMDeQCrnwJoEhMxEUtA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=jY6+JVqQ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qf7iU-00069G-4w; Sat, 09 Sep 2023 19:50:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qf7iQ-00068t-4J for guix-devel@gnu.org; Sat, 09 Sep 2023 19:50:14 -0400 Received: from mail-qt1-x834.google.com ([2607:f8b0:4864:20::834]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qf7iN-00037C-KY for guix-devel@gnu.org; Sat, 09 Sep 2023 19:50:13 -0400 Received: by mail-qt1-x834.google.com with SMTP id d75a77b69052e-412195b1e9aso23391131cf.2 for ; Sat, 09 Sep 2023 16:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694303410; x=1694908210; darn=gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=uwjb7PQ7B6BbSPtHjV5FBZZmLdoxpRknFxqXfui0pSQ=; b=jY6+JVqQiuYNIwNHy5SXpwjdZi4uYBdBsadqdxBWAtLfnFK1U4Ky5KZkPwUOyQWzMM NU39OBmdrJgvGn2abHSxrSuvB1nENLfJ8mOzCe3MZIeB6xKfyMdBuG17QqkM2y8P432P EFYmFs6AFiJMIhJIxMNyz8om7u4Jfu1CpKgZLpPeRS1wklVPb/37eQRafLcBuP8n+Cth B8f6HECP5K4n+7AKN93FvH/RhBIDQIuEvV94+sXk/fPNJvsNRJB0mZl/mfcV4+5UfdCb gt4IQeaBMNbVYw3CwjfqCfnpLQVnucZY1/1sPNFfHv3HnJ7GxumCp5Afm7Klm6vy3EgA V9/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694303410; x=1694908210; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uwjb7PQ7B6BbSPtHjV5FBZZmLdoxpRknFxqXfui0pSQ=; b=McUYCGTgAZeJpgaucy/ceuRI9u+OtcI7ficF1p8BA8MGCxvuspIzii14QdXJAb0QSs 54M4M4xCeW0SPyBA1hbFhmhf60ChIV24GeLt/BjxkkYRjlKYdLnGNnmlJWWJscuJaDeK kszaMX1fKvvx1o1IIOywWHrvVmFvrvptFYINy6JTeZrIG8DzXRwwQHiiiU2Sl1N0AL/4 fQu5YCOrlaaKvOA7xW29s7hQblXn5JIJpa38kMENZz5CbkxTV2nER9olEb5kICPs9I8O voqFSwj5SGm+nNlpcdLqdVqRa2HQrLjTfcyCyT/CKvpLMxM8n/V0gqKXQ3zt0rqIpr0K kAaA== X-Gm-Message-State: AOJu0YwfhwlESD9bA/3tunO8Y3Y9L/7H0nLPJuA7G4RNmezakjylKjfo /rLFhtMB1qKqdA+1WCpAaB7aEm3XfX4= X-Google-Smtp-Source: AGHT+IFy6Cdt9mZcyAEsr+uy08riAJXDQKIbwX1R8DFpFQI5pyyB6Jo/OWhZMpH4onswnZGJZ8MJ7A== X-Received: by 2002:ac8:4e52:0:b0:403:ac95:c6a9 with SMTP id e18-20020ac84e52000000b00403ac95c6a9mr7922834qtw.30.1694303410167; Sat, 09 Sep 2023 16:50:10 -0700 (PDT) Received: from hurd (dsl-155-89.b2b2c.ca. [66.158.155.89]) by smtp.gmail.com with ESMTPSA id if1-20020a05622a6a0100b00403c1a19a2bsm1575033qtb.92.2023.09.09.16.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Sep 2023 16:50:09 -0700 (PDT) From: Maxim Cournoyer To: Vagrant Cascadian Cc: Felix Lechner , Giovanni Biscuolo , Simon Tournier , guix-devel@gnu.org Subject: Re: [workflow] Automatically close bug report when a patch is committed References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <86o7ien856.fsf@gmail.com> <87h6o6fdgv.fsf@xelera.eu> <877cp2nn91.fsf@gmail.com> <871qfam14v.fsf@wireframe> Date: Sat, 09 Sep 2023 19:50:08 -0400 In-Reply-To: <871qfam14v.fsf@wireframe> (Vagrant Cascadian's message of "Thu, 07 Sep 2023 08:52:32 -0700") Message-ID: <87ledex5xr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::834; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x834.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -1.11 X-Spam-Score: -1.11 X-Migadu-Queue-Id: 2EF115FD73 X-TUID: BWgi39/XT3EH Hi Vagrant, Vagrant Cascadian writes: [...] >> Did you see my message about integrating a commit-hook similar to what >> Gerrit uses? It produces unique ID such as: >> >> --8<---------------cut here---------------start------------->8--- >> Change-Id: I9b86781869d80eda347659f0c009b8dfe09bdfd0 >> --8<---------------cut here---------------end--------------->8--- >> >> at the bottom (it's a git trailer) of a commit message. Being unique, >> these could be used to match if a patch on the tracker has been merged >> in the master branch. >> >> Attached is what the hook looks like. The random 'Change-Id' is >> generated via >> >> --8<---------------cut here---------------start------------->8--- >> random=$({ git var GIT_COMMITTER_IDENT ; echo "$refhash" ; cat "$1"; } | >> git hash-object --stdin) >> --8<---------------cut here---------------end--------------->8--- > > That seems like it would only work if the patch was identical, as > opposed to a slightly rebased patch on top of newer patches on master? > > How can you correlate Change-Id to a patch in the tracker? The Change-Id stays the same unless you manually edit it out of your commit message when amending / rebasing, so the commit hash may change while the Change-Id stays the same. So you can rebase your feature branch on master and share a v2, whose existing commits will have the same Change-Ids (newly added commits would get their own Change-Id trailer). > Would it break git commit signatures? It doesn't impact git commit signatures. -- Thanks, Maxim