all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: lgcoelho@disroot.org, 68012@debbugs.gnu.org
Subject: [bug#68012] [PATCH] services: Add thinkfan service.
Date: Sat, 13 Jan 2024 17:29:08 +0100	[thread overview]
Message-ID: <87le8tgpt7.fsf@jpoiret.xyz> (raw)
In-Reply-To: <29b6707c8c4cdf1808edc79813215578@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Hi Luis,

lgcoelho--- via Guix-patches via <guix-patches@gnu.org> writes:

> This patch add thinkfan-service-type to (gnu services pm).
> From 92bf99099f91c0f1dae71b0cf9e5f8e6799a3679 Mon Sep 17 00:00:00 2001
> From: Luis Guilherme Coelho <lgcoelho@disroot.org>
> Date: Sun, 24 Dec 2023 15:52:04 -0300
> Subject: [PATCH] services: Add thinkfan service.
>
> ---

Please add a commit message following the ChangeLog convention.  You can
take inspiration from other commits in the repo, and read up on it at [0].

> +  (config-file
> +   (string "/etc/thinkfan.conf")
> +   "Configuration file to use.")

This should not refer to an absolute path.  Please use a file-like
instead, users can still use (local-file ...) to give external files.

[0] https://www.gnu.org/prep/standards/html_node/Change-Logs.html
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

      parent reply	other threads:[~2024-01-13 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-24 18:53 [bug#68012] [PATCH] services: Add thinkfan service lgcoelho--- via Guix-patches via
2023-12-25 23:59 ` [bug#68012] [PATCH] thinkfan-service-type: Place config-file in /etc/thinkfan.conf if file-like lgcoelho--- via Guix-patches via
2024-01-13 16:30   ` Josselin Poiret via Guix-patches via
2023-12-27 17:04 ` [bug#68012] [PATCH] thinkfan-service-type: Add thinkfan entry to thinkfan-configuration lgcoelho--- via Guix-patches via
2024-01-13 16:31   ` Josselin Poiret via Guix-patches via
2024-01-13 16:29 ` Josselin Poiret via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le8tgpt7.fsf@jpoiret.xyz \
    --to=guix-patches@gnu.org \
    --cc=68012@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=lgcoelho@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.