From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QK++BqgZ72XFDQEAe85BDQ:P1 (envelope-from ) for ; Mon, 11 Mar 2024 15:48:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id QK++BqgZ72XFDQEAe85BDQ (envelope-from ) for ; Mon, 11 Mar 2024 15:48:08 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=fabionatali.com header.s=gm1 header.b=kiXGiowU; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=reject) header.from=fabionatali.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710168488; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=jASEnO+GoWyHMTXr2L94GFB7ZiYcsMit71p/lXGW9L8=; b=QA8YHuATbHkjgGk2pGfYYkk1ygqLqOdx/Qw+BfC7EQndbE6W70BwTmz7hxiiEeqxcbTIiJ x/8IqW/TWTpxqtcH4XYwdDwM+nlre5DcAk9qQWh+v1PDEmTuM0MSn2trJHkuq3DeGdqXLh sT48I7EIjR7w1H+XN0d9exFAcyyirFsl3ItKBMHDrNBWF+LUc+UQh4zHC91R657sd3yJzl DZLHKAXg76RICcPg2EtxklUjPQLd6dKtxESAxWxY2qqna2VHDBVhMy/AwZfuc/cl4H82KK tBQo6iPkjuL80tQb99MuYwUAPZdf8ywzDlCNUfsKif8f/ZZ364CjxVqFlMmjfA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=fabionatali.com header.s=gm1 header.b=kiXGiowU; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=reject) header.from=fabionatali.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710168488; a=rsa-sha256; cv=none; b=ixU1szClWZbMuRe4hYGwjFz2DVAUuaAeoE9iPP+v2TR/N+LizP0uo/saAL6QknMqtC6Scu lAxOfD/9tOSb3vtf/I7wJvKOJqUfZBAXE2Zle6m01E0vEYXftTYZHFupa5ddsk/1TPFGzN Ql8ijcMbWAGUxJD9vNj3AM0KClqIuoo0VgXxYBNVg/oQWiX/ArN4q3n/MuOMUhLD1wf9Rj lRVRMBLRceRF5fIUeY8rDqekTXWcYDYwUQqzt2az0FtOffSOidTfXCVZityLCGXoyS7a/M fihcSk/mFq2o12dXJCvaCfc9U7nSC3ZHdUsEbuu9p9b9hulWqpwAd8+MdsquZA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DABBC6748F for ; Mon, 11 Mar 2024 15:48:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjgwH-0004aL-FO; Mon, 11 Mar 2024 10:47:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjgwG-0004Ub-Bd for guix-devel@gnu.org; Mon, 11 Mar 2024 10:47:40 -0400 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjgwD-0004NY-GA for guix-devel@gnu.org; Mon, 11 Mar 2024 10:47:39 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 58FE82000B; Mon, 11 Mar 2024 14:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1710168453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jASEnO+GoWyHMTXr2L94GFB7ZiYcsMit71p/lXGW9L8=; b=kiXGiowU9/RRmmXetJqbQ2gqgyUT76m4lROFsk8j5h8KfeTcCCWFNfq9gCuJ4RMObEP8z/ omEO5oCPFpxLTSzS/IO4y5k+Aif3EMb6HWuJDfz9cyX2Pa3MUyGHum+F+5Kcgw4nr6mTzV Q8io5kxUCq18eHdYE7Jp4ZR2Lc4rZpSjKSDi94OOHXAZ3ZFG+y1bfpt4YjDnasIcSAtOU6 27Mbq5acOVrJEVtrGsuFj8aHUlR4OW+v5jpI9edKKDPBJa0dlpnRjkZRmGzGgv/W+vaSO8 PoDcLhMslAvjvzqDqZ4Q2njJOF8nmFRTrz34v5nd7hs5drQh5PJBpyIPbf5SVw== From: Fabio Natali To: Josselin Poiret Cc: guix-devel@gnu.org, Oleg Pykhalov , Felix Lechner Subject: Re: [PATCH 2/2] gnu: grub: Modernize. In-Reply-To: <87msr7n3le.fsf@jpoiret.xyz> References: <87bk7vhett.fsf@fabionatali.com> <87r0gpf1i8.fsf@fabionatali.com> <87msr7n3le.fsf@jpoiret.xyz> Date: Mon, 11 Mar 2024 14:47:31 +0000 Message-ID: <87le6o9664.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: me@fabionatali.com Received-SPF: pass client-ip=2001:4b98:dc4:8::227; envelope-from=me@fabionatali.com; helo=relay7-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.28 X-Spam-Score: -8.28 X-Migadu-Queue-Id: DABBC6748F X-Migadu-Scanner: mx13.migadu.com X-TUID: NydDbr2APSiG On 2024-03-09, 10:42 +0100, Josselin Poiret wrote: > Of course, I'm known as jpoiret there. Hi Josselin, Thanks for the patches =F0=9F=99=8F, which I've applied and tested as follo= ws. ./pre-inst-env guix build grub ./pre-inst-env guix lint grub ./pre-inst-env guix build --check grub Everything passed successfully, both in the case of the first patch alone and when using the two patches together. I made sure that the package built was version 2.12 instead of 2.06. When building a system image, the first patch gave me an error if used by itself. The error was along the lines of: ice-9/read.scm:126:4: In procedure read-expr*: Unknown # object: "#<" I haven't investigated this further as the error resolved when applying both patches together. I then installed GRUB 2.12 on a spare x86 machine. With this new version of GRUB, I was able to use a LUKS2 partition with PBKDF2 public-key-based key derivation function. Yay! =F0=9F=9A=80 When building GRUB 2.12 on the spare machine this test initially failed: https://git.savannah.gnu.org/cgit/grub.git/tree/tests/grub_cmd_date.in The error vanished when I tried a second time and I haven't been able to reproduce it since then. The patches have two micro-typos: - First patch, s/Theses/These/. - Second patch, s/use-abolute-ovmf-path/use-absolute-ovmf-path/. I haven't tried the patches on any non-x86 architecture, but will ping you on IRC to see if and how I can help with that. Thanks, best, Fabio. --=20 Fabio Natali https://fabionatali.com