From: Fabio Natali via Guix-patches via <guix-patches@gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 68289@debbugs.gnu.org
Subject: [bug#68289] [PATCH] services: xorg: Add xorg-start-command-xinit procedure.
Date: Wed, 24 Apr 2024 12:59:55 +0100 [thread overview]
Message-ID: <87le53nf7o.fsf@fabionatali.com> (raw)
In-Reply-To: <87zftpedyt.fsf@fabionatali.com>
On 2024-04-19, 13:25 +0100, Fabio Natali <me@fabionatali.com> wrote:
> On 2024-04-18, 23:09 +0200, Tomas Volf <~@wolfsden.cz> wrote:
>> first, let me thank you for the review, and apologize for somewhat
>> late response, sadly I have been busy.
Hi Tomas,
Sorry for the slow follow-up. After some further testing and some input
from other Guix friends, this is my humble feedback on what I'd put in a
v2 patch.
- Use Guix's 'invoke' instead of a custom 'checked-system*' procedure.
- Where possible, use '#$(file-append foobar "/bin/foo")' instead of
'(string-append #$foobar "/bin/foo")', so that as much computation as
possible happens at build time as opposed to run time. It's a
microscopic difference, but still worth the change I think.
What do you think? Not urgent, but do you think this is something you
might be interested to include in a v2? No problem if you're busy, but
let me know if there's anything I can help with.
Tangentally, with regard to 'capture-stdout', I'm exploring if this is
something that could be added to '(guix build utils)'⁰ or perhaps
addressed in Guile¹ instead of Guix. This can be left as it is in the
patch, and potentially refactored away once a similar procedure is
available from Guix or Guile.
Thanks, best wishes, Fabio.
⁰ https://lists.gnu.org/archive/html/guix-devel/2024-04/msg00199.html
¹ https://lists.gnu.org/archive/html/bug-guile/2024-04/msg00015.html
--
Fabio Natali
https://fabionatali.com
next prev parent reply other threads:[~2024-04-24 12:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 15:07 [bug#68289] [PATCH] services: xorg: Add xorg-start-command-xinit procedure Tomas Volf
2024-04-16 18:29 ` Fabio Natali via Guix-patches via
2024-04-17 9:30 ` Fabio Natali via Guix-patches via
2024-04-18 18:43 ` Fabio Natali via Guix-patches via
2024-04-18 21:17 ` Tomas Volf
2024-04-18 21:09 ` Tomas Volf
2024-04-19 12:25 ` Fabio Natali via Guix-patches via
2024-04-24 11:59 ` Fabio Natali via Guix-patches via [this message]
2024-04-24 17:43 ` Tomas Volf
2024-05-02 9:55 ` Ludovic Courtès
2024-05-02 14:58 ` Tomas Volf
2024-05-03 9:57 ` Ludovic Courtès
2024-05-11 13:29 ` Tomas Volf
2024-05-11 13:26 ` [bug#68289] [PATCH v2 1/3] " Tomas Volf
2024-05-11 13:26 ` [bug#68289] [PATCH v2 2/3] services: xorg: Add startx-command-service-type Tomas Volf
2024-05-11 13:26 ` [bug#68289] [PATCH v2 3/3] home: services: Add home-startx-command-service-type Tomas Volf
2024-05-30 17:33 ` [bug#68289] [PATCH] services: xorg: Add xorg-start-command-xinit procedure Arun Isaac
2024-05-30 18:27 ` Tomas Volf
2024-05-30 18:18 ` [bug#68289] [PATCH v3 1/2] services: xorg: Add startx-command-service-type Tomas Volf
2024-05-30 18:18 ` [bug#68289] [PATCH v3 2/2] home: services: Add home-startx-command-service-type Tomas Volf
2024-05-30 18:29 ` [bug#68289] [PATCH v4 1/2] services: xorg: Add startx-command-service-type Tomas Volf
2024-05-30 18:29 ` [bug#68289] [PATCH v4 2/2] home: services: Add home-startx-command-service-type Tomas Volf
2024-05-30 21:43 ` bug#68289: [PATCH] services: xorg: Add xorg-start-command-xinit procedure Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le53nf7o.fsf@fabionatali.com \
--to=guix-patches@gnu.org \
--cc=68289@debbugs.gnu.org \
--cc=me@fabionatali.com \
--cc=~@wolfsden.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.