From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id YA3NH29eKmaplgAAe85BDQ:P1 (envelope-from ) for ; Thu, 25 Apr 2024 15:45:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id YA3NH29eKmaplgAAe85BDQ (envelope-from ) for ; Thu, 25 Apr 2024 15:45:19 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=SadkDhiW; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714052719; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HelotezeQjdYfI6uoWXoZ377gZkSUxKiLkN1VqTa/4s=; b=rAgONbnyyWMG4MxQyURy0FbMCXwR1szX09QzsuPTVisal8mIgftBM08X9QkoYTNcJjaVgy snNTYIC7fBppPEp5Lfj4t7vcCkadr9HSJ+W8Bf4odRopvQqrHyzfXFYCSmY1pDchxkH1Tq u8Hl+0LC4LF8PHWYd4YAzySZ1RNtRL4DBA4MqIgnObBAcfgMEG+9dnDw3We1OaO5fT2jcp TvxC0WA9CCC+EKvZKdXOepFhz5AyMunDd49A1khJtsUPWPwV96UDi85WoWNdIGy6oSmjqr 2GBKOJ3w3xQw0/NX3lw/Xg8E4fT0DhrPQ4K/HdHCVbri4GGmf6yKEEjuS7F2cA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=SadkDhiW; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714052719; a=rsa-sha256; cv=none; b=hyJBNm/vwsDB6dz1jacUFHbWrpDV3yVZ2P9zDIttj1i9v803MQxhY0onkFtkrha0ElS9Lp mZobd9oIt43OG09QZR1QoXitKCvkr5Ppv1wFwPtIGzXPuWpMMSw1cy16CzkUVKc8pjyFRu oofnM7oLKghLro8W6uHD7J5sBmYrDd64nq6erDMQoDU6nizcEGL+cPOGzLpqoE74ssFVJV 9nYTcvk/G60PMNbZiJ5EWl3AIYeQ0KLbhU5iMWKqN6YPgVOTJby8zLNe4qTU/dpyWXuSqB C4e92f8adAX/HOTYiA42HNrXRkqqtu96k4xLSQH44B/a5Jrl6ZSd0DckaFhOaw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F367606DB for ; Thu, 25 Apr 2024 15:45:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzzPJ-0005tq-1X; Thu, 25 Apr 2024 09:45:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzzPH-0005lB-3c for guix-patches@gnu.org; Thu, 25 Apr 2024 09:44:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzzPF-0003TH-IO for guix-patches@gnu.org; Thu, 25 Apr 2024 09:44:58 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rzzPW-0000WL-HX for guix-patches@gnu.org; Thu, 25 Apr 2024 09:45:14 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70542] [PATCH 0/4] Improve Shepherd service support for networked file systems Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 Apr 2024 13:45:13 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70542 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jonathan Brielmaier Cc: 70542@debbugs.gnu.org Received: via spool by 70542-submit@debbugs.gnu.org id=B70542.17140526781534 (code B ref 70542); Thu, 25 Apr 2024 13:45:13 +0000 Received: (at 70542) by debbugs.gnu.org; 25 Apr 2024 13:44:38 +0000 Received: from localhost ([127.0.0.1]:60741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzzOn-0000NB-6U for submit@debbugs.gnu.org; Thu, 25 Apr 2024 09:44:36 -0400 Received: from mail-108-mta1.mxroute.com ([136.175.108.1]:43835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzzOb-0000Kz-Dc for 70542@debbugs.gnu.org; Thu, 25 Apr 2024 09:44:23 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta1.mxroute.com (ZoneMTA) with ESMTPSA id 18f157f9b560008ca2.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 25 Apr 2024 13:43:55 +0000 X-Zone-Loop: f41248c01652547fc179f9142e55e340a2e00bcdf388 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HelotezeQjdYfI6uoWXoZ377gZkSUxKiLkN1VqTa/4s=; b=SadkDhiW5d/hWKePOa9wkKAE6Z edkEj0qxzYmNDbUNx2YlVCmbiM1BQ44XvQeGo+kbvisG1uIA1bXWcy4rAWcA97ObBEmnAVPA7Onf+ 9M9f5Lpu/n5gQqkeG/lr+mXzFA2bysbAq245scGDNTHagGaWFTvK9ZFvAPwotHWlMtkFOoCp6efCu LskBDQjub6YbytIkGet454C9KecJOnbjbMJELNKrtjkP5bbgZ81G5T91ZOJbmi6ehkT3g2lmstZkp 5BL4EKVBO40FtaMBXm3ihW/CP80UYr0koEyp/KLYJz6nTv68JJV1U5CZ8osQXYhz4Ounl/heU5+CC s2RmXd9g==; From: Richard Sent In-Reply-To: <9e8e0f42-e403-d919-3b18-be010757097c@web.de> (Jonathan Brielmaier's message of "Thu, 25 Apr 2024 08:51:56 +0200") References: <9e8e0f42-e403-d919-3b18-be010757097c@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 25 Apr 2024 09:43:47 -0400 Message-ID: <87le51y2uk.fsf@freakingpenguin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Authenticated-Id: richard@freakingpenguin.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.39 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -6.39 X-Migadu-Queue-Id: 4F367606DB X-TUID: qu1uOkHS8zuO Hi Jonathan! Jonathan Brielmaier writes: > Hello Richard, > > thanks for improving the CIFS mounting problem! > > I'm using a CIFS share on one of my servers. There I stumbled upon a > problem, that the share is disappearing (e.g. CIFS server unavailable > for a short time) and gets not automatically remounted. > > Do you know if this particular problem gets resolved with your patch? > I've never experienced that issue myself so I can't say for sure. However, I don't believe my patch would resolve that issue. file-system-shepherd-service in (gnu services base) is in charge of mounting the file system. That service does not attempt to monitor the file system's status after running. There's no daemon. If the file system is mounted successfully, Shepherd will think there's no problem. My understanding is that Shepherd will not respawn a service that starts, then exits sucessfully. From Shepherd's manual: > start=E2=80=99. If the starting attempt failed, it must return =E2=80=98= #f=E2=80=99 > or throw an exception; otherwise, the return value is stored > as the =E2=80=9Crunning value=E2=80=9D of the service. This could be solved by, for example, adding a remount? flag and/or remount-delay field to file-systems and changing file-system-shepherd-service to conditionally use a fork-style constructor many other services use. Within that process, a loop checks if there is a file system mounted at the target location. There might be a better way to structure this. I'd be a little worried about adding many new file-system record fields that aren't always used. Consider when needed-for-boot is #t, file-system-shepherd-service isn't used at all. Those new flags silently do nothing. I think that's fine when it's just one (requirements), but it's probably worth some thought if we add more later. Either way it's probably another patch problem. --=20 Take it easy, Richard Sent Making my computer weirder one commit at a time.