From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id WOR7GsQxRmYEOwEAe85BDQ:P1 (envelope-from ) for ; Thu, 16 May 2024 18:18:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id WOR7GsQxRmYEOwEAe85BDQ (envelope-from ) for ; Thu, 16 May 2024 18:18:12 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715876292; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Lug8kki7Ypra7kGgz5FHGcPS+tI/CfKzIRv/njeg91I=; b=Cm17DHa3s4KRCK6Zm50emfa/OOKqa8xk1Fxu94ZwIki70xz49xC4fVyUnqmejQSrOUYon2 TK1eakPwdGVMwJxmAt1va/buXHx1IWiu1xx90FxWFnWl9NvwlytykTmikoPRISIjHZMesT ETjNFUbUdBDH4DnOABs2PDW7JEylyeNQ0Q5T8kOa4mYbhNOW3FScKU/tBqB4iAVNMB08UA RDexMm9QjStUax/++1tsh2T0YBsoMOpHgncg16uZKFO7twmDUSvmsTYWeyp2Zc49BZ3EVV HwzGeHV9AoNDGnDfkNGGtaJhXPKhCyQ4cIsbFAUOgW3ZDvA7gKwjBTyEvK+Ceg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715876292; a=rsa-sha256; cv=none; b=DQiHc1kQMUWxIq+4LWZlJ6YmmgJTmzjXF1JlauajYuFvyEpwX+LQcHd3N+IJrBY38jdRhB SgvKYNxh25yIewKJJc3lYzdqheQbQ9cDYCu6x2yISdTCcWY8aoTq43PX72zdhhe3oJVxfB 33HSGVaYm/RgwUogRnOL2xnrqJVoD+v1yCd6ykZ7+bgu6vwo2LvmV1uVv9pf8T/8nmBKhO RPx8aPNa1KwZ55YNRRQL4H8kQwF06rb5VJcWnFJlhmMRAu0onVWltpdqwmmBl2Jw3+T6CY cM0fPbKJgFtgVJYwbjhpsgfV4KkfEAAZXnavGe8VL4DWIXWYLrRPsMnY6zrHog== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A8536B54F for ; Thu, 16 May 2024 18:18:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7dnw-0002ne-QC; Thu, 16 May 2024 12:18:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7dns-0002kk-3o for guix-patches@gnu.org; Thu, 16 May 2024 12:18:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7dnr-0001qA-RZ for guix-patches@gnu.org; Thu, 16 May 2024 12:17:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7dnu-0000QO-42 for guix-patches@gnu.org; Thu, 16 May 2024 12:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70985] [PATCH 3/4] gnu: cross-libc*: Raise conditions rather than returning #f. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 May 2024 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70985 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 70985@debbugs.gnu.org Received: via spool by 70985-submit@debbugs.gnu.org id=B70985.17158762471601 (code B ref 70985); Thu, 16 May 2024 16:18:02 +0000 Received: (at 70985) by debbugs.gnu.org; 16 May 2024 16:17:27 +0000 Received: from localhost ([127.0.0.1]:49628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7dnK-0000Pl-ML for submit@debbugs.gnu.org; Thu, 16 May 2024 12:17:27 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7dnH-0000PY-F4 for 70985@debbugs.gnu.org; Thu, 16 May 2024 12:17:23 -0400 Received: from localhost (unknown [45.67.83.153]) by mira.cbaines.net (Postfix) with ESMTPSA id 67C1A27BBE2; Thu, 16 May 2024 17:16:49 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id b1ab4150; Thu, 16 May 2024 16:16:45 +0000 (UTC) From: Christopher Baines In-Reply-To: <87h6exbxfn.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 16 May 2024 17:15:08 +0200") References: <3828bc238a8cc400f9686fe6856c665c31e927dd.1715871966.git.mail@cbaines.net> <05efcc4bcf0dc4b270930747d215a97b2bd86761.1715871966.git.mail@cbaines.net> <87h6exbxfn.fsf@gnu.org> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Thu, 16 May 2024 17:16:42 +0100 Message-ID: <87le49n34l.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -8.47 X-Migadu-Queue-Id: 4A8536B54F X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -8.47 X-TUID: j5ZQezWsAtiX --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines writes: > >> As this means that the error will be clearer for targets which are >> unsupported. >> >> * gnu/packages/cross-base.scm (cross-libc*): Raise conditions rather than >> returning #f. >> >> Change-Id: I820780ad738d85a98950de5608f3019e961ff7c8 > > [...] > >> - (else #f))) >> + (else >> + (raise (condition >> + (&package-unsupported-target-error >> + (package libc) >> + (target target))))))) > > What I'm unsure is whether this works with libc-less triplets such as > =E2=80=98avr=E2=80=99 or =E2=80=98or1k-elf=E2=80=99. Hmm, it seems like this is erroring in some cases where it didn't before, I'm not sure why though. I ended up here through rust-sysroot-for-... since it calls cross-libc. Handling cross-libc returning #f in the packages which use it seems error prone, hence adding the exception inside of cross-libc*. It looks liek cross-gcc-toolchain/implementation is expecting cross-libc to return #f in some cases though, so maybe I need to add a guard there somehow to handle the exception and ignore it, as happens when it returns #f. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmZGMWpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdE5w//bVPBGIo8sv+MEkKtEtlrIBfIH8jfgS5a uvU2ZKOfvvLRX0Ywe8EVJ2DDgCfSN96G1/nz7XbmkYBnTdHNu+eUV+/6+RqDxrmG lSXyz1QvmRNql6kj4V5upp+N6/Uwr0BRummunBcbaJDJJUKtE+bXq5VST0sQMLAa VDNFN++2kBAoUaCKQpcsh7dGyaApY47K61QWrgpcM5kWH+1luqq31mDlUadzVN8f laPoOXFxiFOi0nzj0v9pQZOOho35Yl0e0nhSV5u8WO0efj374glQgVhSVwY+AUaC uRxY/qQaj615pa1bLSGsic+656uviQAuh1aTSuqpCJqORZWemBUcOWAIXgBiO2vh 77NH1A2B8CnRqyehrVVpH/YXwoOozIYY1xO73GIGwDfDU4Qv6oKulZB1qDM4Dt/U 5RNeQKEJQcAQKV09z0ZUrnnSWsibGf1kiFN88ht6CLOL9stbd1sqbvE+7L+I8gYb Yc3QweqwVEa6H6XbOLpEfpVFSHJ6HSZrhYoeiBXOmfIfOZeebkG7zwzLiaStXTCw fCFqIXBKBHjUUv8hpuk/AP5dtZEF+y7hngaNH/gOUcoVPj7FokfxzpBSNHNLzRXy 1+AiSHAUmooOET8zagzqKj473GK6T9NMoAOvOd2tFDmBV51VT5XMEwz+UAmuVp7Z qZcjmsAZQho= =k2Fx -----END PGP SIGNATURE----- --=-=-=--