all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: 72871-done@debbugs.gnu.org
Cc: gemmaro <gemmaro.dev@gmail.com>
Subject: bug#72871: [PATCH] gnu: Add emacs-qt-pro-mode.
Date: Thu, 05 Sep 2024 19:52:16 +0200	[thread overview]
Message-ID: <87le06ounj.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <f7a7b4059b167979db1d6d9916d08dfe8616c125.1724931294.git.gemmaro.dev@gmail.com>

Hello,

> * gnu/packages/emacs-xyz.scm (emacs-qt-pro-mode): New variable.

Thank you. I applied the patch with the following changes:

> +    (package
> +      (name "emacs-qt-pro-mode")
> +      (version (git-version "1.0.1" revision commit))

I set base version to 1.0.0, as specified in the main file. I'm not sure
where 1.0.1 is coming from.

> +       (list
> +        #:tests? #t
> +        #:phases #~(modify-phases %standard-phases
> +                     (replace 'check
> +                       (lambda* (#:key tests? #:allow-other-keys)
> +                         (when tests?
> +                           (invoke "make" "test")))))))

I replaced the whole phase with #:test-command keyword.

Regards,
-- 
Nicolas Goaziou






      reply	other threads:[~2024-09-05 17:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29 11:34 [bug#72871] [PATCH] gnu: Add emacs-qt-pro-mode gemmaro
2024-09-05 17:52 ` Nicolas Goaziou via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le06ounj.fsf@nicolasgoaziou.fr \
    --to=guix-patches@gnu.org \
    --cc=72871-done@debbugs.gnu.org \
    --cc=gemmaro.dev@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.