From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6H7QDl9N6GbrKgEAqHPOHw:P1 (envelope-from ) for ; Mon, 16 Sep 2024 15:23:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 6H7QDl9N6GbrKgEAqHPOHw (envelope-from ) for ; Mon, 16 Sep 2024 17:23:11 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=SZSrKPFs; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=c6cL+3mn; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726500191; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=D3iQ2emaxbbu2Zh4abCa+GXZnlkStdid/BWp5LUE2HM=; b=W5R8iLgI+Kas8RzC+4+wLb5txBNQ4zYJx2mW+SlDbo7AVLI1drB6Mzrp6944hLnzdsOq+/ A/QkkDotP6Kb8LEPQVQ6UT1x+GT0/BrDnfugoAFWUps1ivcdq7PFauv4T7xDOUwpN0D/Yk 0LUkzFKwvKk2tTba0B9lHQiJyHH2dIFNXDygH19xAmugIn4QEroLOBv3FN0KaEzTqzzWYJ 4fl/BS68ru2Y8q3D96hR9tBSmOFUNJu7PcIOXl422tg7WYFBIhGqyMdWKzrIztHuj9joJq 0swNPDQasfn0C5M43Fu3eouEnPwjzjZ4ViV+JH7MIumb1rf15/gTVgI4REqFUg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=SZSrKPFs; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=c6cL+3mn; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726500191; a=rsa-sha256; cv=none; b=mb1xODIA+8mnEb50npUhl2zJsfkTQSUuFLfEwy989vslX5/52VcykLX0czrSh4WA4WgxIn GPS5TTqk3mcqJc3j4k/CTVDuleoofwtF/NHdZ3t4koGAZEtCQpLdILACQySF6u8AVgtRlk iEUnOAY8YqhQH5UeZzMsAJzNRRpldpd1aaQJVOR3tmWCMyBEq+jstaEsWvMs/s+JN7oChQ l5BEyc5ywoqRDKfEVYkmDaWdM8wwbno24+HA/VAiynJ8ek7lGKoc5RNqu4pyHFlciKTXZK GVO29+SDzhDeOqtnYdL6q6Dq3KM2GGEvE+W9TiGRHDqC4Q5JXhV6tvIpFnjQXg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 047F98689F for ; Mon, 16 Sep 2024 17:23:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqDYy-0004b6-8Q; Mon, 16 Sep 2024 11:22:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqDYv-0004at-SX for guix-patches@gnu.org; Mon, 16 Sep 2024 11:22:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqDYu-0005qn-Mk for guix-patches@gnu.org; Mon, 16 Sep 2024 11:22:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=D3iQ2emaxbbu2Zh4abCa+GXZnlkStdid/BWp5LUE2HM=; b=SZSrKPFs/L1qIXiToy9906oUcZRdq3gw0XdybDQp/+44lM1DLt0fvdnfVM9fvJjomJADVJ4m84gG+A47QK/ywu855sAweWd6dXyx6pywqGA61ujToQCmVeu5z9Oh80YvORHHw9ZrpF+h+j4Udrzr9AlOtyrzvkP/heobJYXEYE/89cRahorTo9XPMkS1zkZvl/wAzLscgAE4WU1UqbF4p3CKurJemGJkPGyovipMOc05N+VBygzxBN0M19hB161FZ8WIjcWIhGWp1KfvPglxO1KTo95QRbjiqmC4cjaLv3tq+YPt0nET2vaCN702x7Wt+ZscN9bUP+r8UuGDrmmPIg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqDZ8-0006PP-1z for guix-patches@gnu.org; Mon, 16 Sep 2024 11:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70314] [PATCH] guix: scripts: environment: add tls certs to networked containers Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Sep 2024 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70314 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines , 70314@debbugs.gnu.org Received: via spool by 70314-submit@debbugs.gnu.org id=B70314.172650016124594 (code B ref 70314); Mon, 16 Sep 2024 15:23:02 +0000 Received: (at 70314) by debbugs.gnu.org; 16 Sep 2024 15:22:41 +0000 Received: from localhost ([127.0.0.1]:53052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqDYm-0006Oa-Uv for submit@debbugs.gnu.org; Mon, 16 Sep 2024 11:22:41 -0400 Received: from mail-108-mta228.mxroute.com ([136.175.108.228]:36793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqDYk-0006OS-Vf for 70314@debbugs.gnu.org; Mon, 16 Sep 2024 11:22:40 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta228.mxroute.com (ZoneMTA) with ESMTPSA id 191fb6d75110013e01.002 for <70314@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 16 Sep 2024 15:22:20 +0000 X-Zone-Loop: d1845798e40e69d6d4a98721eda0343dbf5723b6c2db X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=D3iQ2emaxbbu2Zh4abCa+GXZnlkStdid/BWp5LUE2HM=; b=c6cL+3mnG00FEt3CRlvK5pIWR6 1pPc8jThBb77fKklLh318a+zhlkehzh5jy49Dv59MXT/0YB7j+QRNkH0NGCzPMXng4a2DMzEyrGZm L4Hk9nQjsEiPe5kX4o8g4telHi2geucpuPQXPJfLHApfK1ncCPK6byJjUg9wOI86nvhQX0AiDHqaC 2xVJJet6fhcxpC8aEKlfQeaHnypyW3L2E7GDieH4pbx1o5AkOeA4OMVnuWqG55LIHLXDrl9pCYM6/ 01O3V6NQV60o3/EJT341GR6N4TqUUeFcFmd8+zXKb55Kr5Rh8gJW1KSggmAtk26At/IFatZGgyUXo bSpuO0DA==; From: Richard Sent In-Reply-To: <87o74obna0.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 15 Sep 2024 23:49:27 +0200") References: <82121e1e6f3144f54d4a8e6d4276bb4581b627d2.1712689529.git.richard@freakingpenguin.com> <87o74obna0.fsf@gnu.org> Date: Mon, 16 Sep 2024 11:22:03 -0400 Message-ID: <87ldzrd3ok.fsf@freakingpenguin.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Authenticated-Id: richard@freakingpenguin.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 047F98689F X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -9.04 X-Migadu-Spam-Score: -9.04 X-TUID: SxSLq0VPCyXx Ludovic Court=C3=A8s writes: > Can we delay changes to the manifest until after all options have been > parsed, so we know whether =E2=80=98-C=E2=80=99 has been passed? >=20 > That way =E2=80=98guix shell -N --no-tls=E2=80=99 does not add =E2=80=98n= ss-certs=E2=80=99 to the > environments. Is `$ guix shell -N -- true` valid? I know it works at present, but my understanding is sharing the network only works with containers. From the manual: > =E2=80=98--network=E2=80=99 > =E2=80=98-N=E2=80=99 > For containers, share the network namespace with the host system. > Containers created without this flag only have access to the > loopback device. Perhaps instead we should error when -N is passed without -C, ala --8<---------------cut here---------------start------------->8--- modified guix/scripts/environment.scm @@ -1153,7 +1153,9 @@ (define (guix-environment* opts) (when nesting? (leave (G_ "'--nesting' cannot be used without '--container'~%"))) (when (pair? symlinks) - (leave (G_ "'--symlink' cannot be used without '--container'~%")))) + (leave (G_ "'--symlink' cannot be used without '--container'~%"))) + (when network? + (leave (G_ "'--network cannot be used without '--container'~%")))) =20 (when (and (not network?) no-tls?) --8<---------------cut here---------------end--------------->8--- --=20 Take it easy, Richard Sent Making my computer weirder one commit at a time.