From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id aJvmLu9lNWfqUQAA62LTzQ:P1 (envelope-from ) for ; Thu, 14 Nov 2024 02:52:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id aJvmLu9lNWfqUQAA62LTzQ (envelope-from ) for ; Thu, 14 Nov 2024 03:52:31 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=sgvmn4z7; dkim=fail ("headers rsa verify failed") header.d=rekahsoft.ca header.s=key1 header.b=fEPJuNcn; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731552751; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=TU+ccBCmYPJ+LqSpxFujaZJnlqk38SKd6kmtKmY8Ct8=; b=as+hhDO7hTs1oYUT0MmoUn/uH/S8leLo1xK975smM+0KRXwL8T+o+a8VLOTY1gzK6E9INN zeH/FKcPHu96VV1RCw91sAuAdpUUtA90O4dXKnV11+7FfvrJRUERG9irLvrcdegOkCp83y UnbQETYqNf67IOWAJiyhq+WOXlyGFijQQtme1fjRB66iy2sxIbe4+LG4hkNNpy+FTNYgo1 HrqXasXnYvdpwbbxnaw8s4s6C2alsjlNQT8f+h8on2qE+d2gqWJ8g5A+k0GkscwDEMn33t FxQX5RdMTl243sLXsB3yfL9wLxJ/1MG/C8EJ0VOWDynK1EfCe3CFBfAQnGJHhg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=sgvmn4z7; dkim=fail ("headers rsa verify failed") header.d=rekahsoft.ca header.s=key1 header.b=fEPJuNcn; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731552751; a=rsa-sha256; cv=none; b=VBY4ATC3IN1mQHsTlSTys4Xiurwk1iRrIcxTtf2F67PLndPZZxo/TCObs3+XQRf0BwRQlW SJ1zr0zNLogpdvamaOQjkTPdRKt5QzdjQ6riQv1Axry9zbvAR6VjIY6EwrB+a+EgOeEXOC w7jZPm8b8U2xLgiv+TzY3rfElcg4PjzwZ29OpVVEb57QhHJQyxwC4htI2zhACNe1NIdS79 U5Sf3AP0fPPuh6Ji+rSpoVYGZJBfX3A/u4JqBLki1ateKIQSZjmgWX9AexEpJbdt6rl278 3u6HzIMAh0b6hQsFApzAC5gebjEY7TLk/xzJHW+BAVDFFzPUgYaCGcYpkqk+Qw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0566B40FE0 for ; Thu, 14 Nov 2024 03:52:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBPxl-0003IX-TS; Wed, 13 Nov 2024 21:52:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBPxj-0003IN-73 for bug-guix@gnu.org; Wed, 13 Nov 2024 21:52:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBPxi-0007In-Uk for bug-guix@gnu.org; Wed, 13 Nov 2024 21:52:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=TU+ccBCmYPJ+LqSpxFujaZJnlqk38SKd6kmtKmY8Ct8=; b=sgvmn4z75nIkifr7Bf0dUCDfU16fJ46assgetK9gqZd5TScBHM+WctS3x5CIo8IKd1u8Rf4DAhue7LdWwzbieMRWGxdcYuN/FNEnbriKGwQ6s8/NqaI92C5Q63H3gazpZYiNopEerXahCVuh3PL/eD+9h2ma6Nkgt8gi27dpFsZD7oycaxhlH6sOGCFcw1hhE7Vv6RU0uKEcRncAKIV1gubgCsLy7fxoxyNzssyx/9n0sQJSMJK8qPBMfgaWfyDSJDgHP3Uo/KTyxLC73Lkbm/g3RiGL0qb2K6+fB2+lLahur5dGAoGbNhZkBMtiJdRUiPPC61IXVbfUIp0Ihb7aLQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tBPxi-0001R2-Hd for bug-guix@gnu.org; Wed, 13 Nov 2024 21:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#74203: Further investigation and workaround References: <874j4nt3fy.fsf@rekahsoft.ca> In-Reply-To: <874j4nt3fy.fsf@rekahsoft.ca> Resent-From: "Collin J. Doering" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 14 Nov 2024 02:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74203 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 74203@debbugs.gnu.org Received: via spool by 74203-submit@debbugs.gnu.org id=B74203.17315526695427 (code B ref 74203); Thu, 14 Nov 2024 02:52:02 +0000 Received: (at 74203) by debbugs.gnu.org; 14 Nov 2024 02:51:09 +0000 Received: from localhost ([127.0.0.1]:44403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBPwq-0001PT-D9 for submit@debbugs.gnu.org; Wed, 13 Nov 2024 21:51:08 -0500 Received: from out-175.mta0.migadu.com ([91.218.175.175]:54956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tBPwl-0001Ou-UV for 74203@debbugs.gnu.org; Wed, 13 Nov 2024 21:51:06 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rekahsoft.ca; s=key1; t=1731552655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=TU+ccBCmYPJ+LqSpxFujaZJnlqk38SKd6kmtKmY8Ct8=; b=fEPJuNcn8HdM2XOS3UEPtVZT/XnAafNKrKDsiteVEKwRSEgQTbURS6Xi664rxnp4eBbcMd mdNnuzuOV0ktpFKm68fBkvGS4BXGb0L1d2jfqn6jMdBf9buBJzW21/6UUYVpswBhu++rK1 e6hWsef3TdRqQHeG8nryuZWmvGYEpq4= Date: Wed, 13 Nov 2024 21:50:47 -0500 Message-ID: <87ldxmsf3s.fsf@rekahsoft.ca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: "Collin J. Doering" From: "Collin J. Doering" via Bug reports for GNU Guix Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -1.51 X-Spam-Score: -1.51 X-Migadu-Queue-Id: 0566B40FE0 X-TUID: HjqnLv1BdcUp --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi again, I wanted to follow up on my previous report and patch. I still think its us= eful to consider disabling the coreutils test I previously suggested, howev= er I found a way to work around the issue and wanted to make note of it, as= well as provide some details of my investigation. To work around the coreutils test `tests/cp/reflink-auto.sh` failing on gui= x commit `66611696975409a52478b95a862a464daeaefe2a`, I temporarily mounted = a tmpfs to replace /tmp (which was on btrfs). =2D-8<---------------cut here---------------start------------->8--- mv /tmp /tmp.old mkdir /tmp mount -t tmpfs tmpfs /tmp chmod 1777 /tmp mv /tmp.old/{.*,*} /tmp/ =2D-8<---------------cut here---------------end--------------->8--- Now, what made me do this? Well let me explain! In `tests/cp/reflink-auto.sh` (https://github.com/coreutils/coreutils/blob/= v9.1/tests/cp/reflink-auto.sh), the failing part of the test: =2D-8<---------------cut here---------------start------------->8--- # we shouldn't be able to reflink() files on separate partitions . "$abs_srcdir/tests/other-fs-tmpdir" a_other=3D"$other_partition_tmpdir/a" <..> returns_ 1 cp --reflink "$a_other" b || fail=3D1 =2D-8<---------------cut here---------------end--------------->8--- '$other_partition_tmpdir' is defined in 'tests/other-fs-tmpdir' (https://gi= thub.com/coreutils/coreutils/blob/v9.1/tests/other-fs-tmpdir) by looking th= rough a list of candidate directories, comparing the current working direct= ory to each candidate to see if they have different device ids (as given by= 'stat -c %d ') and that the current user can create directories ther= e. Once it finds a candidate, it sets '$other_partition_tmpdir' to the temp= orary directory it created. The candidate directories that are considered a= re as follows: =2D-8<---------------cut here---------------start------------->8--- test "${CANDIDATE_TMP_DIRS+set}" =3D set \ || CANDIDATE_TMP_DIRS=3D"$TMPDIR /tmp /dev/shm /var/tmp /usr/tmp $HOME" =2D-8<---------------cut here---------------end--------------->8--- Looking at a remaining failed build of coreutils (left over by building wit= h `--keep-failed`), I see that in 'top/environment-variables', 'TMPDIR' is = set to '/tmp/guix-build-guix-1.4.0-26.5ab3c4c.drv-0'. This directory is the= same place the build is taking place, so I would expect it to 'be on the s= ame partition'. So, next would be /tmp, where the same premise applies; nex= t is /dev/shm. From my tests simulating the coreutils guix shell build envi= ronment, this would meet the conditions and be selected. However, if this w= ere the case, I wouldn't expect the coreutils reflink test to fail. My suspicion is that for some reason, 'stat -c %d ' to check whether = two files, a and b are on the same partition doesn't play well with btrfs s= ubvolumes in some instances with guix-daemon sandboxed builds. However, whe= n trying to test this in a simulated coreutils guix shell build environment= , I found that paths outside of the environment on different subvolumes (th= at do indeed show different device ids (as per 'stat -c %d ' outside = of the guix shell container)), show the same id's within it. I suspect this= is related to why the coreutils test fails, but does not when I use a tmpf= s for /tmp. Its worth noting that on the system impacted, /gnu/store is a b= trfs subvolume. I am not yet satisfied with my with my partial explanation, and am very cur= ious if anyone spots something I'm missing (eg. has a better understanding = of the guix build environment and why the reflink coreutils test could be f= ailing like this). Thanks for your time and attention. =2D-=20 Collin J. Doering http://rekahsoft.ca http://blog.rekahsoft.ca http://git.rekahsoft.ca --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIoEARYKADIWIQSg4F3ACfM0j/GRGeP3fjGTl82nFgUCZzVlhxQcY29sbGluQHJl a2Foc29mdC5jYQAKCRD3fjGTl82nFgzbAQD2b+IJGAyaN0KjUxKIJ47eZD+nWgMu VsLKjo6ZosMcTgEApfsAskaxs/lfHil7AalJdkFNiR32ZoBmiRvMyqYFGgo= =ofWN -----END PGP SIGNATURE----- --=-=-=--