all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#74506] [PATCH] gnu: fonts: Add font-dina
@ 2024-11-23 22:33 8dcc
  2024-11-24 14:49 ` [bug#74506] QA review for 74506 Noé Lopez via Guix-patches via
  2024-11-24 14:53 ` [bug#74506] [PATCH v2] gnu: fonts: Add font-dina Noé Lopez via Guix-patches via
  0 siblings, 2 replies; 4+ messages in thread
From: 8dcc @ 2024-11-23 22:33 UTC (permalink / raw)
  To: 74506

* gnu/packages/fonts.scm (font-dina): New variable.
---
Not only is this my first patch to Guix, but also my first patch sent
via email. Excuse me if I made any mistakes.

 gnu/packages/fonts.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 65232db3b8..25a15348be 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -3874,3 +3874,22 @@ (define-public font-teko
 full support for the conjuncts and ligatures required by languages
 written with the Devanagari script.")
       (license license:silofl1.1))))
+
+(define-public font-dina
+  (package
+    (name "font-dina")
+    (version "2.92")
+    (source (origin
+              (method url-fetch/zipbomb)
+              (uri "https://www.dcmembers.com/jibsen/download/61/?wpdmdl=61")
+              (file-name "Dina.zip")
+              (sha256
+               (base32
+                "1kq86lbxxgik82aywwhawmj80vsbz3hfhdyhicnlv9km7yjvnl8z"))))
+    (build-system font-build-system)
+    (home-page "https://www.dcmembers.com/jibsen/download/61/")
+    (synopsis "Dina programming font")
+    (description "Dina is a monospace bitmap font, primarily aimed at
+programmers. It is relatively compact to allow a lot of code on screen, while
+(hopefully) clear enough to remain readable even at high resolutions.")
+    (license license:expat)))
-- 
2.47.0




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#74506] QA review for 74506
  2024-11-23 22:33 [bug#74506] [PATCH] gnu: fonts: Add font-dina 8dcc
@ 2024-11-24 14:49 ` Noé Lopez via Guix-patches via
  2024-11-24 14:53 ` [bug#74506] [PATCH v2] gnu: fonts: Add font-dina Noé Lopez via Guix-patches via
  1 sibling, 0 replies; 4+ messages in thread
From: Noé Lopez via Guix-patches via @ 2024-11-24 14:49 UTC (permalink / raw)
  To: control, 74506

user guix
usertag 74506 + reviewed-looks-good
thanks

Guix QA review form submission:
Hi, thanks for your patch!

Everything works well, it is just missing a dot in the commit message,
and a double space between sentences in the description.  I’m sending an
amended patch with these two changes.

Additionally, it is best to avoid adding your packages at the end of the
file to avoid merge conflicts, just put them where you feel like it or
near a related package.

Have a nice day,
Noé Lopez

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package synopsis and descriptions




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#74506] [PATCH v2] gnu: fonts: Add font-dina.
  2024-11-23 22:33 [bug#74506] [PATCH] gnu: fonts: Add font-dina 8dcc
  2024-11-24 14:49 ` [bug#74506] QA review for 74506 Noé Lopez via Guix-patches via
@ 2024-11-24 14:53 ` Noé Lopez via Guix-patches via
  2024-11-29 14:03   ` bug#74506: " Ludovic Courtès
  1 sibling, 1 reply; 4+ messages in thread
From: Noé Lopez via Guix-patches via @ 2024-11-24 14:53 UTC (permalink / raw)
  To: 74506; +Cc: Noé Lopez, 8dcc, Zhu Zihao, 宋文武

From: 8dcc <8dcc.git@gmail.com>

* gnu/packages/fonts.scm (font-dina): New variable.

Change-Id: I10f63e17754227145d72b1fc3380a532d74cef55
---
 gnu/packages/fonts.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 65232db3b8..69d7d039aa 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -3874,3 +3874,22 @@ (define-public font-teko
 full support for the conjuncts and ligatures required by languages
 written with the Devanagari script.")
       (license license:silofl1.1))))
+
+(define-public font-dina
+  (package
+    (name "font-dina")
+    (version "2.92")
+    (source (origin
+              (method url-fetch/zipbomb)
+              (uri "https://www.dcmembers.com/jibsen/download/61/?wpdmdl=61")
+              (file-name "Dina.zip")
+              (sha256
+               (base32
+                "1kq86lbxxgik82aywwhawmj80vsbz3hfhdyhicnlv9km7yjvnl8z"))))
+    (build-system font-build-system)
+    (home-page "https://www.dcmembers.com/jibsen/download/61/")
+    (synopsis "Dina programming font")
+    (description "Dina is a monospace bitmap font, primarily aimed at programmers.
+It is relatively compact to allow a lot of code on screen, while (hopefully) clear
+enough to remain readable even at high resolutions.")
+    (license license:expat)))

base-commit: 3feaac67a3426c7412e845f1ad9e6596235a3586
prerequisite-patch-id: d60665f9abfbc424d08418ccbc1ceaa14437e160
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#74506: [PATCH v2] gnu: fonts: Add font-dina.
  2024-11-24 14:53 ` [bug#74506] [PATCH v2] gnu: fonts: Add font-dina Noé Lopez via Guix-patches via
@ 2024-11-29 14:03   ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2024-11-29 14:03 UTC (permalink / raw)
  To: Noé Lopez; +Cc: 74506-done, Zhu Zihao, 宋文武, 8dcc

Noé Lopez <noe@noé.eu> skribis:

> From: 8dcc <8dcc.git@gmail.com>
>
> * gnu/packages/fonts.scm (font-dina): New variable.
>
> Change-Id: I10f63e17754227145d72b1fc3380a532d74cef55

Applied, thanks!




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-11-29 14:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-23 22:33 [bug#74506] [PATCH] gnu: fonts: Add font-dina 8dcc
2024-11-24 14:49 ` [bug#74506] QA review for 74506 Noé Lopez via Guix-patches via
2024-11-24 14:53 ` [bug#74506] [PATCH v2] gnu: fonts: Add font-dina Noé Lopez via Guix-patches via
2024-11-29 14:03   ` bug#74506: " Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.