From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id wCzJDX9OTmcfBgAAe85BDQ:P1 (envelope-from ) for ; Tue, 03 Dec 2024 00:19:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id wCzJDX9OTmcfBgAAe85BDQ (envelope-from ) for ; Tue, 03 Dec 2024 01:19:11 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=BBkDW0DK; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=cDnXlFDT; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=cDnXlFDT; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=wolfsden.cz (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733185150; a=rsa-sha256; cv=none; b=fX15vDJTLkzDGp8yBUKd8JbXbcqWidLCvQsZxyqSiGuOEH0Tu/VilwXTzGUYLLl8M+FwUg ZhGFUNyxxfcncCnvVtil6T/+I9tJxgoORTXaX+z9jkQbQWgsUECCQ/0/XaCbMyh1hDbW0M tjYfdLtdjdfod+qwFRFN5nUGMMWMOxzZN08983UnqQFvr+QviOFTpktQK/OTPxCWsqUqIW +akedweK5ev3akqQYKF5Wd/GSsw1r6yqX6KyDNKmk52AZdrOq41jW3MVZghGfYesYrpNqa qVPEfhMBDFRBbuyRoXI14p+qyGKOlWUbFBNi4Ym+o07CDvGyynm5j+BoRGtmgg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=BBkDW0DK; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=cDnXlFDT; dkim=fail ("headers rsa verify failed") header.d=wolfsden.cz header.s=mail header.b=cDnXlFDT; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=wolfsden.cz (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733185150; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=OiWzhS8EKxfaNLF1RdgtZAdnO4LmZVRR2rAWiEIg3D0=; b=nwlJtj3vFmi/4eE+JeMjAH7F7fL+GNJNNh223sU5+unvgvjJZJbDayVf8F6YfZzx611ewi APleEvdH0tCdgr2L0NjHYXVALqX7TU0Cnrny+QZP4T6gUlqL8lu3a6c1AyRCmh8ADtrvPc 5aXuwWhmh1RkLtes2VLMHXMxVpW+t90dKhWJyrH6MvGnSBWn4pGypwTvSIwNwn8LCIy/ZW jYkT/KybNsSAU/g0JQ3ib4hLZjqj1PdEIp442BtCVhMoRqx6pgBkvTCGNxRD5yVti3e0c5 bANrXCrPalwGC6B/ApKfryGCFVqUdTPx0IPPAuGq+bM5TVbnT1sprKrAgj5gRQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AA072370AE for ; Tue, 03 Dec 2024 01:19:10 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIGd6-00051l-CW; Mon, 02 Dec 2024 19:19:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIGd4-00051a-JB for guix-patches@gnu.org; Mon, 02 Dec 2024 19:19:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIGd4-0003Yk-9y for guix-patches@gnu.org; Mon, 02 Dec 2024 19:19:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=OiWzhS8EKxfaNLF1RdgtZAdnO4LmZVRR2rAWiEIg3D0=; b=BBkDW0DKobNLmEvh50rBg3A6BfxSUgyhqCmUGfm5l6O+creYBPJ4z+56dvf4KccGHiO0j7MWevZjXVKkLY2usdf4bXjSFGwc7iq2bl63g0gHuWKpkPrtb2av2MEmBDq9gS68YQep+kqf+Y3rp6gzgap+A3bEkCnQofPvRKMaPCK858ptcnzZFalEBD4OGHmJAOTm1QbeGs1qT/zl5jIfEG8Xh45imityd6FYrY9GVyvHfcUn9X9094iTgTkqSB+6LFORepw2wi0la8grKlM+n4rs3CS40OXl2GE0u32OBmNl2QSrVfrqZJhU70z0o7ikcfKrCXnq9B9yW+7rUb0jnA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIGd4-0000by-4C for guix-patches@gnu.org; Mon, 02 Dec 2024 19:19:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74508] [PATCH v2 1/3] services: mingetty: Add additional configuration options. Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Dec 2024 00:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 74508@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 74508-submit@debbugs.gnu.org id=B74508.17331850972278 (code B ref 74508); Tue, 03 Dec 2024 00:19:02 +0000 Received: (at 74508) by debbugs.gnu.org; 3 Dec 2024 00:18:17 +0000 Received: from localhost ([127.0.0.1]:57074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIGcK-0000ag-OQ for submit@debbugs.gnu.org; Mon, 02 Dec 2024 19:18:17 -0500 Received: from wolfsden.cz ([37.205.8.62]:45398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tIGcH-0000aP-BS for 74508@debbugs.gnu.org; Mon, 02 Dec 2024 19:18:14 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 650BB338906; Tue, 3 Dec 2024 00:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1733185092; bh=p3NJEgWARBF1AZniacmn1y7CXS8QAt2JzuIXdOxb4DM=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=cDnXlFDTK8AGIG4styPtM+IAqeph8MheimPlEryTP6CAff/qTptVPvu3nIH0QrZq9 JQQ6nkmwrcn+2FaOkeTfr4qfdwQSF8j8HfyNEaQFZqD6zyeCioH7p2ictclkSo2ZdB 169ZVyezzBmN8OQMuISXGTkn1U9ekOHaKDrZLRV5tRrbpBVxlyWCBei26OPAzI35Cu MYl1o7MlAyA1+NBrA7KzUnE7ffpvBSk9s/Hm1PzdAx7Ub+t/Y5nBl6MepTigsb6EHl lYYGepBfM3nxaxbuiCasQgKpgsVn628VilrTLl/vsQa5RG2YD/ftX6Fh97N7MBaKpf uN/hYglG7z1tOtJxOFynVHUqVGS8DjJOnkzf2oqsoaFtmePnBGq3fI4rUWje7S+g9J +GVVqcYw+5EEutDI3advEY9B+ewOnOE1mR14R5abwGn58WWPnUdJzG0ubUKdptNUoh BBPiyHZNfG+UbCGmkZrPxL0F5Mgt1W9J7svZByt9V3mcD16KGcUXmYMvxGkZxgCHQq wNrb15gqM8b6qCJQr7szbtOUHZdGGxLTwxA1VYdumQiOetHCSBs39FYddEXhMtC2s4 ZOV08HZQn+Pe5Xp17q+cAtf2R9CN7vhzMppxcOQ1RBmSVXf+ih8iHMLso6I7IHINn/ V8Zf5/1UXt+qKWrz6G/dkT/U= Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id 0D60C32773D; Tue, 3 Dec 2024 00:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1733185092; bh=p3NJEgWARBF1AZniacmn1y7CXS8QAt2JzuIXdOxb4DM=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=cDnXlFDTK8AGIG4styPtM+IAqeph8MheimPlEryTP6CAff/qTptVPvu3nIH0QrZq9 JQQ6nkmwrcn+2FaOkeTfr4qfdwQSF8j8HfyNEaQFZqD6zyeCioH7p2ictclkSo2ZdB 169ZVyezzBmN8OQMuISXGTkn1U9ekOHaKDrZLRV5tRrbpBVxlyWCBei26OPAzI35Cu MYl1o7MlAyA1+NBrA7KzUnE7ffpvBSk9s/Hm1PzdAx7Ub+t/Y5nBl6MepTigsb6EHl lYYGepBfM3nxaxbuiCasQgKpgsVn628VilrTLl/vsQa5RG2YD/ftX6Fh97N7MBaKpf uN/hYglG7z1tOtJxOFynVHUqVGS8DjJOnkzf2oqsoaFtmePnBGq3fI4rUWje7S+g9J +GVVqcYw+5EEutDI3advEY9B+ewOnOE1mR14R5abwGn58WWPnUdJzG0ubUKdptNUoh BBPiyHZNfG+UbCGmkZrPxL0F5Mgt1W9J7svZByt9V3mcD16KGcUXmYMvxGkZxgCHQq wNrb15gqM8b6qCJQr7szbtOUHZdGGxLTwxA1VYdumQiOetHCSBs39FYddEXhMtC2s4 ZOV08HZQn+Pe5Xp17q+cAtf2R9CN7vhzMppxcOQ1RBmSVXf+ih8iHMLso6I7IHINn/ V8Zf5/1UXt+qKWrz6G/dkT/U= From: Tomas Volf <~@wolfsden.cz> In-Reply-To: <87v7w2wdir.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 02 Dec 2024 12:05:48 +0100") References: <3735b134a382255528e7da6706828ee5d80f50a5.1732550735.git.~@wolfsden.cz> <87v7w2wdir.fsf@gnu.org> Date: Tue, 03 Dec 2024 01:18:11 +0100 Message-ID: <87ldwx39h8.fsf@wolfsden.cz> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.51 X-Spam-Score: -6.51 X-Migadu-Queue-Id: AA072370AE X-Migadu-Scanner: mx12.migadu.com X-TUID: 2/zaVAIekWg2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > Tomas Volf <~@wolfsden.cz> skribis: > >> +@item @code{chdir} (default: @code{#f}) >> +When set to a string, change into that directory before calling the >> +login program. >> + >> +@item @code{chroot} (default: @code{#f}) >> +When set to a string, call @code{chroot} with that directory. > > How about =E2=80=98working-directory=E2=80=99 and =E2=80=98root-directory= =E2=80=99 for these two, in > line with widespread naming convention? > > And instead of =E2=80=9Ccall chroot=E2=80=9D, I=E2=80=99d write =E2=80=9C= use this directory as the > process's root (``chroot'' into it).=E2=80=9D (again in an effort to avoid > jargon and abbreviations). > > Other than that LGTM! I cannot say I particularly agree with that. I would consider both `chdir' and `chroot' being terms familiar to anyone who would actually want to configure them, and the terms map cleanly to the mingetty(8). In any case, I do appreciate the review and I have sent a v3 with the requested changes. Have a nice day, Tomas =2D-=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmdOTkMOHH5Ad29sZnNk ZW4uY3oACgkQL7/ufbZ/wamZsQ//Rt3UT6YZ/ATH84SCgK44V8+zhLqwHCxU5yMM 2wM1JV/hzdqAUiJ0tTfwSO8bBEAg/o8tIRhJpUzicqWM+eQrK1AZL+TRF349pDnS hqHjEaS0cVgKRbLp7wP/GmrRmpG1B68l88eZUywhf3RxhEjWhcu28Wi0z9bFq4tS ZDxH2gzcZZ2wtVkV7BDfUapSglNSHM+lCeMYgWzO3QPjz32f/lQoJ4v8Id/5027f HC+Cf5yzK78amm7qtBWrAq9IyH73sPapp0sEJMYy0KI3z6L4sXRNtQ7O0KJiuN3/ sUXaD6cV/0ahcT+LOfYhWNDDOE1ov6jIp0B9NnFzYFWobEk1z2/oGrxw7ncOaXd7 PZXsmjJgru+68W72+s9LGNSmrr8AggNYw7ukEjoXO93j2nU3EarKmcxyiJDyjOib M9A8TzBtuhrPRxVK0QSrtgH1TguLeKyZ8aIHtmSi1kfZ+FeLSziIvIKNA9W8q1FB yKE10jZAj6SVN4GEcpL7Jgjc7KAGKEbrJHAFutEAVYJVgszjE3u+amqFtGsDZ2gS E+LSOc+OpInOemnY1BFkXzvqVSypv+ZYhj5mIxv1Tr+c6dnj1ovVnf7SWn9bTMey pDEWlkkFDIHlDaet/5+0hvuhYgc5UblH/DhofZZiN1g/a8IZWleqZFBI3/Xm0f97 0cLmU+Y= =CT3l -----END PGP SIGNATURE----- --=-=-=--