Ludovic Courtès writes: > Hi, > > Tomas Volf <~@wolfsden.cz> skribis: > >> +@item @code{chdir} (default: @code{#f}) >> +When set to a string, change into that directory before calling the >> +login program. >> + >> +@item @code{chroot} (default: @code{#f}) >> +When set to a string, call @code{chroot} with that directory. > > How about ‘working-directory’ and ‘root-directory’ for these two, in > line with widespread naming convention? > > And instead of “call chroot”, I’d write “use this directory as the > process's root (``chroot'' into it).” (again in an effort to avoid > jargon and abbreviations). > > Other than that LGTM! I cannot say I particularly agree with that. I would consider both `chdir' and `chroot' being terms familiar to anyone who would actually want to configure them, and the terms map cleanly to the mingetty(8). In any case, I do appreciate the review and I have sent a v3 with the requested changes. Have a nice day, Tomas -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors.