From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add cmake.
Date: Fri, 15 Mar 2013 11:41:45 +0100
Message-ID: <87k3p9ymfq.fsf@gnu.org>
References: <1363060349-19250-1-git-send-email-tipecaml@gmail.com>
	<87k3p9q3sx.fsf@gnu.org> <51428383.90407@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:56324)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UGS5F-0005lL-LJ
	for bug-guix@gnu.org; Fri, 15 Mar 2013 06:41:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UGS5D-0006ot-VA
	for bug-guix@gnu.org; Fri, 15 Mar 2013 06:41:57 -0400
Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=50677
	helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UGS5D-0006me-PP
	for bug-guix@gnu.org; Fri, 15 Mar 2013 06:41:55 -0400
In-Reply-To: <51428383.90407@gmail.com> (Cyril Roelandt's message of "Fri, 15
	Mar 2013 03:12:19 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: bug-guix@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> On 03/14/2013 06:39 PM, Ludovic Court=C3=A8s wrote:

[...]

>> Ideally all patches should eventually be submitted upstream, but
>> sometimes it=E2=80=99s not desirable, because the changes would too spec=
ific or
>> intrusive.  State it in the patch if that is the case.
>>
>
> Here, these tests require network connectivity, so I don't think
> upstream will accept the patches.

Ah OK.  Then just specify it in the patch header.

>> Other than that, looks good to me, so feel free to push then.
>>
>> It would be great to have a =E2=80=98cmake-build-system=E2=80=99, which =
would be based
>> on =E2=80=98gnu-build-system=E2=80=99 but with specific =E2=80=98configu=
re=E2=80=99 and =E2=80=98test=E2=80=99 phases.
>> See guix/build-system/perl.scm and related files for an example.  :-)
>>
>
> I'll have to try and package a piece of software requiring cmake, then :)

Of course!  :-)

Ludo=E2=80=99.