From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add cmake.
Date: Thu, 14 Mar 2013 18:39:10 +0100
Message-ID: <87k3p9q3sx.fsf@gnu.org>
References: <1363060349-19250-1-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:49473)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UGC7d-0006Cd-1P
	for bug-guix@gnu.org; Thu, 14 Mar 2013 13:39:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UGC7b-0006Dr-QP
	for bug-guix@gnu.org; Thu, 14 Mar 2013 13:39:20 -0400
Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=49322
	helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1UGC7b-0006CV-KN
	for bug-guix@gnu.org; Thu, 14 Mar 2013 13:39:19 -0400
In-Reply-To: <1363060349-19250-1-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Tue, 12 Mar 2013 04:52:29 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: bug-guix@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/cmake.scm: New file.
> * gnu/packages/patches/cmake-fix-tests.patch: New file.
> * Makefile.am: Add them.

Thanks!  Can you add a comment at the top of the patch saying what it
does, why, with a pointer to any relevant mailing list discussion or
documentation?

Ideally all patches should eventually be submitted upstream, but
sometimes it=E2=80=99s not desirable, because the changes would too specifi=
c or
intrusive.  State it in the patch if that is the case.

Other than that, looks good to me, so feel free to push then.

It would be great to have a =E2=80=98cmake-build-system=E2=80=99, which wou=
ld be based
on =E2=80=98gnu-build-system=E2=80=99 but with specific =E2=80=98configure=
=E2=80=99 and =E2=80=98test=E2=80=99 phases.
See guix/build-system/perl.scm and related files for an example.  :-)

Ludo=E2=80=99.