Re: Add GNUMach Headers

[ludo@gnu.org (Ludovic Courtès)]

Hello!

Thanks for the patch, and welcome!

This looks good to me, but as a welcome present ;-), I’ll do some
nitpicking so you can learn about the conventions in use.

ΜΑΝΩΛΗΣ ΡΑΓΚΟΥΣΗΣ <manolis837@gmail.com> skribis:

> From ff3ee75b23e33b0250ce64ba90969d2a8ad4c521 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Sat, 15 Feb 2014 22:05:29 +0000
> Subject: [PATCH] Add GNU Mach kernel headers
>
> ---
>  gnu-system.am         |  1 +
>  gnu/packages/hurd.scm | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++

Please add a ChangeLog-style commit log entry (see the ‘HACKING’ file
for details.)

Also, we usually prefix with ‘gnu: ’ the subject line when changing
something under the gnu/ directory.

In general, see ‘git log’ when in doubt.  :-)

> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "http://ftp.gnu.org.ua/gnu/gnumach/gnumach-"
> +                          version ".tar.gz"))

This should be “mirror://gnu/gnumach/...” to allow the use of gnu.org
mirrors.

> +    (arguments 
> +     `( #:phases (alist-replace
          ^
There should be no space here.

> +                  'install 
> +                  (lambda _ (zero?
> +                             (system* "make" "install-data")))

Rather:

  (lambda _ ;; <- always skip a line after the lambda argument list
    (zero? ...))

> +                  (alist-delete
> +                   'build
> +                   %standard-phases))              
> +        #:tests? #f ))
                      ^
No space here.

> +;;TODO: package the rest of the components of the GNU Hurd system

No need to put it here, this is implicit.  :-)

Could you send an updated patch?

Thanks for diving into this!

Ludo’.