From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add glibc-hurd-headers
Date: Tue, 15 Apr 2014 21:39:47 +0200
Message-ID: <87k3aq1iws.fsf@gnu.org>
References: <CAFtzXzOZG6iYNacWOcmsp06qeAN_NQNboCczuTsy6oUBu5c2ag@mail.gmail.com>
	<87vbubzh7y.fsf@gnu.org>
	<CAFtzXzM3yy-WJ7EpmKBK8Vf4FnwQhG3gs1+bw5T=+Wmz_qZJXA@mail.gmail.com>
	<87d2gjat2d.fsf@gnu.org>
	<CAFtzXzMip3enx==ROf5pEttvp7P3YYaCyy_kf=raRAf5wmFfwQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58659)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Wa9D4-0005qy-Re
	for Guix-devel@gnu.org; Tue, 15 Apr 2014 15:40:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Wa9Cv-000424-Pe
	for Guix-devel@gnu.org; Tue, 15 Apr 2014 15:39:58 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:58270)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Wa9Cv-000420-IJ
	for Guix-devel@gnu.org; Tue, 15 Apr 2014 15:39:49 -0400
In-Reply-To: <CAFtzXzMip3enx==ROf5pEttvp7P3YYaCyy_kf=raRAf5wmFfwQ@mail.gmail.com>
	(Manolis Ragkousis's message of "Tue, 15 Apr 2014 14:00:02 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel@gnu.org

Manolis Ragkousis <manolis837@gmail.com> skribis:

> +(define-public glibc/hurd-headers
> +  (package (inherit glibc)
> +           (name "glibc-hurd-headers")

Indentation still wrong.

> +           (arguments
> +            `(#:strip-binaries? #f
> +              #:out-of-source? #t
> +              #:tests? #f
> +              #:configure-flags
> +              (list "--host=3Di686-pc-gnu"
> +                    "--enable-addons"
> +
> +                    ;; Installs NIS and RPC related headers that
> +                    ;; are not installed by default
> +                    "--enable-obsolete-rpc"
> +
> +                    (string-append "--with-headers=3D"
> +                                   (assoc-ref %build-inputs "gnumach-hea=
ders")
> +                                   "/include:"
> +                                   (assoc-ref %build-inputs "hurd-header=
s")
> +                                   "/include")
> +
> +                    ;; Use our Bash instead of /bin/sh.
> +                    (string-append "BASH_SHELL=3D"
> +                                   (assoc-ref %build-inputs "bash")
> +                                   "/bin/bash"))
> +              #:phases (alist-replace
> +                        'install
> +                        (lambda _
> +                          (zero? (system* "make" "install-headers")))
> +                        (alist-delete
> +                         'build
> +                         (alist-cons-before
> +                          'configure 'pre-configure
> +                          (lambda _
> +                            (substitute* "configure"
> +                              (("/bin/pwd") "pwd")))
> +                          %standard-phases)))))))

Sorry, I didn=E2=80=99t get initially that it needed this much of the initi=
al
arguments.  #:phases is the only thing that differs, right?

If that is the case, then indeed something like this is enough:

  (arguments
    `(#:tests? #f
      ,@(substitute-keyword-arguments (package-arguments glibc/hurd)
          ((#:phases _)
           '(alist-replace ...)))))

In general the guideline is to keep things as simple and concise as
possible.  In some cases, making things more concise will actually make
them more difficult to understand, which is not desirable.

HTH!

Ludo=E2=80=99.