Re: [PATCH] gnu: Add glibc-hurd-headers

[ludo@gnu.org (Ludovic Courtès)]

Manolis Ragkousis <manolis837@gmail.com> skribis:

> +(define-public glibc/hurd-headers
> +  (package (inherit glibc)
> +           (name "glibc-hurd-headers")

Indentation still wrong.

> +           (arguments
> +            `(#:strip-binaries? #f
> +              #:out-of-source? #t
> +              #:tests? #f
> +              #:configure-flags
> +              (list "--host=i686-pc-gnu"
> +                    "--enable-addons"
> +
> +                    ;; Installs NIS and RPC related headers that
> +                    ;; are not installed by default
> +                    "--enable-obsolete-rpc"
> +
> +                    (string-append "--with-headers="
> +                                   (assoc-ref %build-inputs "gnumach-headers")
> +                                   "/include:"
> +                                   (assoc-ref %build-inputs "hurd-headers")
> +                                   "/include")
> +
> +                    ;; Use our Bash instead of /bin/sh.
> +                    (string-append "BASH_SHELL="
> +                                   (assoc-ref %build-inputs "bash")
> +                                   "/bin/bash"))
> +              #:phases (alist-replace
> +                        'install
> +                        (lambda _
> +                          (zero? (system* "make" "install-headers")))
> +                        (alist-delete
> +                         'build
> +                         (alist-cons-before
> +                          'configure 'pre-configure
> +                          (lambda _
> +                            (substitute* "configure"
> +                              (("/bin/pwd") "pwd")))
> +                          %standard-phases)))))))

Sorry, I didn’t get initially that it needed this much of the initial
arguments.  #:phases is the only thing that differs, right?

If that is the case, then indeed something like this is enough:

  (arguments
    `(#:tests? #f
      ,@(substitute-keyword-arguments (package-arguments glibc/hurd)
          ((#:phases _)
           '(alist-replace ...)))))

In general the guideline is to keep things as simple and concise as
possible.  In some cases, making things more concise will actually make
them more difficult to understand, which is not desirable.

HTH!

Ludo’.