Re: [PATCH] gnu: Add sane-backends

[ludo@gnu.org (Ludovic Courtès)]

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/scanner.scm: New file.
> * gnu-system.am (gnu/packages/scanner.scm): Add it.

Should be:

    * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

> +  #:use-module ((guix licenses)
> +                #:renamer (symbol-prefix-proc 'license:)))

Use: #:prefix license: .

> +(define-public sane-backends
> +  (package
> +    (name "sane-backends")
> +    (version "1.0.24")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append 
> +                   "http://fossies.org/linux/misc/" name "-" version ".tar.gz"))
> +             ;; This is a private mirror.  The canonical download site is
> +             ;; "https://alioth.debian.org/frs/download.php/file/3958/"
> +             ;; but it seems not to work with gnutls atm

Indeed, I get 406 "Not Acceptable".  I’m not sure if this relates to
<http://bugs.gnu.org/18526>; could you open a bug?

In the meantime, can you put the two URLs, as in:

  (uri (list (string-append ...)
             (string-append ...)))

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f)) ; It would seem that tests are not maintained

What exactly is failing?  In the comment, please put facts on what’s
failing rather than guesses.  ;-)

> +    (home-page "http://www.sane-project.org")
> +    (synopsis "Raster image scanner hardware API")

Maybe “SANE hardware drivers”?

> +    (description "SANE stands for \"Scanner Access Now Easy\" and is an API
> +proving access to any raster image scanner hardware (flatbed scanner,
> +hand-held scanner, video- and still-cameras, frame-grabbers, etc.)..")  

Likewise, maybe state that this package provides the drivers.

Thanks,
Ludo’.