From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add Threading Building Blocks Date: Mon, 26 Jan 2015 22:24:23 +0100 Message-ID: <87k309grqw.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFr98-00070Q-V7 for guix-devel@gnu.org; Mon, 26 Jan 2015 16:24:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFr95-0004xH-MQ for guix-devel@gnu.org; Mon, 26 Jan 2015 16:24:34 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFr95-0004xD-Iw for guix-devel@gnu.org; Mon, 26 Jan 2015 16:24:31 -0500 In-Reply-To: (Ricardo Wurmus's message of "Mon, 26 Jan 2015 16:19:48 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org Ricardo Wurmus skribis: > There are a couple of things I'm not sure about: > > - should the examples be included per default or should they go into a > separate "doc" output together with the /doc directory? Together they > take up about 10MB. I would put them in =E2=80=9Cdoc=E2=80=9D. > - the version number is only given as "4.3 Update 2 Current version" on > the download page. I turned this into "4.3.2", but I'm not sure if > this is really equivalent or if we should rather use the datestamp on > the tarball (=3D "43_20141204") =E2=80=9C4.3.2=E2=80=9D looks good. If need be, the numbering scheme can a= lways be adjusted later. > From 3e5e1e49893c73f8b9a565edcae5388f548dd13a Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Mon, 26 Jan 2015 16:12:31 +0100 > Subject: [PATCH] gnu: Add Threading Building Blocks. > > * gnu/packages/tbb.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. [...] > + (alist-cons-before > + 'build 'set-build-path > + (lambda _ > + (substitute* "build/common.inc" > + (("export tbb_build_prefix.+$") > + "export tbb_build_prefix?=3Dguix\n"))) Rather put this in =E2=80=98snippet=E2=80=99 (I think Mark made this commen= t on IRC.) > + (synopsis "The Threading Building Blocks library abstracts low-level > +threading details") What about =E2=80=9CC++ library for parallel programming=E2=80=9D instead? > + (description > + "Threading Building Blocks (TBB) is a C++ runtime library that abst= racts > +the low-level threading details necessary for optimal multi-core perform= ance. > +It uses common C++ templates and coding style to eliminate tedious threa= ding > +implementation work. > + > +TBB requires fewer lines of code to achieve parallelism than other threa= ding > +models. The applications you write are portable across platforms. Sinc= e the > +library is also inherently scalable, no code maintenance is required as = more > +processor cores become available.") I would indeed remove the 2nd paragraph, and perhaps add something like =E2=80=9CIt provides parallel loop constructs, asynchronous tasks, synchronization primitives, atomic operations, and more.=E2=80=9D > + ;; GPL2 with exceptions Rather: =E2=80=9CGPLv2 with run-time exception: =E2=80= =9D. Thanks, Ludo=E2=80=99.