Re: [PATCH v2]: Add Ardour.

[ludo@gnu.org (Ludovic Courtès)]

Sorry for the delay.

In the future, could you use separate email threads, à la ‘git
send-email’?  That makes more reasonably sized bites.  :-)

Ricardo Wurmus <rekado@elephly.net> skribis:

> From cae7a61f645ff5b5e8458f5b3bcd0d6029e43b22 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Thu, 29 Jan 2015 23:11:30 +0100
> Subject: [PATCH 10/15] gnu: Add suil.
>
> * gnu/packages/audio.scm (suil): New variable.

OK.

> From a13f49d293eebf5d6de5170a4dfc0b9885a90c26 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Fri, 30 Jan 2015 18:14:00 +0100
> Subject: [PATCH 11/15] gnu: Add Vamp SDK.
>
> * gnu/packages/audio.scm (vamp): New variable.

[...]

> +    (home-page "http://vamp-plugins.org")
> +    (synopsis "Vamp audio plugin SDK")

What about “Modular and extensible audio processing system”?

> +    (license
> +     (license:bsd-style
> +      "https://code.soundsoftware.ac.uk/projects/vamp-plugin-sdk/repository/entry/COPYING"))))

Should be ‘x11-style’, see <http://directory.fsf.org/wiki/License:X11>.

> From 59b721c970278230bfc9c12588a3e671b264acd4 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Fri, 30 Jan 2015 18:15:03 +0100
> Subject: [PATCH 12/15] gnu: Add LADSPA.
>
> * gnu/packages/audio.scm (ladspa): New variable.

OK.

> From 94f5649f1310c9080c1bbbcfa92920831e056c7d Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Fri, 30 Jan 2015 18:15:50 +0100
> Subject: [PATCH 13/15] gnu: Add rubberband.
>
> * gnu/packages/audio.scm (rubberband): New variable.

[...]

> +    (home-page "http://breakfastquay.com/rubberband/")
> +    (synopsis "Audio time-stretching and pitch-shifting library")
> +    (description
> +     "Rubber Band is a library and utility program that permits changing the
> +tempo and pitch of an audio recording independently of one another.")
> +    (license license:gpl2)))

Isn’t it GPLv2+, according to <http://breakfastquay.com/rubberband/license.html>?

> From 199620c5fe4021084e15d7876aeabc2535854ae6 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 31 Jan 2015 00:04:20 +0100
> Subject: [PATCH 14/15] gnu: Add libgnomecanvasmm.
>
> * gnu/packages/gnome.scm (libgnomecanvasmm): New variable.

OK.

> From 537ce664730cac73bbf3889fb4b53d20aa763292 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 31 Jan 2015 00:07:57 +0100
> Subject: [PATCH 15/15] gnu: Add ardour.
>
> * gnu/packages/audio.scm (ardour): New variable.

OK.

> +(define-public ardour
> +  (package
> +    (name "ardour")
> +    (version "3.5.403")
> +    (source (origin
> +              ;; The project only provides tarballs upon individual request
> +              ;; (or after payment) so we take the code from git.
> +              (method git-fetch)

Woow, I wonder how much it costs to get the tarball.  ;-)

Thank you for all these packages!

Ludo’.