[PATCH] Add openlibm.

[PATCH] Add openlibm.

[Ricardo Wurmus]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-openlibm.patch --]
[-- Type: text/x-patch, Size: 2803 bytes --]

From 636e19fd0649cf18264dde64f76449f6b5d8e70c Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Mon, 9 Mar 2015 11:07:13 +0100
Subject: [PATCH] gnu: Add openlibm.

* gnu/packages/maths.scm (openlibm): New variable.
---
 gnu/packages/maths.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 231206c..fe2543d 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -991,6 +991,49 @@ based on transforming an expression into a bytecode and precalculating
 constant parts of it.")
     (license license:expat)))
 
+(define-public openlibm
+  (package
+    (name "openlibm")
+    (version "0.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/JuliaLang/openlibm/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0cwqqqlblj3kzp9aq1wnpfs1fl0qd1wp1xzm5shb09w06i4rh9nn"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags
+       (list (string-append "prefix=" (assoc-ref %outputs "out")))
+       #:phases
+       ;; no configure script
+       (alist-delete 'configure %standard-phases)
+       #:tests? #f)) ;the tests are part of the default target
+    (home-page "http://openlibm.org/")
+    (synopsis "System-independent, portable libm implementation")
+    (description
+     "OpenLibm is an effort to have a high quality, portable, standalone C
+mathematical library (libm).  It can be used standalone in applications and
+programming language implementations.  The project was born out of a need to
+have a good libm for the Julia programming langage that worked consistently
+across compilers and operating systems, and in 32-bit and 64-bit
+environments.")
+    ;; From LICENSE.md:
+    ;;   "The OpenLibm code derives from the FreeBSD msun and OpenBSD libm
+    ;; implementations, which in turn derives from FDLIBM 5.3. As a result, it
+    ;; has a number of fixes and updates that have accumulated over the years
+    ;; in msun, and also optimized assembly versions of many functions. These
+    ;; improvements are provided under the BSD and ISC licenses. The msun
+    ;; library also includes work placed under the public domain, which is
+    ;; noted in the individual files. Further work on making a standalone
+    ;; OpenLibm library from msun, as part of the Julia project is covered
+    ;; under the MIT license. The test files, test-double.c and test-float.c
+    ;; are under the LGPL."
+    (license (list license:expat license:isc license:bsd-2 license:lgpl2.1+))))
+
 (define-public atlas
   (package
     (name "atlas")
-- 
2.1.0

Re: [PATCH] Add openlibm.

[Ludovic Courtès]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 636e19fd0649cf18264dde64f76449f6b5d8e70c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 9 Mar 2015 11:07:13 +0100
> Subject: [PATCH] gnu: Add openlibm.
>
> * gnu/packages/maths.scm (openlibm): New variable.

[...]

> +    (synopsis "System-independent, portable libm implementation")

What about “Portable C mathematical library (libm)”?

> +    ;; From LICENSE.md:
> +    ;;   "The OpenLibm code derives from the FreeBSD msun and OpenBSD libm
> +    ;; implementations, which in turn derives from FDLIBM 5.3. As a result, it
> +    ;; has a number of fixes and updates that have accumulated over the years
> +    ;; in msun, and also optimized assembly versions of many functions. These
> +    ;; improvements are provided under the BSD and ISC licenses. The msun
> +    ;; library also includes work placed under the public domain, which is
> +    ;; noted in the individual files. Further work on making a standalone
> +    ;; OpenLibm library from msun, as part of the Julia project is covered
> +    ;; under the MIT license. The test files, test-double.c and test-float.c
> +    ;; are under the LGPL."
> +    (license (list license:expat license:isc license:bsd-2 license:lgpl2.1+))))

Compared to the paragraph, the list misses ‘license:x11’.

Also, it’s enough to write “See LICENSE.md for details.”  No need to
copy the whole text IMO.

OK to push with these changes.

Thank you!

Ludo’.

Re: [PATCH] Add openlibm.

[Ricardo Wurmus]

[-- Attachment #1: Type: text/plain, Size: 1650 bytes --]


Ludovic Courtès writes:

>> +    (synopsis "System-independent, portable libm implementation")
>
> What about “Portable C mathematical library (libm)”?

Okay.

>> +    ;; From LICENSE.md:
>> +    ;;   "The OpenLibm code derives from the FreeBSD msun and OpenBSD libm
>> +    ;; implementations, which in turn derives from FDLIBM 5.3. As a result, it
>> +    ;; has a number of fixes and updates that have accumulated over the years
>> +    ;; in msun, and also optimized assembly versions of many functions. These
>> +    ;; improvements are provided under the BSD and ISC licenses. The msun
>> +    ;; library also includes work placed under the public domain, which is
>> +    ;; noted in the individual files. Further work on making a standalone
>> +    ;; OpenLibm library from msun, as part of the Julia project is covered
>> +    ;; under the MIT license. The test files, test-double.c and test-float.c
>> +    ;; are under the LGPL."
>> +    (license (list license:expat license:isc license:bsd-2 license:lgpl2.1+))))
>
> Compared to the paragraph, the list misses ‘license:x11’.

It mentions the MIT license, so I used "license:expat".  I don't think
the X11 license is meant, because the MIT license declaration on
https://github.com/JuliaLang/openlibm/blob/master/LICENSE.md does not
include the advertisement clause.

The list does miss license:public-domain, however.  Please correct me if
you think my understanding is incorrect.

> Also, it’s enough to write “See LICENSE.md for details.”  No need to
> copy the whole text IMO.

Okay.

Attached is an updated patch.

~~ Ricardo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-openlibm.patch --]
[-- Type: text/x-patch, Size: 2178 bytes --]

From f7732d683e3dee75c3ce7a8a65dd2c1548dabb32 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Date: Mon, 9 Mar 2015 11:07:13 +0100
Subject: [PATCH] gnu: Add openlibm.

* gnu/packages/maths.scm (openlibm): New variable.
---
 gnu/packages/maths.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 231206c..24c4149 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -991,6 +991,43 @@ based on transforming an expression into a bytecode and precalculating
 constant parts of it.")
     (license license:expat)))
 
+(define-public openlibm
+  (package
+    (name "openlibm")
+    (version "0.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/JuliaLang/openlibm/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0cwqqqlblj3kzp9aq1wnpfs1fl0qd1wp1xzm5shb09w06i4rh9nn"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:make-flags
+       (list (string-append "prefix=" (assoc-ref %outputs "out")))
+       #:phases
+       ;; no configure script
+       (alist-delete 'configure %standard-phases)
+       #:tests? #f)) ;the tests are part of the default target
+    (home-page "http://openlibm.org/")
+    (synopsis "Portable C mathematical library (libm)")
+    (description
+     "OpenLibm is an effort to have a high quality, portable, standalone C
+mathematical library (libm).  It can be used standalone in applications and
+programming language implementations.  The project was born out of a need to
+have a good libm for the Julia programming langage that worked consistently
+across compilers and operating systems, and in 32-bit and 64-bit
+environments.")
+    ;; See LICENSE.md for details.
+    (license (list license:expat
+                   license:isc
+                   license:bsd-2
+                   license:public-domain
+                   license:lgpl2.1+))))
+
 (define-public atlas
   (package
     (name "atlas")
-- 
2.1.0

Re: [PATCH] Add openlibm.

[Ludovic Courtès]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> Ludovic Courtès writes:

[...]

>>> +    ;; From LICENSE.md:
>>> +    ;;   "The OpenLibm code derives from the FreeBSD msun and OpenBSD libm
>>> +    ;; implementations, which in turn derives from FDLIBM 5.3. As a result, it
>>> +    ;; has a number of fixes and updates that have accumulated over the years
>>> +    ;; in msun, and also optimized assembly versions of many functions. These
>>> +    ;; improvements are provided under the BSD and ISC licenses. The msun
>>> +    ;; library also includes work placed under the public domain, which is
>>> +    ;; noted in the individual files. Further work on making a standalone
>>> +    ;; OpenLibm library from msun, as part of the Julia project is covered
>>> +    ;; under the MIT license. The test files, test-double.c and test-float.c
>>> +    ;; are under the LGPL."
>>> +    (license (list license:expat license:isc license:bsd-2 license:lgpl2.1+))))
>>
>> Compared to the paragraph, the list misses ‘license:x11’.
>
> It mentions the MIT license, so I used "license:expat".  I don't think
> the X11 license is meant, because the MIT license declaration on
> https://github.com/JuliaLang/openlibm/blob/master/LICENSE.md does not
> include the advertisement clause.

Sounds like you’re right, sorry for the confusion.

> The list does miss license:public-domain, however.

Right.

> From f7732d683e3dee75c3ce7a8a65dd2c1548dabb32 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 9 Mar 2015 11:07:13 +0100
> Subject: [PATCH] gnu: Add openlibm.
>
> * gnu/packages/maths.scm (openlibm): New variable.

LGTM.

Thanks for your patience,
Ludo’.