From: ludo@gnu.org (Ludovic Courtès)
To: "Tomáš Čech" <sleep_walker@suse.cz>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add tig.
Date: Thu, 12 Mar 2015 21:32:43 +0100 [thread overview]
Message-ID: <87k2ym0xec.fsf@gnu.org> (raw)
In-Reply-To: <1426107500-14709-1-git-send-email-sleep_walker@suse.cz> ("Tomáš Čech"'s message of "Wed, 11 Mar 2015 21:58:20 +0100")
Tomáš Čech <sleep_walker@suse.cz> skribis:
> * gnu/packages/version-control.scm (tig): New variable.
[...]
> + (arguments
> + `(#:phases
> + (alist-delete 'check %standard-phases)))
Rather “#:tests? #f” with a comment explaining why this is done (lack of
test suite?).
> + (synopsis "ncurses-based text-mode for GIT")
“Ncurses-based text user interface for Git”
> + (description
> + "Tig is ncurses TUI for GIT, primary intended as history browser but can
> +stage chunks for commit or colorize any GIT output.")
A few typos: “Tig is an ncurses text user interface for Git, primarily
intended as a history browser. It can also stage hunks for commit, or
colorize the output of the 'git' command.”
> + (license gpl2)))
GPLv2-only?
Could you send an updated patch?
Thanks,
Ludo’.
prev parent reply other threads:[~2015-03-12 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 20:58 [PATCH] gnu: Add tig Tomáš Čech
2015-03-12 20:32 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2ym0xec.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=sleep_walker@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.