From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCHES] Various
Date: Wed, 25 Mar 2015 17:47:30 +0100
Message-ID: <87k2y5t465.fsf@gnu.org>
References: <87sicx2qqz.fsf@taylan.uni.cx> <87384t2v40.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YaoSv-0006ru-7i
	for guix-devel@gnu.org; Wed, 25 Mar 2015 12:47:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YaoSr-0008Ls-08
	for guix-devel@gnu.org; Wed, 25 Mar 2015 12:47:37 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59646)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YaoSq-0008Lo-Tc
	for guix-devel@gnu.org; Wed, 25 Mar 2015 12:47:32 -0400
In-Reply-To: <87384t2v40.fsf@taylan.uni.cx> ("Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
	message of "Wed, 25 Mar 2015 12:07:43 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer=22?= <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org

taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") skribis:

> So I patched the pkg-config files of Leptonica (to move zlib and
> openjpeg from Libs.private to Libs) and Tesseract (to enable the
> Requires field, since Leptonica provides lept.pc on the meanwhile).
>
> The relevant Tesseract bug report is at:
> https://code.google.com/p/tesseract-ocr/issues/detail?id=3D1436

OK.  Could you add a link to this as a comment?

> From 41e485e47749119afc039796e88fcf8f787eeabc Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?=
=3D
>  <taylanbayirli@gmail.com>
> Date: Sat, 21 Mar 2015 19:41:54 +0100
> Subject: [PATCH 4/8] gnu: Add leptonica.
>
> * gnu/packages/image.scm (leptonica): New variable.

[...]

> +       (uri (string-append "http://www.leptonica.com/source/leptonica-"
> +                           version ".tar.gz"))

Really, they didn=E2=80=99t use =E2=80=98make dist=E2=80=99?

> +       (sha256
> +        (base32 "0j5qgrff6im5n9waflbi7w643q1p6mahyf2z35gb4vj9h5p76pfc"))
> +       (modules '((guix build utils)))
> +       ;; zlib and openjpg should be under Libs, not Libs.private.

Link to the bug report.

OK to push changes.  I wonder if (gnu packages graphics) would be more
appropriate.  Your call.

> From d12b1999a228d34e76cb93cba1a75cf7d18176bd Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?=
=3D
>  <taylanbayirli@gmail.com>
> Date: Sat, 21 Mar 2015 20:11:56 +0100
> Subject: [PATCH 6/8] gnu: Add tesseract-ocr.
>
> * gnu/packages/ocr.scm (tesseract-ocr): New variable.

[...]

> +       ;; Leptonica provides a pkg-config file on the meanwhile.

s/provides/added/ s/on/in/

OK.

> From 4c8af1741208f2d65e8ca9f3a37df38eb93a4b2d Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?=
=3D
>  <taylanbayirli@gmail.com>
> Date: Sat, 21 Mar 2015 23:09:11 +0100
> Subject: [PATCH 7/8] gnu: Add vapoursynth.
>
> * gnu/packages/video.scm (vapoursynth): New variable.

LGTM!

Ludo=E2=80=99.