From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add Julia.
Date: Wed, 25 Mar 2015 19:24:14 +0100 [thread overview]
Message-ID: <87k2y5q6k1.fsf@mango.localdomain> (raw)
In-Reply-To: <87d23xoxp2.fsf@netris.org>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
Mark H Weaver writes:
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>
>> May I suggest adding passing the "DYNAMIC_ARCH=1" flag in openblas
>> instead of propagating non-substitutability to Julia? When built with
>> "DYNAMIC_ARCH=1" the CPU type can be picked with the environment
>> variable OPENBLAS_CORETYPE=<type>. If I'm not mistaken this makes
>> substitutions for openblas possible.
>>
>> What do you think?
>
> Yes, we should do this.
Attached is a patch to make openblas substitutable.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-openblas-build-for-all-supported-CPUs.patch --]
[-- Type: text/x-patch, Size: 1076 bytes --]
From 326fa66415fe8e9ed2b28a249b903f4a654b769e Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Wed, 25 Mar 2015 19:20:11 +0100
Subject: [PATCH] gnu: openblas: build for all supported CPUs.
* gnu/packages/maths.scm (openblas)[arguments]: Pass make flag
"DYNAMIC_ARCH=1" to build library for all CPUs, making it substitutable.
---
gnu/packages/maths.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 49667cc..57c1e9f 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1033,10 +1033,10 @@ constant parts of it.")
(build-system gnu-build-system)
(arguments
'(#:tests? #f ;no "check" target
- #:substitutable? #f ;force local build because of CPU detection
#:make-flags
(list (string-append "PREFIX=" (assoc-ref %outputs "out"))
"SHELL=bash"
+ "DYNAMIC_ARCH=1"
"NO_LAPACK=1")
;; no configure script
#:phases (alist-delete 'configure %standard-phases)))
--
2.1.0
next prev parent reply other threads:[~2015-03-25 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 11:16 [PATCH] Add Julia Ricardo Wurmus
2015-03-23 9:29 ` Ludovic Courtès
2015-03-23 21:35 ` Mark H Weaver
2015-03-24 14:56 ` Mark H Weaver
2015-03-24 17:14 ` Ricardo Wurmus
2015-03-24 20:45 ` Ludovic Courtès
2015-03-25 16:20 ` Mark H Weaver
2015-03-25 18:24 ` Ricardo Wurmus [this message]
2015-03-25 21:00 ` Mark H Weaver
2015-03-26 15:19 ` Mark H Weaver
2015-03-26 16:58 ` Ludovic Courtès
2015-03-26 21:14 ` Ricardo Wurmus
2015-03-29 13:21 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2y5q6k1.fsf@mango.localdomain \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.