From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Subject: Re: [PATCH] gnu: Add fcitx.
Date: Thu, 02 Apr 2015 17:58:36 +0800
Message-ID: <87k2xukg1f.fsf@gmail.com>
References: <1427956011-18723-1-git-send-email-iyzsong@gmail.com>
	<871tk2evlt.fsf@mango.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42909)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Ydbt6-0005Dy-TL
	for guix-devel@gnu.org; Thu, 02 Apr 2015 05:58:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Ydbt1-0001PB-Sd
	for guix-devel@gnu.org; Thu, 02 Apr 2015 05:58:12 -0400
Received: from mail-pd0-x229.google.com ([2607:f8b0:400e:c02::229]:35807)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Ydbt1-0001Oh-K4
	for guix-devel@gnu.org; Thu, 02 Apr 2015 05:58:07 -0400
Received: by pddn5 with SMTP id n5so84743440pdd.2
	for <guix-devel@gnu.org>; Thu, 02 Apr 2015 02:58:06 -0700 (PDT)
In-Reply-To: <871tk2evlt.fsf@mango.localdomain>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> writes:

> =E5=AE=8B=E6=96=87=E6=AD=A6 writes:
>
>> * gnu/packages/fcitx.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>> ---
>
> [...]
>
>> +    (native-inputs
>> +     `(("doxygen"               ,doxygen)
>> +       ("glib:bin"              ,glib "bin") ; for glib-genmarshal
>> +       ("pkg-config"            ,pkg-config)))
>
> Why the large amount of space before the unquoted packages?
It's for the long work 'gobject-introspection', removed now :)
>
>> +    (description
>> +     "Fcitx is an input method framework with extension support.  It has
>> +PinYin, QuWei and Table-based input methods built-in.")
>
> s/Table-based/table-based/
OK.
>
> I'm not sure but capitalising the syllables in "PinYin" and "QuWei" is a
> bit odd.  I think the official pinyin spelling for Pinyin is "Pinyin"
> :)
Agree.

Adjusted and pushed, thanks for review!
>
> ~~ Ricardo