Re: [PATCH] gnu: Add fcitx.

[宋文武 <iyzsong@gmail.com>]

Ricardo Wurmus <rekado@elephly.net> writes:

> 宋文武 writes:
>
>> * gnu/packages/fcitx.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>> ---
>
> [...]
>
>> +    (native-inputs
>> +     `(("doxygen"               ,doxygen)
>> +       ("glib:bin"              ,glib "bin") ; for glib-genmarshal
>> +       ("pkg-config"            ,pkg-config)))
>
> Why the large amount of space before the unquoted packages?
It's for the long work 'gobject-introspection', removed now :)
>
>> +    (description
>> +     "Fcitx is an input method framework with extension support.  It has
>> +PinYin, QuWei and Table-based input methods built-in.")
>
> s/Table-based/table-based/
OK.
>
> I'm not sure but capitalising the syllables in "PinYin" and "QuWei" is a
> bit odd.  I think the official pinyin spelling for Pinyin is "Pinyin"
> :)
Agree.

Adjusted and pushed, thanks for review!
>
> ~~ Ricardo