From: 宋文武 <iyzsong@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add fcitx.
Date: Thu, 02 Apr 2015 17:58:36 +0800 [thread overview]
Message-ID: <87k2xukg1f.fsf@gmail.com> (raw)
In-Reply-To: <871tk2evlt.fsf@mango.localdomain>
Ricardo Wurmus <rekado@elephly.net> writes:
> 宋文武 writes:
>
>> * gnu/packages/fcitx.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>> ---
>
> [...]
>
>> + (native-inputs
>> + `(("doxygen" ,doxygen)
>> + ("glib:bin" ,glib "bin") ; for glib-genmarshal
>> + ("pkg-config" ,pkg-config)))
>
> Why the large amount of space before the unquoted packages?
It's for the long work 'gobject-introspection', removed now :)
>
>> + (description
>> + "Fcitx is an input method framework with extension support. It has
>> +PinYin, QuWei and Table-based input methods built-in.")
>
> s/Table-based/table-based/
OK.
>
> I'm not sure but capitalising the syllables in "PinYin" and "QuWei" is a
> bit odd. I think the official pinyin spelling for Pinyin is "Pinyin"
> :)
Agree.
Adjusted and pushed, thanks for review!
>
> ~~ Ricardo
prev parent reply other threads:[~2015-04-02 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 6:26 [PATCH] gnu: Add fcitx 宋文武
2015-04-02 9:18 ` Ricardo Wurmus
2015-04-02 9:58 ` 宋文武 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2xukg1f.fsf@gmail.com \
--to=iyzsong@gmail.com \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.