From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 02/02: gnu: harfbuzz: Add "bin" output.
Date: Tue, 15 Sep 2015 18:23:30 +0200
Message-ID: <87k2rraby5.fsf@gnu.org>
References: <20150915122151.14062.15456@vcs.savannah.gnu.org>
	<E1ZbpFC-0003g1-5k@vcs.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zbt18-0004Yr-Mh
	for guix-devel@gnu.org; Tue, 15 Sep 2015 12:23:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zbt13-0004Dr-Og
	for guix-devel@gnu.org; Tue, 15 Sep 2015 12:23:38 -0400
In-Reply-To: <E1ZbpFC-0003g1-5k@vcs.savannah.gnu.org> (iyzsong@gmail.com's
	message of "Tue, 15 Sep 2015 12:21:54 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: iyzsong@gmail.com
Cc: guix-devel@gnu.org

??? <iyzsong@gmail.com> skribis:

> commit eb6afbcde784a72a96f3c5a70d657630d421b02a
> Author: =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com>
> Date:   Tue Sep 15 20:19:39 2015 +0800
>
>     gnu: harfbuzz: Add "bin" output.
>=20=20=20=20=20
>     * gnu/packages/gtk.scm (harfbuzz)[outputs]: New field.
>       [arguments]<#:configure-flags>: Pass '--bindir'.

[...]

> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -154,6 +154,7 @@ affine transformation (scale, rotation, shear, etc.).=
")
>                (base32
>                 "1xrxlrvgyr6mm9qjxmkif2kvcah082y94gf1vqi0f0bdl1g8gp7b"))))
>     (build-system gnu-build-system)
> +   (outputs '("out" "bin"))

Could you add a comment explaining why things are split?  I suppose this
was motivated by the size of the closure or something, no?

Also, adding an explicit --bindir is normally not necessary: =E2=80=98confi=
gure=E2=80=99
in gnu-build-system.scm does that when there=E2=80=99s a =E2=80=9Cbin=E2=80=
=9D output.  Or did
it turn out to be buggy?

Thanks,
Ludo=E2=80=99.