From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@openmailbox.org>
Subject: Re: [PATCH] gnu: Add python-xlrd.
Date: Sat, 19 Sep 2015 17:49:28 +0200
Message-ID: <87k2rmflyv.fsf@openmailbox.org>
References: <55FD6561.8050608@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33241)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZdKOX-0006uS-JK
	for guix-devel@gnu.org; Sat, 19 Sep 2015 11:49:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZdKOU-0003NU-5T
	for guix-devel@gnu.org; Sat, 19 Sep 2015 11:49:45 -0400
Received: from smtp16.openmailbox.org ([62.4.1.50]:37769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZdKOT-0003NI-Sj
	for guix-devel@gnu.org; Sat, 19 Sep 2015 11:49:42 -0400
In-Reply-To: <55FD6561.8050608@uq.edu.au> (Ben Woodcroft's message of "Sat, 19
	Sep 2015 23:38:41 +1000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

> From cb470509de810ea93ac4e576bb0347225b68ad98 Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Sat, 19 Sep 2015 23:35:18 +1000
> Subject: [PATCH] gnu: Add python-xlrd.
>
> * gnu/packages/python.scm (python-xlrd, python2-xlrd): New variables.
> ---
>  gnu/packages/python.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)

[...]

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; current test in setup.py does not work as of 0.9.4,

=E2=80=9CCurrent=E2=80=9D

> +         ;; so use nose to run tests instead for now.
> +         (replace 'check (lambda _ (zero? (system* "nosetests")))))))
> +    (native-inputs
> +     `(("python-setuptools" ,python2-setuptools)
> +       ("python-nose" ,python2-nose)))

I don't know python packaging but when I look at other packages it
seems that these are usually used as =E2=80=9Cinputs=E2=80=9D not
=E2=80=9Cnative-inputs=E2=80=9D.

I think it should be =E2=80=9Cpython-*=E2=80=9D instead of =E2=80=9Cpython-=
2=E2=80=9D.  Am I wrong?

> +    (home-page "http://www.python-excel.org/")
> +    (synopsis
> +     "Library for extracting data from Microsoft Excel (tm) files")
> +    (description
> +     "Extract data from Excel spreadsheets (.xls and .xlsx, versions 2.0
> +onwards) on any platform.  It is pure Python (2.6, 2.7, 3.2+), has suppo=
rt for
> +Excel dates and is Unicode-aware.")

What about something like this?

        (synopsis "Library for extracting data from Excel files")
        (description "This packages provides a library to extract data from
    spreadsheets using Microsoft Excel=C2=AE proprietary file formats @samp=
{.xls} and
    @samp{.xlsx} (versions 2.0 onwards).  It has support for Excel dates an=
d is
    Unicode-aware.  It is not intended as an end-user tool.")

> +    (license bsd-3)))
> +(define-public python2-xlrd
> +  (package-with-python2 python-xlrd))

--
Mathieu Lirzin