From: Ricardo Wurmus <rekado@elephly.net>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add Blender
Date: Wed, 23 Sep 2015 08:45:24 +0200 [thread overview]
Message-ID: <87k2rhpraz.fsf@elephly.net> (raw)
In-Reply-To: <20150921184539.2cddac04@openmailbox.org>
Eric Bavier <ericbavier@openmailbox.org> writes:
>> +(define-public openimageio
>> + (package
> [...]
>> + (description
>> + "OpenImageIO is a library for reading and writing images, and a bunch of
> ^
> Align the opening quote to the 'd'.
Ah, good catch! I fixed this and pushed openimageio.
>> * gnu/packages/graphics.scm (blender): New variable.
[...]
>> + (add-after 'set-paths 'add-ilmbase-include-path
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + ;; OpenEXR propagates ilmbase, but its include files do not appear
>> + ;; in the CPATH, so we need to add "$ilmbase/include/OpenEXR/" to
>> + ;; the CPATH to satisfy the dependency on "half.h".
>> + (setenv "CPATH"
>> + (string-append (assoc-ref inputs "ilmbase")
>> + "/include/OpenEXR"
>> + ":" (getenv "CPATH")))
>
> Is the "half.h" header in OpenEXR, or in blender? If the latter, would
> it make more sense to instead patch the include directive to include
> the OpenEXR path?
“half.h” is provided by “ilmbase”. The include is in Blender, in this
file:
blender-2.75a/source/blender/imbuf/intern/openexr/openexr_api.cpp
I could patch this instead, replacing
#include <half.h>
with
#include <OpenEXR/half.h>
I’ll fix this, recompile and if there are no further objections push
upon success.
Thanks!
~~ Ricardo
next prev parent reply other threads:[~2015-09-23 6:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 20:46 [PATCH] Add Blender Ricardo Wurmus
2015-09-21 23:45 ` Eric Bavier
2015-09-23 6:45 ` Ricardo Wurmus [this message]
2015-09-23 10:17 ` Andreas Enge
2015-09-26 12:00 ` Ricardo Wurmus
2016-02-28 13:57 ` Ricardo Wurmus
2016-02-29 15:39 ` d.4.n.1
2016-04-25 19:21 ` Danny Milosavljevic
2016-04-25 21:43 ` Ludovic Courtès
2016-04-26 8:59 ` Danny Milosavljevic
2016-04-27 12:18 ` Ludovic Courtès
2015-09-26 12:47 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2rhpraz.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.