From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH 13/43] gnu: ghc-old-time: Add variable.
Date: Tue, 20 Oct 2015 15:48:23 +0200
Message-ID: <87k2qh4pnc.fsf@denknerd.org>
References: <1444911697-15515-1-git-send-email-paul@denknerd.org>
	<1444911697-15515-13-git-send-email-paul@denknerd.org>
	<20151019084637.3cf8a0e2@openmailbox.org>
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59738)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXHE-0007YI-Gh
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:48:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXH9-0006JH-Pa
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:48:32 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:16182 helo=mx-out02.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoXH9-0006J2-Ik
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:48:27 -0400
In-reply-to: <20151019084637.3cf8a0e2@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org


On 2015-10-19 at 15:46, quoth Eric Bavier:
> First line of commit message should rather be:
>
> "gnu: Add ghc-old-time"

Done.

>> +    (arguments
>> +     `(#:phases
>> +       (alist-cons-before
>> +        'configure 'fix-/bin/sh
>> +        (lambda _
>> +          ;; Use `sh', not `/bin/sh'.
>> +          (substitute* (find-files "." "Makefile|configure")
>> +            (("/bin/sh")
>> +             "sh")))
>
> Is this not already handled by the 'patch-source-shebangs' and
> 'patch-generated-file-shebangs' phases?

Nope, that didn't do the trick.  There were one or two packages where i
encountered that issue.

> This package is used in the "gnu: ghc-xmonad-contrib: Update to
> version 0.11.4." patch, so it should be moved before it.

Done.