From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 14/15] scripts: environment: Add --container option.
Date: Sat, 31 Oct 2015 11:28:25 +0100
Message-ID: <87k2q39vsm.fsf@gnu.org>
References: <1436188604-2813-1-git-send-email-dthompson2@worcester.edu>
	<1436188604-2813-14-git-send-email-dthompson2@worcester.edu>
	<87zj38f326.fsf@gnu.org>
	<CAJ=RwfZneE5REVTPULLKoh2V2yYNYnFa=gDSwiN=3CLN1eRLhw@mail.gmail.com>
	<87oah93zbk.fsf@gnu.org>
	<CAJ=RwfY8bs4hSXaN0SyTAZy89k4QFY=jG-vzLkarudkD9Q6Agg@mail.gmail.com>
	<87a8rpyzb9.fsf@gnu.org> <87d1wdn72e.fsf@gnu.org>
	<CAJ=RwfZwNSoxYDwPF1d2a23R5uLfpr-mzFuxEbWrH9J4br855Q@mail.gmail.com>
	<87k2qak4sb.fsf@gnu.org>
	<CAJ=RwfZRSiuGVWx4JvhgzaBqs7C5usLMxV-BSM3Do3+Vfjjt+A@mail.gmail.com>
	<874mhcy5yz.fsf@gnu.org>
	<CAJ=RwfbMx8T2+V-M+6oMeccpUQOdDkKJg9OLHeFMWE7Ckv9F7w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38214)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZsTOk-0000MH-Uj
	for guix-devel@gnu.org; Sat, 31 Oct 2015 06:28:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZsTOj-0001zM-In
	for guix-devel@gnu.org; Sat, 31 Oct 2015 06:28:34 -0400
In-Reply-To: <CAJ=RwfbMx8T2+V-M+6oMeccpUQOdDkKJg9OLHeFMWE7Ckv9F7w@mail.gmail.com>
	(David Thompson's message of "Fri, 30 Oct 2015 21:25:46 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel <guix-devel@gnu.org>, David Thompson <davet@gnu.org>

"Thompson, David" <dthompson2@worcester.edu> skribis:

> Hello, sorry for the delay.
>
> On Tue, Oct 27, 2015 at 6:13 AM, Ludovic Court=C3=A8s <ludo@gnu.org> wrot=
e:

[...]

>> What about automatically mapping $SHELL in the container when it is set?
>
> The issue is that the default command to evaluate is $SHELL or
> "/bin/sh."  You can be almost certain that $SHELL is not going to be
> available in the container.  What to do?  Check if the command is
> 'equal?' to (list (getenv "SHELL")) and make it '("/bin/sh") instead?

What I meant above is to to the equivalent --expose=3D$SHELL by default
when =E2=80=98SHELL=E2=80=99 is set.  Anything wrong with that?

If we did that, we could honor $SHELL even for --container (it=E2=80=99s al=
ready
honored in the other case.)

Thanks,
Ludo=E2=80=99.